Skip to content

Commit c858595

Browse files
committed
Merge branch 'MAGETWO-32115' of https://github.corp.ebay.com/magento-firedrakes/magento2ce into MAGETWO-32081
2 parents a437b12 + 8eb7dcd commit c858595

File tree

3 files changed

+33
-39
lines changed

3 files changed

+33
-39
lines changed

dev/tests/functional/composer.json

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
{
2-
"require": {
3-
"magento/mtf": "1.0.0-rc11",
4-
"php": ">=5.4.0",
5-
"phpunit/phpunit": "4.1.0",
6-
"phpunit/phpunit-selenium": ">=1.2",
7-
"netwing/selenium-server-standalone": ">=2.35"
8-
},
9-
"autoload": {
10-
"psr-4": {
11-
"Mtf\\": ["lib/Mtf/", "generated/Mtf/", "testsuites/Mtf/"],
12-
"Magento\\": ["generated/Magento/", "tests/app/Magento/"],
13-
"Test\\": "generated/Test/"
14-
}
2+
"require": {
3+
"magento/mtf": "1.0.0-rc11",
4+
"php": ">=5.4.0",
5+
"phpunit/phpunit": "4.1.0",
6+
"phpunit/phpunit-selenium": ">=1.2",
7+
"netwing/selenium-server-standalone": ">=2.35"
8+
},
9+
"autoload": {
10+
"psr-4": {
11+
"Mtf\\": ["lib/Mtf/", "generated/Mtf/", "testsuites/Mtf/"],
12+
"Magento\\": ["generated/Magento/", "tests/app/Magento/"],
13+
"Test\\": "generated/Test/"
1514
}
15+
}
1616
}

dev/tests/functional/lib/Mtf/ObjectManagerFactory.php

Lines changed: 19 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,9 @@
55

66
namespace Mtf;
77

8-
use Magento\Framework\App\Filesystem\DirectoryList;
9-
use Magento\Framework\ObjectManagerInterface as MagentoObjectManager;
10-
use Magento\Framework\Stdlib\BooleanUtils;
8+
use Mtf\ObjectManagerInterface as MagentoObjectManager;
9+
use Mtf\Stdlib\BooleanUtils;
1110
use Mtf\ObjectManager\Factory;
12-
use Mtf\System\Config as SystemConfig;
1311

1412
/**
1513
* Class ObjectManagerFactory
@@ -53,14 +51,11 @@ public function create(array $sharedInstances = [])
5351
}
5452

5553
$diConfig = new $this->configClassName();
56-
$systemConfig = new SystemConfig();
57-
$configuration = $systemConfig->getConfigParam();
58-
$diConfig->extend($configuration);
5954
$factory = new Factory($diConfig);
6055
$argInterpreter = $this->createArgumentInterpreter(new BooleanUtils());
61-
$argumentMapper = new \Magento\Framework\ObjectManager\Config\Mapper\Dom($argInterpreter);
56+
$argumentMapper = new \Mtf\ObjectManager\Config\Mapper\Dom($argInterpreter);
6257

63-
$sharedInstances['Magento\Framework\ObjectManager\Config\Mapper\Dom'] = $argumentMapper;
58+
$sharedInstances['Mtf\ObjectManager\Config\Mapper\Dom'] = $argumentMapper;
6459
$objectManager = new $this->locatorClassName($factory, $diConfig, $sharedInstances);
6560

6661
$factory->setObjectManager($objectManager);
@@ -85,35 +80,35 @@ protected function createDeploymentConfig(
8580
return new \Magento\Framework\App\DeploymentConfig(
8681
new \Magento\Framework\App\DeploymentConfig\Reader($directoryList),
8782
isset($arguments[\Magento\Framework\App\Arguments\Loader::PARAM_CUSTOM_FILE])
88-
? $arguments[\Magento\Framework\App\Arguments\Loader::PARAM_CUSTOM_FILE]
89-
: null
83+
? $arguments[\Magento\Framework\App\Arguments\Loader::PARAM_CUSTOM_FILE]
84+
: null
9085
);
9186
}
9287

9388
/**
9489
* Return newly created instance on an argument interpreter, suitable for processing DI arguments
9590
*
96-
* @param \Magento\Framework\Stdlib\BooleanUtils $booleanUtils
97-
* @return \Magento\Framework\Data\Argument\InterpreterInterface
91+
* @param \Mtf\Stdlib\BooleanUtils $booleanUtils
92+
* @return \Mtf\Data\Argument\InterpreterInterface
9893
*/
9994
protected function createArgumentInterpreter(
100-
\Magento\Framework\Stdlib\BooleanUtils $booleanUtils
95+
\Mtf\Stdlib\BooleanUtils $booleanUtils
10196
) {
102-
$constInterpreter = new \Magento\Framework\Data\Argument\Interpreter\Constant();
103-
$result = new \Magento\Framework\Data\Argument\Interpreter\Composite(
97+
$constInterpreter = new \Mtf\Data\Argument\Interpreter\Constant();
98+
$result = new \Mtf\Data\Argument\Interpreter\Composite(
10499
[
105-
'boolean' => new \Magento\Framework\Data\Argument\Interpreter\Boolean($booleanUtils),
106-
'string' => new \Magento\Framework\Data\Argument\Interpreter\String($booleanUtils),
107-
'number' => new \Magento\Framework\Data\Argument\Interpreter\Number(),
108-
'null' => new \Magento\Framework\Data\Argument\Interpreter\NullType(),
100+
'boolean' => new \Mtf\Data\Argument\Interpreter\Boolean($booleanUtils),
101+
'string' => new \Mtf\Data\Argument\Interpreter\String($booleanUtils),
102+
'number' => new \Mtf\Data\Argument\Interpreter\Number(),
103+
'null' => new \Mtf\Data\Argument\Interpreter\NullType(),
109104
'const' => $constInterpreter,
110-
'object' => new \Magento\Framework\Data\Argument\Interpreter\Object($booleanUtils),
111-
'init_parameter' => new \Magento\Framework\App\Arguments\ArgumentInterpreter($constInterpreter),
105+
'object' => new \Mtf\Data\Argument\Interpreter\Object($booleanUtils),
106+
'init_parameter' => new \Mtf\Data\Argument\Interpreter\Argument($constInterpreter),
112107
],
113-
\Magento\Framework\ObjectManager\Config\Reader\Dom::TYPE_ATTRIBUTE
108+
\Mtf\ObjectManager\Config\Reader\Dom::TYPE_ATTRIBUTE
114109
);
115110
// Add interpreters that reference the composite
116-
$result->addInterpreter('array', new \Magento\Framework\Data\Argument\Interpreter\ArrayType($result));
111+
$result->addInterpreter('array', new \Mtf\Data\Argument\Interpreter\ArrayType($result));
117112
return $result;
118113
}
119114

dev/tests/functional/utils/bootstrap.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,5 @@
1313
require $appRoot . '/app/bootstrap.php';
1414
require __DIR__ . '/../vendor/autoload.php';
1515

16-
$objectManagerFactory = \Magento\Framework\App\Bootstrap::createObjectManagerFactory(BP, $_SERVER);
17-
$objectManager = $objectManagerFactory->create($_SERVER);
16+
$objectManager = \Mtf\ObjectManagerFactory::getObjectManager();
1817
\Mtf\ObjectManagerFactory::configure($objectManager);

0 commit comments

Comments
 (0)