Merge pull request #4697 from magento-trigger/MC-19684

[TR] MC-19684: Some minute values cannot be set for Analytics data collection

Author: fascinosum

app/code/Magento/Analytics/Test/Mftf/Test/AdminConfigurationTimeToSendDataTest.xml

@@ -25,9 +25,9 @@
         <amOnPage url="{{AdminConfigGeneralAnalyticsPage.url}}" stepKey="amOnAdminConfig"/>
         <selectOption selector="{{AdminConfigAdvancedReportingSection.advancedReportingService}}" userInput="Enable" stepKey="selectAdvancedReportingServiceEnabled"/>
         <selectOption selector="{{AdminConfigAdvancedReportingSection.advancedReportingIndustry}}" userInput="Apps and Games" stepKey="selectAdvancedReportingIndustry"/>
-        <selectOption selector="{{AdminConfigAdvancedReportingSection.advancedReportingHour}}" userInput="11" stepKey="selectAdvancedReportingHour"/>
-        <selectOption selector="{{AdminConfigAdvancedReportingSection.advancedReportingMinute}}" userInput="11" stepKey="selectAdvancedReportingMinute"/>
-        <selectOption selector="{{AdminConfigAdvancedReportingSection.advancedReportingSeconds}}" userInput="00" stepKey="selectAdvancedReportingSeconds"/>
+        <selectOption selector="{{AdminConfigAdvancedReportingSection.advancedReportingHour}}" userInput="23" stepKey="selectAdvancedReportingHour"/>
+        <selectOption selector="{{AdminConfigAdvancedReportingSection.advancedReportingMinute}}" userInput="59" stepKey="selectAdvancedReportingMinute"/>
+        <selectOption selector="{{AdminConfigAdvancedReportingSection.advancedReportingSeconds}}" userInput="59" stepKey="selectAdvancedReportingSeconds"/>
         <click selector="{{AdminMainActionsSection.save}}" stepKey="clickSaveConfigButton"/>
         <see selector="{{AdminMessagesSection.success}}" userInput="You saved the configuration." stepKey="seeSuccess"/>
     </test>

dev/tests/functional/tests/app/Magento/CheckoutAgreements/Test/Block/Adminhtml/Block/Agreement/Edit/AgreementsForm.xml

@@ -18,7 +18,7 @@
             <input>select</input>
         </mode>
         <stores>
-            <selector>[name="stores[0]"]</selector>
+            <selector>[name="stores[]"]</selector>
             <input>multiselectgrouplist</input>
         </stores>
         <checkbox_text />

dev/tests/functional/tests/app/Magento/Customer/Test/Block/Form/CustomerForm.php

@@ -29,7 +29,7 @@ class CustomerForm extends Form
      *
      * @var string
      */
-    protected $customerAttribute = "[orig-name='%s[]']";
+    protected $customerAttribute = "[name='%s[]']";
 
     /**
      * Validation text message for a field.

dev/tests/functional/tests/app/Magento/Newsletter/Test/Block/Adminhtml/Queue/Edit/QueueForm.xml

@@ -11,7 +11,7 @@
             <selector>input[name='start_at']</selector>
         </queue_start_at>
         <stores>
-            <selector>select[name="stores[0]"]</selector>
+            <selector>select[name="stores[]"]</selector>
             <input>multiselectgrouplist</input>
         </stores>
         <newsletter_subject>

dev/tests/functional/tests/app/Magento/Reports/Test/Block/Adminhtml/Sales/Coupons/Filter.xml

@@ -29,7 +29,7 @@
             <input>select</input>
         </price_rule_type>
         <order_statuses>
-            <selector>[name="order_statuses[0]"]</selector>
+            <selector>[name="order_statuses[]"]</selector>
             <input>multiselect</input>
         </order_statuses>
         <rules_list>

dev/tests/functional/tests/app/Magento/Reports/Test/Block/Adminhtml/Sales/TaxRule/Filter.xml

@@ -23,7 +23,7 @@
             <input>select</input>
         </show_order_statuses>
         <order_statuses>
-            <selector>[name="order_statuses[0]"]</selector>
+            <selector>[name="order_statuses[]"]</selector>
             <input>multiselect</input>
         </order_statuses>
         <show_empty_rows>

dev/tests/functional/tests/app/Magento/Review/Test/Block/Adminhtml/Rating/Edit/RatingForm.xml

@@ -12,7 +12,7 @@
         <strategy>css selector</strategy>
         <fields>
             <stores>
-                <selector>[name="stores[0]"]</selector>
+                <selector>[name="stores[]"]</selector>
                 <input>multiselectgrouplist</input>
             </stores>
             <is_active>

dev/tests/functional/tests/app/Magento/Sales/Test/Block/Adminhtml/Report/Filter/Form.xml

@@ -26,7 +26,7 @@
             <input>select</input>
         </show_order_statuses>
         <order_statuses>
-            <selector>[name="order_statuses[0]"]</selector>
+            <selector>[name="order_statuses[]"]</selector>
             <input>multiselect</input>
         </order_statuses>
         <show_actual_columns>

lib/web/mage/validation.js

@@ -1925,7 +1925,6 @@
          * @protected
          */
         _create: function () {
-            this._prepareArrayInputs();
             this.validate = this.element.validate(this.options);
 
             // ARIA (adding aria-required attribute)
@@ -1938,50 +1937,6 @@
             this._listenFormValidate();
         },
 
-        /**
-         * Validation creation.
-         *
-         * @protected
-         */
-        _prepareArrayInputs: function () {
-            /* Store original names for array inputs */
-            var originalElements = [],
-                originalSubmitHandler = this.options.submitHandler;
-
-            /* For all array inputs, assign index so that validation is proper */
-            this.element.find('[name$="[]"]').each(function (key, input) {
-                var originalName, name;
-
-                input = $(input);
-                originalName = input.attr('name');
-                name = originalName.replace('[]', '[' + key + ']');
-                $(input).attr('name', name);
-                $(input).attr('orig-name', originalName);
-                originalElements.push({
-                    element: $(input),
-                    name: originalName
-                });
-            });
-
-            if (originalElements.length) {
-                /**
-                 *  Before submitting the actual form, remove the previously assigned indices
-                 *  @param {Object} form
-                 */
-                this.options.submitHandler = function (form) {
-                    originalElements.forEach(function (element) {
-                        element.element.attr('name', element.name);
-                        element.element.removeAttr('orig-name');
-                    });
-
-                    console.error(this.submit);
-
-                    /* Call the originalSubmitHandler if it's a function */
-                    typeof originalSubmitHandler === 'function' ? originalSubmitHandler(form) : form.submit();
-                };
-            }
-        },
-
         /**
          * Validation listening.
          *

lib/web/mage/validation/validation.js

@@ -49,23 +49,18 @@
         'validate-one-checkbox-required-by-name': [
             function (value, element, params) {
                 var checkedCount = 0,
-                    selector,
-                    container,
-                    origNameSelector,
-                    nameSelector;
+                    container;
 
                 if (element.type === 'checkbox') {
-                    /* If orig-name attribute is present, use it for validation. Else use name */
-                    origNameSelector = '[orig-name="' + element.getAttribute('orig-name') + '"]';
-                    nameSelector = '[name="' + element.name + '"]';
-                    selector = element.getAttribute('orig-name') ? origNameSelector : nameSelector;
-                    $(selector).each(function () {
-                        if ($(this).is(':checked')) {
-                            checkedCount += 1;
-
-                            return false;
+                    $('[name="' + element.name + '"]').each(
+                        function () {
+                            if ($(this).is(':checked')) {
+                                checkedCount += 1;
+
+                                return false;
+                            }
                         }
-                    });
+                    );
                 }
                 container = '#' + params;