MAGETWO-53474: [Github] Caches Aren't Enabled by Default on RC1 with Composer when Upgrading via CLI

mazhalai · mazhalai · commit c840f1a72de6 · 2016-05-27T09:06:49.000-05:00
- CR comments
diff --git a/setup/src/Magento/Setup/Console/Command/UpgradeCommand.php b/setup/src/Magento/Setup/Console/Command/UpgradeCommand.php
@@ -130,7 +130,7 @@ private function enableCaches($objectManager, $output)
                 $output->writeln('<error> Error occured during upgrade</error>');
                 return \Magento\Framework\Console\Cli::RETURN_FAILURE;
             }
-            return \Magento\Framework\Console\Cli::RETURN_SUCCESS;
         }
+        return \Magento\Framework\Console\Cli::RETURN_SUCCESS;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,7 @@ private function enableCaches($objectManager, $output)`
`130`	`130`	`$output->writeln('<error> Error occured during upgrade</error>');`
`131`	`131`	`return \Magento\Framework\Console\Cli::RETURN_FAILURE;`
`132`	`132`	`}`
`133`		`- return \Magento\Framework\Console\Cli::RETURN_SUCCESS;`
`134`	`133`	`}`
	`134`	`+ return \Magento\Framework\Console\Cli::RETURN_SUCCESS;`
`135`	`135`	`}`
`136`	`136`	`}`