MAGETWO-87974: Can't hide product images via hide_from_product_page attribute during import

- Removed show_on_product_page field form export/import;

Author: Alexey Yakimovich

app/code/Magento/CatalogImportExport/Model/Export/Product.php

@@ -734,7 +734,6 @@ protected function setHeaderColumns($customOptionsData, $stockItemRows)
                     'additional_images',
                     'additional_image_labels',
                     'hide_from_product_page',
-                    'show_on_product_page',
                     'custom_options'
                 ]
             );
@@ -1199,16 +1198,13 @@ private function appendMultirowData(&$dataRow, $multiRawData)
                 $additionalImages = [];
                 $additionalImageLabels = [];
                 $additionalImageIsDisabled = [];
-                $additionalImageIsEnabled = [];
                 foreach ($multiRawData['mediaGalery'][$productLinkId] as $mediaItem) {
                     if ((int)$mediaItem['_media_store_id'] === Store::DEFAULT_STORE_ID) {
                         $additionalImages[] = $mediaItem['_media_image'];
                         $additionalImageLabels[] = $mediaItem['_media_label'];
 
                         if ($mediaItem['_media_is_disabled'] == true) {
                             $additionalImageIsDisabled[] = $mediaItem['_media_image'];
-                        } else {
-                            $additionalImageIsEnabled[] = $mediaItem['_media_image'];
                         }
                     }
                 }
@@ -1218,8 +1214,6 @@ private function appendMultirowData(&$dataRow, $multiRawData)
                     implode(Import::DEFAULT_GLOBAL_MULTI_VALUE_SEPARATOR, $additionalImageLabels);
                 $dataRow['hide_from_product_page'] =
                     implode(Import::DEFAULT_GLOBAL_MULTI_VALUE_SEPARATOR, $additionalImageIsDisabled);
-                $dataRow['show_on_product_page'] =
-                    implode(Import::DEFAULT_GLOBAL_MULTI_VALUE_SEPARATOR, $additionalImageIsEnabled);
                 $multiRawData['mediaGalery'][$productLinkId] = [];
             }
             foreach ($this->_linkTypeProvider->getLinkTypes() as $linkTypeName => $linkId) {
@@ -1253,8 +1247,6 @@ private function appendMultirowData(&$dataRow, $multiRawData)
                     if ((int)$mediaItem['_media_store_id'] === $storeId) {
                         if ($mediaItem['_media_is_disabled'] == true) {
                             $additionalImageIsDisabled[] = $mediaItem['_media_image'];
-                        } else {
-                            $additionalImageIsEnabled[] = $mediaItem['_media_image'];
                         }
                     }
                 }
@@ -1263,10 +1255,6 @@ private function appendMultirowData(&$dataRow, $multiRawData)
                 $dataRow['hide_from_product_page'] =
                     implode(Import::DEFAULT_GLOBAL_MULTI_VALUE_SEPARATOR, $additionalImageIsDisabled);
             }
-            if ($additionalImageIsEnabled) {
-                $dataRow['show_on_product_page'] =
-                    implode(Import::DEFAULT_GLOBAL_MULTI_VALUE_SEPARATOR, $additionalImageIsEnabled);
-            }
         }
 
         if (!empty($this->collectedMultiselectsData[$storeId][$productId])) {

app/code/Magento/CatalogImportExport/Model/Import/Product.php

@@ -312,7 +312,6 @@ class Product extends \Magento\ImportExport\Model\Import\Entity\AbstractEntity
         self::COL_MEDIA_IMAGE => 'additional_images',
         '_media_image_label' => 'additional_image_labels',
         '_media_is_disabled' => 'hide_from_product_page',
-        '_media_is_enabled' => 'show_on_product_page',
         Product::COL_STORE => 'store_view_code',
         Product::COL_ATTR_SET => 'attribute_set_code',
         Product::COL_TYPE => 'product_type',
@@ -1945,8 +1944,7 @@ private function getImagesHiddenStates($rowData)
     {
         $statesArray = [];
         $mappingArray = [
-            '_media_is_disabled' => '1',
-            '_media_is_enabled' => '0'
+            '_media_is_disabled' => '1'
         ];
 
         foreach ($mappingArray as $key => $value) {