Merge branch '2.3-develop' of github.com:magento/magento2 into 2.3-develop-missing-phpdoc-comment

Author: Leandro Ferraz Luvisotto

.github/ISSUE_TEMPLATE.md

@@ -28,8 +28,8 @@
 
 ### Expected result
 <!--- Tell us what should happen -->
-1. [Screenshot, logs]
+1. [Screenshots, logs or description]
 
 ### Actual result
 <!--- Tell us what happens instead -->
-1. [Screenshot, logs]
+1. [Screenshots, logs or description]

app/code/Magento/Braintree/Test/Unit/Gateway/Response/PayPal/VaultDetailsHandlerTest.php

@@ -88,7 +88,7 @@ protected function setUp()
 
         $this->paymentInfoMock = $this->getMockBuilder(Payment::class)
             ->disableOriginalConstructor()
-            ->setMethods(['__wakeup'])
+            ->setMethods(['__wakeup', 'getExtensionAttributes'])
             ->getMock();
 
         $this->paymentTokenMock = $objectManager->getObject(PaymentToken::class);
@@ -107,6 +107,10 @@ protected function setUp()
             ->setMethods(['create'])
             ->getMock();
 
+        $this->paymentInfoMock->expects(self::any())
+            ->method('getExtensionAttributes')
+            ->willReturn($this->paymentExtensionMock);
+
         $this->subject = [
             'payment' => $this->paymentDataObjectMock,
         ];
@@ -184,7 +188,7 @@ public function testHandleWithoutToken()
             ->method('create');
 
         $this->handler->handle($this->subject, $response);
-        self::assertNull($this->paymentInfoMock->getExtensionAttributes());
+        self::assertNotNull($this->paymentInfoMock->getExtensionAttributes());
     }
 
     /**

app/code/Magento/Braintree/Test/Unit/Gateway/Response/VaultDetailsHandlerTest.php

@@ -80,9 +80,11 @@ protected function setUp()
 
         $this->payment = $this->getMockBuilder(Payment::class)
             ->disableOriginalConstructor()
-            ->setMethods(['__wakeup'])
+            ->setMethods(['__wakeup', 'getExtensionAttributes'])
             ->getMock();
 
+        $this->payment->expects(self::any())->method('getExtensionAttributes')->willReturn($this->paymentExtension);
+
         $config = $this->getConfigMock();
 
         $this->paymentHandler = new VaultDetailsHandler(

app/code/Magento/Braintree/Test/Unit/Model/Paypal/Helper/QuoteUpdaterTest.php

@@ -13,6 +13,7 @@
 use Magento\Braintree\Observer\DataAssignObserver;
 use Magento\Braintree\Gateway\Config\PayPal\Config;
 use Magento\Braintree\Model\Paypal\Helper\QuoteUpdater;
+use Magento\Quote\Api\Data\CartExtensionInterface;
 
 /**
  * Class QuoteUpdaterTest
@@ -281,7 +282,7 @@ private function updateQuoteStep(\PHPUnit_Framework_MockObject_MockObject $quote
      */
     private function getQuoteMock()
     {
-        return $this->getMockBuilder(Quote::class)
+        $quoteMock = $this->getMockBuilder(Quote::class)
             ->setMethods(
                 [
                     'getIsVirtual',
@@ -291,9 +292,21 @@ private function getQuoteMock()
                     'collectTotals',
                     'getShippingAddress',
                     'getBillingAddress',
+                    'getExtensionAttributes'
                 ]
             )->disableOriginalConstructor()
             ->getMock();
+
+        $cartExtensionMock = $this->getMockBuilder(CartExtensionInterface::class)
+            ->setMethods(['setShippingAssignments'])
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $quoteMock->expects(self::any())
+            ->method('getExtensionAttributes')
+            ->willReturn($cartExtensionMock);
+
+        return $quoteMock;
     }
 
     /**

app/code/Magento/Catalog/Block/Product/Compare/ListCompare.php

@@ -213,6 +213,22 @@ public function getProductAttributeValue($product, $attribute)
         return (string)$value == '' ? __('No') : $value;
     }
 
+    /**
+     * Check if any of the products has a value set for the attribute
+     *
+     * @param \Magento\Catalog\Model\ResourceModel\Eav\Attribute $attribute
+     * @return bool
+     */
+    public function hasAttributeValueForProducts($attribute)
+    {
+        foreach ($this->getItems() as $item) {
+            if ($item->hasData($attribute->getAttributeCode())) {
+                return true;
+            }
+        }
+        return false;
+    }
+
     /**
      * Retrieve Print URL
      *

app/code/Magento/Catalog/Model/Product.php

@@ -2535,13 +2535,7 @@ public function setTypeId($typeId)
      */
     public function getExtensionAttributes()
     {
-        $extensionAttributes = $this->_getExtensionAttributes();
-        if (null === $extensionAttributes) {
-            /** @var \Magento\Catalog\Api\Data\ProductExtensionInterface $extensionAttributes */
-            $extensionAttributes = $this->extensionAttributesFactory->create(ProductInterface::class);
-            $this->setExtensionAttributes($extensionAttributes);
-        }
-        return $extensionAttributes;
+        return $this->_getExtensionAttributes();
     }
 
     /**

app/code/Magento/Catalog/Model/Product/Price/TierPriceStorage.php

@@ -172,8 +172,10 @@ private function getExistingPrices(array $skus, $groupBySku = false)
         $rawPrices = $this->tierPricePersistence->get($ids);
         $prices = [];
 
+        $linkField = $this->tierPricePersistence->getEntityLinkField();
+        $skuByIdLookup = $this->buildSkuByIdLookup($skus);
         foreach ($rawPrices as $rawPrice) {
-            $sku = $this->retrieveSkuById($rawPrice[$this->tierPricePersistence->getEntityLinkField()], $skus);
+            $sku = $skuByIdLookup[$rawPrice[$linkField]];
             $price = $this->tierPriceFactory->create($rawPrice, $sku);
             if ($groupBySku) {
                 $prices[$sku][] = $price;
@@ -300,21 +302,21 @@ private function isCorrectPriceValue(array $existingPrice, array $price)
     }
 
     /**
-     * Retrieve SKU by product ID.
+     * Generate lookup to retrieve SKU by product ID.
      *
-     * @param int $id
      * @param array $skus
-     * @return string|null
+     * @return array
      */
-    private function retrieveSkuById($id, $skus)
+    private function buildSkuByIdLookup($skus)
     {
+        $lookup = [];
         foreach ($this->productIdLocator->retrieveProductIdsBySkus($skus) as $sku => $ids) {
-            if (isset($ids[$id])) {
-                return $sku;
+            foreach (array_keys($ids) as $id) {
+                $lookup[$id] = $sku;
             }
         }
 
-        return null;
+        return $lookup;
     }
 
     /**

app/code/Magento/Catalog/Model/ResourceModel/Product/Collection.php

@@ -1570,7 +1570,7 @@ protected function getEntityPkName(\Magento\Eav\Model\Entity\AbstractEntity $ent
     }
 
     /**
-     * Add requere tax percent flag for product collection
+     * Add require tax percent flag for product collection
      *
      * @return $this
      */

app/code/Magento/Catalog/Plugin/Block/Topmenu.php

@@ -162,6 +162,7 @@ private function getCategoryAsArray($category, $currentCategory, $isParentActive
             'url' => $this->catalogCategory->getCategoryUrl($category),
             'has_active' => in_array((string)$category->getId(), explode('/', $currentCategory->getPath()), true),
             'is_active' => $category->getId() == $currentCategory->getId(),
+            'is_category' => true,
             'is_parent_active' => $isParentActive
         ];
     }

app/code/Magento/Catalog/Test/Unit/Model/CustomOptions/CustomOptionTest.php

@@ -7,6 +7,8 @@
 
 use Magento\Catalog\Model\CustomOptions\CustomOption;
 use Magento\Catalog\Model\Webapi\Product\Option\Type\File\Processor as FileProcessor;
+use Magento\Framework\Api\ExtensionAttributesFactory;
+use Magento\Catalog\Api\Data\CustomOptionExtensionInterface;
 
 class CustomOptionTest extends \PHPUnit\Framework\TestCase
 {
@@ -15,6 +17,12 @@ class CustomOptionTest extends \PHPUnit\Framework\TestCase
      */
     protected $model;
 
+    /** @var \Magento\Framework\Api\ExtensionAttributesFactory | \PHPUnit_Framework_MockObject_MockObject */
+    private $extensionAttributesFactoryMock;
+
+    /** @var \Magento\Catalog\Api\Data\CustomOptionExtensionInterface | \PHPUnit_Framework_MockObject_MockObject */
+    private $extensionMock;
+
     /**
      * @var FileProcessor | \PHPUnit_Framework_MockObject_MockObject
      */
@@ -30,7 +38,7 @@ protected function setUp()
             ->disableOriginalConstructor()
             ->getMock();
 
-        $extensionAttributesFactory = $this->getMockBuilder(\Magento\Framework\Api\ExtensionAttributesFactory::class)
+        $this->extensionAttributesFactoryMock = $this->getMockBuilder(ExtensionAttributesFactory::class)
             ->disableOriginalConstructor()
             ->getMock();
 
@@ -52,10 +60,17 @@ protected function setUp()
             ->disableOriginalConstructor()
             ->getMock();
 
+        $this->extensionMock = $this->getMockBuilder(\Magento\Catalog\Api\Data\CustomOptionExtensionInterface::class)
+            ->setMethods(['getFileInfo'])
+            ->getMockForAbstractClass();
+
+        $this->extensionAttributesFactoryMock->expects(self::any())
+            ->method('create')->willReturn($this->extensionMock);
+
         $this->model = new CustomOption(
             $context,
             $registry,
-            $extensionAttributesFactory,
+            $this->extensionAttributesFactoryMock,
             $attributeValueFactory,
             $this->fileProcessor,
             $resource,
@@ -84,14 +99,10 @@ public function testGetOptionValue()
 
     public function testGetOptionValueWithFileInfo()
     {
-        $customOption = $this->getMockBuilder(\Magento\Catalog\Api\Data\CustomOptionExtensionInterface::class)
-            ->setMethods(['getFileInfo'])
-            ->getMockForAbstractClass();
-
         $imageContent = $this->getMockBuilder(\Magento\Framework\Api\Data\ImageContentInterface::class)
             ->getMockForAbstractClass();
 
-        $customOption->expects($this->once())
+        $this->extensionMock->expects($this->once())
             ->method('getFileInfo')
             ->willReturn($imageContent);
 
@@ -112,7 +123,6 @@ public function testGetOptionValueWithFileInfo()
             ->with($imageContent)
             ->willReturn($imageResult);
 
-        $this->model->setExtensionAttributes($customOption);
         $this->model->setData(\Magento\Catalog\Api\Data\CustomOptionInterface::OPTION_VALUE, 'file');
         $this->assertEquals($imageResult, $this->model->getOptionValue());
     }