Skip to content

Commit c753cd7

Browse files
author
Olga Kopylova
committed
MAGETWO-39191: Contribution of bugs/tasks in Sprint 32
Merge remote-tracking branch 'mainline/develop' into PR_Branch Conflicts: dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_classes.php
2 parents 818895f + 434fbd0 commit c753cd7

File tree

928 files changed

+13693
-4663
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

928 files changed

+13693
-4663
lines changed

.htaccess

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -65,13 +65,6 @@
6565
SecFilterScanPOST Off
6666
</IfModule>
6767

68-
<IfModule mod_headers.c>
69-
############################################
70-
## prevent clickjacking
71-
72-
Header set X-Frame-Options SAMEORIGIN
73-
</IfModule>
74-
7568
<IfModule mod_deflate.c>
7669

7770
############################################
@@ -187,4 +180,4 @@
187180
## If running in cluster environment, uncomment this
188181
## http://developer.yahoo.com/performance/rules.html#etags
189182

190-
#FileETag none
183+
#FileETag none

app/code/Magento/AdminNotification/Block/Window.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ protected function _toHtml()
7676
if ($this->canShow()) {
7777
$this->setHeaderText($this->escapeHtml(__('Incoming Message')));
7878
$this->setCloseText($this->escapeHtml(__('close')));
79-
$this->setReadDetailsText($this->escapeHtml(__('Read details')));
79+
$this->setReadDetailsText($this->escapeHtml(__('Read Details')));
8080
$this->setNoticeMessageText($this->escapeHtml($this->_getLatestItem()->getTitle()));
8181
$this->setNoticeMessageUrl($this->escapeUrl($this->_getLatestItem()->getUrl()));
8282
$this->setSeverityText('critical');

app/code/Magento/AdminNotification/Controller/Adminhtml/Notification.php

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -14,26 +14,6 @@ class Notification extends \Magento\Backend\App\AbstractAction
1414
*/
1515
protected function _isAllowed()
1616
{
17-
switch ($this->getRequest()->getActionName()) {
18-
case 'markAsRead':
19-
$acl = 'Magento_AdminNotification::mark_as_read';
20-
break;
21-
22-
case 'massMarkAsRead':
23-
$acl = 'Magento_AdminNotification::mark_as_read';
24-
break;
25-
26-
case 'remove':
27-
$acl = 'Magento_AdminNotification::adminnotification_remove';
28-
break;
29-
30-
case 'massRemove':
31-
$acl = 'Magento_AdminNotification::adminnotification_remove';
32-
break;
33-
34-
default:
35-
$acl = 'Magento_AdminNotification::show_list';
36-
}
37-
return $this->_authorization->isAllowed($acl);
17+
return $this->_authorization->isAllowed('Magento_AdminNotification::show_list');
3818
}
3919
}

app/code/Magento/AdminNotification/Controller/Adminhtml/Notification/MarkAsRead.php

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,4 +36,12 @@ public function execute()
3636
}
3737
$this->_redirect('adminhtml/*/');
3838
}
39+
40+
/**
41+
* @return bool
42+
*/
43+
protected function _isAllowed()
44+
{
45+
return $this->_authorization->isAllowed('Magento_AdminNotification::mark_as_read');
46+
}
3947
}

app/code/Magento/AdminNotification/Controller/Adminhtml/Notification/MassMarkAsRead.php

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,4 +38,12 @@ public function execute()
3838
}
3939
$this->_redirect('adminhtml/*/');
4040
}
41+
42+
/**
43+
* @return bool
44+
*/
45+
protected function _isAllowed()
46+
{
47+
return $this->_authorization->isAllowed('Magento_AdminNotification::mark_as_read');
48+
}
4149
}

app/code/Magento/AdminNotification/Controller/Adminhtml/Notification/MassRemove.php

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,4 +33,12 @@ public function execute()
3333
}
3434
$this->getResponse()->setRedirect($this->_redirect->getRedirectUrl($this->getUrl('*')));
3535
}
36+
37+
/**
38+
* @return bool
39+
*/
40+
protected function _isAllowed()
41+
{
42+
return $this->_authorization->isAllowed('Magento_AdminNotification::adminnotification_remove');
43+
}
3644
}

app/code/Magento/AdminNotification/Controller/Adminhtml/Notification/Remove.php

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,4 +35,12 @@ public function execute()
3535
}
3636
$this->_redirect('adminhtml/*/');
3737
}
38+
39+
/**
40+
* @return bool
41+
*/
42+
protected function _isAllowed()
43+
{
44+
return $this->_authorization->isAllowed('Magento_AdminNotification::adminnotification_remove');
45+
}
3846
}

app/code/Magento/AdminNotification/Model/System/Message/Baseurl.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ public function getText()
120120
{
121121
return __(
122122
'{{base_url}} is not recommended to use in a production environment to declare the Base Unsecure '
123-
. 'URL / Base Secure URL. It is highly recommended to change this value in your Magento '
123+
. 'URL / Base Secure URL. We highly recommend changing this value in your Magento '
124124
. '<a href="%1">configuration</a>.',
125125
$this->_getConfigUrl()
126126
);

app/code/Magento/AdminNotification/Model/System/Message/Media/Synchronization/Error.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,7 @@ protected function _shouldBeDisplayed()
3434
public function getText()
3535
{
3636
return __(
37-
'One or more media files failed to be synchronized during the media storages synchronization process. '
38-
. 'Refer to the log file for details.'
37+
'We were unable to synchronize one or more media files. Please refer to the log file for details.'
3938
);
4039
}
4140
}

app/code/Magento/AdminNotification/Model/System/Message/Security.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,8 +135,8 @@ public function isDisplayed()
135135
public function getText()
136136
{
137137
return __(
138-
'Your web server is configured incorrectly. As a result, configuration files '
139-
. ' with sensitive information are accessible from the outside. Please contact your hosting provider.'
138+
'Your web server is set up incorrectly and allows unauthorized access to sensitive files. '
139+
. 'Please contact your hosting provider.'
140140
);
141141
}
142142

0 commit comments

Comments
 (0)