magento/magento2:#18979 - API: Bundle Product Option Repository Delete method removes incorrect option

Vasilii Burlacu · Vasilii Burlacu · commit c720d972108e · 2018-11-02T15:08:32.000+02:00
diff --git a/app/code/Magento/Bundle/Model/OptionRepository.php b/app/code/Magento/Bundle/Model/OptionRepository.php
@@ -160,10 +160,9 @@ public function delete(\Magento\Bundle\Api\Data\OptionInterface $option)
      */
     public function deleteById($sku, $optionId)
     {
-        $product = $this->getProduct($sku);
-        $optionCollection = $this->type->getOptionsCollection($product);
-        $optionCollection->setIdFilter($optionId);
-        $hasBeenDeleted = $this->delete($optionCollection->getFirstItem());
+        /** @var \Magento\Bundle\Api\Data\OptionInterface $option */
+        $option = $this->get($sku, $optionId);
+        $hasBeenDeleted = $this->delete($option);
 
         return $hasBeenDeleted;
     }

Original file line number	Diff line number	Diff line change
`@@ -160,10 +160,9 @@ public function delete(\Magento\Bundle\Api\Data\OptionInterface $option)`
`160`	`160`	`*/`
`161`	`161`	`public function deleteById($sku, $optionId)`
`162`	`162`	`{`
`163`		`- $product = $this->getProduct($sku);`
`164`		`- $optionCollection = $this->type->getOptionsCollection($product);`
`165`		`- $optionCollection->setIdFilter($optionId);`
`166`		`- $hasBeenDeleted = $this->delete($optionCollection->getFirstItem());`
	`163`	`+ /** @var \Magento\Bundle\Api\Data\OptionInterface $option */`
	`164`	`+ $option = $this->get($sku, $optionId);`
	`165`	`+ $hasBeenDeleted = $this->delete($option);`
`167`	`166`
`168`	`167`	`return $hasBeenDeleted;`
`169`	`168`	`}`