Skip to content

Commit c719442

Browse files
ENGCOM-7562: Set property to false to avoid state being ignored on bookmark #28220
- Merge Pull Request #28220 from gabrieldagama/magento2:image-preview-bookmark-issue - Merged commits: 1. a990468 2. 8f841a0 3. b1f56c4 4. 8eae1b5 5. bfa589a
2 parents 4040a32 + bfa589a commit c719442

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

app/code/Magento/Ui/view/base/web/js/grid/columns/image-preview.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ define([
1616
visibleRecord: null,
1717
height: 0,
1818
displayedRecord: {},
19-
lastOpenedImage: null,
19+
lastOpenedImage: false,
2020
fields: {
2121
previewUrl: 'preview_url',
2222
title: 'title'
@@ -167,7 +167,7 @@ define([
167167
* Close image preview
168168
*/
169169
hide: function () {
170-
this.lastOpenedImage(null);
170+
this.lastOpenedImage(false);
171171
this.visibleRecord(null);
172172
this.height(0);
173173
this._selectRow(null);

dev/tests/js/jasmine/tests/app/code/Magento/Ui/base/js/grid/columns/image-preview.test.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,14 +51,18 @@ define([
5151
imagePreview.visibleRecord = ko.observable(1);
5252
});
5353

54-
describe('show method', function () {
54+
describe('verify show && hide record', function () {
55+
5556
it('show image', function () {
56-
var mockImg = document.createElement('img'),
57-
hide = spyOn(imagePreview, 'hide');
57+
var mockImg = document.createElement('img');
5858

59+
imagePreview.visibleRecord(2);
5960
spyOn($.fn, 'get').and.returnValue(mockImg);
6061
imagePreview.show(record);
61-
expect(hide).toHaveBeenCalledTimes(1);
62+
expect(imagePreview.lastOpenedImage()).toBe(record._rowIndex);
63+
64+
imagePreview.hide();
65+
expect(imagePreview.lastOpenedImage()).toBe(false);
6266
});
6367

6468
});

0 commit comments

Comments
 (0)