229: [GraphQL caching] Add support for queries via HTTP GET

- This reverts commit d193913.

Author: danielrenaud

dev/tests/api-functional/framework/Magento/TestFramework/TestCase/GraphQl/Client.php

@@ -66,14 +66,12 @@ public function postQuery(string $query, array $variables = [], string $operatio
         $responseBodyArray = $this->json->jsonDecode($responseBody);
 
         if (!is_array($responseBodyArray)) {
-            //phpcs:ignore Magento2.Exceptions.DirectThrow
             throw new \Exception('Unknown GraphQL response body: ' . json_encode($responseBodyArray));
         }
 
         $this->processErrors($responseBodyArray);
 
         if (!isset($responseBodyArray['data'])) {
-            //phpcs:ignore Magento2.Exceptions.DirectThrow
             throw new \Exception('Unknown GraphQL response body: ' . json_encode($responseBodyArray));
         } else {
             return $responseBodyArray['data'];
@@ -103,14 +101,12 @@ public function getQuery(string $query, array $variables = [], string $operation
         $responseBodyArray = $this->json->jsonDecode($responseBody);
 
         if (!is_array($responseBodyArray)) {
-            //phpcs:ignore Magento2.Exceptions.DirectThrow
             throw new \Exception('Unknown GraphQL response body: ' . json_encode($responseBodyArray));
         }
 
         $this->processErrors($responseBodyArray);
 
         if (!isset($responseBodyArray['data'])) {
-            //phpcs:ignore Magento2.Exceptions.DirectThrow
             throw new \Exception('Unknown GraphQL response body: ' . json_encode($responseBodyArray));
         } else {
             return $responseBodyArray['data'];
@@ -146,7 +142,6 @@ private function processErrors($responseBodyArray)
                     $responseBodyArray
                 );
             }
-            //phpcs:ignore Magento2.Exceptions.DirectThrow
             throw new \Exception('GraphQL responded with an unknown error: ' . json_encode($responseBodyArray));
         }
     }

dev/tests/api-functional/framework/Magento/TestFramework/TestCase/GraphQlAbstract.php

@@ -61,7 +61,6 @@ public function graphQlQuery(
                 $this->composeHeaders($headers)
             );
         } else {
-            //phpcs:ignore Magento2.Exceptions.DirectThrow
             throw new \Exception("Unsupported request type");
         }
 

dev/tests/integration/testsuite/Magento/Framework/GraphQl/Config/GraphQlReaderTest.php

@@ -45,9 +45,7 @@ protected function setUp()
             \Magento\Framework\Config\FileResolverInterface::class
         )->disableOriginalConstructor()->getMock();
         $fileList = [
-            //phpcs:ignore Magento2.Functions.DiscouragedFunction
             file_get_contents(__DIR__ . '/../_files/schemaA.graphqls'),
-            //phpcs:ignore Magento2.Functions.DiscouragedFunction
             file_get_contents(__DIR__ . '/../_files/schemaB.graphqls')
         ];
         $fileResolverMock->expects($this->any())->method('get')->will($this->returnValue($fileList));
@@ -187,7 +185,6 @@ enumValues(includeDeprecated: true) {
         $request->setHeaders($headers);
         $response = $this->graphQlController->dispatch($request);
         $output = $this->jsonSerializer->unserialize($response->getContent());
-        //phpcs:ignore Magento2.Security.IncludeFile
         $expectedOutput = require __DIR__ . '/../_files/schema_response_sdl_description.php';
 
         $schemaResponseFields = $output['data']['__schema']['types'];

dev/tests/integration/testsuite/Magento/GraphQl/Controller/GraphQlControllerTest.php

@@ -38,7 +38,6 @@ class GraphQlControllerTest extends \Magento\TestFramework\Indexer\TestCase
     /** @var MetadataPool */
     private $metadataPool;
 
-    //phpcs:ignore Magento2.Functions.StaticFunction
     public static function setUpBeforeClass()
     {
         $db = Bootstrap::getInstance()->getBootstrap()
@@ -266,4 +265,12 @@ public function testError() : void
             }
         }
     }
+
+    /**
+     * teardown
+     */
+    public function tearDown()
+    {
+        parent::tearDown();
+    }
 }