AC-13855: Penny rounding error in catalog rule

sumesh-GL · sumesh-GL · commit c6157e600357 · 2025-01-31T16:20:38.000+05:30
Update rounding method
diff --git a/app/code/Magento/Directory/Model/PriceCurrency.php b/app/code/Magento/Directory/Model/PriceCurrency.php
@@ -15,8 +15,6 @@
  */
 class PriceCurrency implements \Magento\Framework\Pricing\PriceCurrencyInterface
 {
-    private const PRECISION_TO_FIX_PENNY_ROUNDING_ERROR = 3;
-
     /**
      * @var \Magento\Store\Model\StoreManagerInterface
      */
@@ -154,7 +152,8 @@ protected function getStore($scope = null)
      */
     public function round($price)
     {
-        return round((float) $price, self::PRECISION_TO_FIX_PENNY_ROUNDING_ERROR);
+        // To fix rounding error in PHP 8.4
+        return round(round((float) $price, 3), 2);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -15,8 +15,6 @@`
`15`	`15`	`*/`
`16`	`16`	`class PriceCurrency implements \Magento\Framework\Pricing\PriceCurrencyInterface`
`17`	`17`	`{`
`18`		`- private const PRECISION_TO_FIX_PENNY_ROUNDING_ERROR = 3;`
`19`		`-`
`20`	`18`	`/**`
`21`	`19`	`* @var \Magento\Store\Model\StoreManagerInterface`
`22`	`20`	`*/`
`@@ -154,7 +152,8 @@ protected function getStore($scope = null)`
`154`	`152`	`*/`
`155`	`153`	`public function round($price)`
`156`	`154`	`{`
`157`		`- return round((float) $price, self::PRECISION_TO_FIX_PENNY_ROUNDING_ERROR);`
	`155`	`+ // To fix rounding error in PHP 8.4`
	`156`	`+ return round(round((float) $price, 3), 2);`
`158`	`157`	`}`
`159`	`158`
`160`	`159`	`/**`