MAGETWO-80789: [Indexer] Search Indexer is scoped & multi-threaded

Author: slopukhov

app/code/Magento/Indexer/Model/ProcessManager.php

@@ -87,12 +87,13 @@ private function multiThreadsExecute($userFunctions)
                 $this->startChildProcess($userFunction);
             }
         }
-        while(pcntl_waitpid(0, $status) != -1);
+        while (pcntl_waitpid(0, $status) != -1) {
+            //Waiting for the completion of child processes
+        }
 
         if ($this->failInChildProcess) {
             throw new \RuntimeException('Fail in child process');
         }
-
     }
 
     /**

lib/internal/Magento/Framework/App/ResourceConnection.php

@@ -104,9 +104,9 @@ public function getConnection($resourceName = self::DEFAULT_CONNECTION)
     public function closeConnection($resourceName = self::DEFAULT_CONNECTION)
     {
         if ($resourceName === null) {
-            foreach ($this->connections as $processConnectionName => $value) {
-                if ($this->connections[$processConnectionName] instanceof AdapterInterface) {
-                    $this->connections[$processConnectionName]->closeConnection();
+            foreach ($this->connections as $processConnection) {
+                if ($processConnection instanceof AdapterInterface) {
+                    $processConnection->closeConnection();
                 }
             }
             $this->connections = [];