Skip to content

Commit c5b78d3

Browse files
author
Dmytro Vilchynskyi
committed
MAGETWO-33407: Cover MAGETWO-31855 changes by static tests
- changed description for static test
1 parent de95127 commit c5b78d3

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

dev/tests/static/testsuite/Magento/Test/Legacy/PhtmlTemplateTest.php

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -41,22 +41,16 @@ public function testObsoleteJavascriptAttributeType()
4141
$invoker = new \Magento\Framework\Test\Utility\AggregateInvoker($this);
4242
$invoker(
4343
/**
44-
* Test usage of protected and private methods and variables in template
45-
*
46-
* According to naming convention (B5.8, B6.2) all class members
47-
* in protected or private scope should be prefixed with underscore.
48-
* Member variables declared "public" should never start with an underscore.
49-
* Access to protected and private members of Block class is obsolete in phtml templates
50-
* since introduction of multiple template engines support
44+
* "text/javascript" type attribute in not obligatory to use in templates due to HTML5 standards.
45+
* For more details please go to "http://www.w3.org/TR/html5/scripting-1.html".
5146
*
5247
* @param string $file
5348
*/
5449
function ($file) {
5550
$this->assertNotRegexp(
5651
'/type="text\/javascript"/',
5752
file_get_contents($file),
58-
'Please do not use "text/javascript" type attribute due to HTML5 standards.' .
59-
' For more details please go to "http://www.w3.org/TR/html5/scripting-1.html".'
53+
'Please do not use "text/javascript" type attribute.'
6054
);
6155
},
6256
\Magento\Framework\Test\Utility\Files::init()->getPhtmlFiles()

0 commit comments

Comments
 (0)