ENGCOM-2194: Fix docBlock for hasInvoices(), hasShipments(), hasCreditmemos() #16554

magento-engcom-team · magento-engcom-team · commit c5a4a6005cd0 · 2018-07-06T07:54:18.000-05:00
- Merge Pull Request #16554 from comwrap/magento2:docBlock-order - Merged commits: 1. 3a4a238 2. fa6e2f1
diff --git a/app/code/Magento/Sales/Model/Order.php b/app/code/Magento/Sales/Model/Order.php
@@ -1787,7 +1787,7 @@ public function getTracksCollection()
      */
     public function hasInvoices()
     {
-        return $this->getInvoiceCollection()->count();
+        return boolval($this->getInvoiceCollection()->count());
     }
 
     /**
@@ -1797,7 +1797,7 @@ public function hasInvoices()
      */
     public function hasShipments()
     {
-        return $this->getShipmentsCollection()->count();
+        return boolval($this->getShipmentsCollection()->count());
     }
 
     /**
@@ -1807,7 +1807,7 @@ public function hasShipments()
      */
     public function hasCreditmemos()
     {
-        return $this->getCreditmemosCollection()->count();
+        return boolval($this->getCreditmemosCollection()->count());
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -1787,7 +1787,7 @@ public function getTracksCollection()`
`1787`	`1787`	`*/`
`1788`	`1788`	`public function hasInvoices()`
`1789`	`1789`	`{`
`1790`		`- return $this->getInvoiceCollection()->count();`
	`1790`	`+ return boolval($this->getInvoiceCollection()->count());`
`1791`	`1791`	`}`
`1792`	`1792`
`1793`	`1793`	`/**`
`@@ -1797,7 +1797,7 @@ public function hasInvoices()`
`1797`	`1797`	`*/`
`1798`	`1798`	`public function hasShipments()`
`1799`	`1799`	`{`
`1800`		`- return $this->getShipmentsCollection()->count();`
	`1800`	`+ return boolval($this->getShipmentsCollection()->count());`
`1801`	`1801`	`}`
`1802`	`1802`
`1803`	`1803`	`/**`
`@@ -1807,7 +1807,7 @@ public function hasShipments()`
`1807`	`1807`	`*/`
`1808`	`1808`	`public function hasCreditmemos()`
`1809`	`1809`	`{`
`1810`		`- return $this->getCreditmemosCollection()->count();`
	`1810`	`+ return boolval($this->getCreditmemosCollection()->count());`
`1811`	`1811`	`}`
`1812`	`1812`
`1813`	`1813`	`/**`