Replace isset with in_array for better performance

basvanpoppel · ihor-sviziev · web-flow · commit c56b4e3cad0e · 2021-06-28T14:16:25.000+02:00
Co-authored-by: Ihor Sviziev &lt;ihor-sviziev@users.noreply.github.com&gt;
diff --git a/lib/internal/Magento/Framework/View/Helper/SecureHtmlRender/HtmlRenderer.php b/lib/internal/Magento/Framework/View/Helper/SecureHtmlRender/HtmlRenderer.php
@@ -74,7 +74,7 @@ public function renderTag(TagData $tagData): string
         }
 
         $html = '<' .$tagData->getTag() .$attributesHtml;
-        if (in_array($tagData->getTag(), self::VOID_ELEMENTS)) {
+        if (isset(self::VOID_ELEMENTS_MAP[$tagData->getTag()])) {
             $html .= '/>';
         } else {
             $html .= '>' .$content .'</' .$tagData->getTag() .'>';

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ public function renderTag(TagData $tagData): string`
`74`	`74`	`}`
`75`	`75`
`76`	`76`	`$html = '<' .$tagData->getTag() .$attributesHtml;`
`77`		`- if (in_array($tagData->getTag(), self::VOID_ELEMENTS)) {`
	`77`	`+ if (isset(self::VOID_ELEMENTS_MAP[$tagData->getTag()])) {`
`78`	`78`	`$html .= '/>';`
`79`	`79`	`} else {`
`80`	`80`	`$html .= '>' .$content .'</' .$tagData->getTag() .'>';`