Skip to content

Commit c5664bf

Browse files
committed
Merge remote-tracking branch 'chaika/MC-35804' into PR-10-14
2 parents c899394 + 99209da commit c5664bf

File tree

7 files changed

+34
-13
lines changed

7 files changed

+34
-13
lines changed
Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
<?xml version="1.0" encoding="UTF-8"?>
2+
<!--
3+
/**
4+
* Copyright © Magento, Inc. All rights reserved.
5+
* See COPYING.txt for license details.
6+
*/
7+
-->
8+
9+
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
10+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
11+
<actionGroup name="AdminReloadDashboardDataActionGroup">
12+
<annotations>
13+
<description>Go to Admin Dashboard Page, and reload Dashboard data.</description>
14+
</annotations>
15+
16+
<amOnPage url="{{AdminDashboardPage.url}}" stepKey="amOnDashboardPage"/>
17+
<click selector="{{AdminDashboardSection.dashboardButtonReloadData}}" stepKey="reloadDashboardData"/>
18+
<waitForPageLoad stepKey="waitForPageToReload"/>
19+
</actionGroup>
20+
</actionGroups>

app/code/Magento/Backend/Test/Mftf/Section/AdminDashboardSection.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,7 @@
1717
<element name="dashboardDiagramAmountsContentTab" type="block" selector="#diagram_tab_amounts_content"/>
1818
<element name="dashboardDiagramTotals" type="text" selector="#diagram_tab_amounts_content"/>
1919
<element name="dashboardTotals" type="text" selector="//*[@class='dashboard-totals-label' and contains(text(), '{{columnName}}')]/../*[@class='dashboard-totals-value']" parameterized="true"/>
20+
<element name="productInBestsellers" type="text" selector="#productsOrderedGrid_table td.col-product.col-name"/>
21+
<element name="dashboardButtonReloadData" type="button" selector=".action-primary[title='Reload Data'][type='submit']"/>
2022
</section>
2123
</sections>

app/code/Magento/Backend/Test/Mftf/Test/AdminLoginWithRestrictPermissionTest.xml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,8 @@
4242
<actionGroup ref="AdminLogoutActionGroup" stepKey="logoutAsSaleRoleUser"/>
4343
<actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/>
4444
<!--Delete created data-->
45-
<actionGroup ref="AdminUserOpenAdminRolesPageActionGroup" stepKey="navigateToUserRoleGrid"/>
46-
<actionGroup ref="AdminDeleteRoleActionGroup" stepKey="deleteUserRole">
47-
<argument name="role" value="adminRole"/>
45+
<actionGroup ref="AdminDeleteUserRoleActionGroup" stepKey="deleteUserRole">
46+
<argument name="roleName" value="{{adminRole.rolename}}"/>
4847
</actionGroup>
4948
<actionGroup ref="AdminOpenAdminUsersPageActionGroup" stepKey="goToAllUsersPage"/>
5049
<actionGroup ref="AdminDeleteNewUserActionGroup" stepKey="deleteUser">

app/code/Magento/Catalog/Test/Mftf/Test/AdminRestrictedUserAddCategoryFromProductPageTest.xml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,8 @@
3636
<actionGroup ref="AdminLoginActionGroup" stepKey="loginAsAdmin"/>
3737
<!--Delete created data-->
3838
<comment userInput="Delete created data" stepKey="commentDeleteCreatedData"/>
39-
<amOnPage url="{{AdminRolesPage.url}}" stepKey="navigateToUserRoleGrid" />
40-
<waitForPageLoad stepKey="waitForRolesGridLoad" />
41-
<actionGroup ref="AdminDeleteRoleActionGroup" stepKey="deleteUserRole">
42-
<argument name="role" value="adminRole"/>
39+
<actionGroup ref="AdminDeleteUserRoleActionGroup" stepKey="deleteUserRole">
40+
<argument name="roleName" value="{{adminRole.rolename}}"/>
4341
</actionGroup>
4442
<amOnPage url="{{AdminUsersPage.url}}" stepKey="goToAllUsersPage"/>
4543
<waitForPageLoad stepKey="waitForUsersGridLoad" />

app/code/Magento/Checkout/Test/Mftf/ActionGroup/StorefrontEnterProductQuantityAndAddToTheCartActionGroup.xml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,11 @@
1515
<arguments>
1616
<argument name="quantity" type="string"/>
1717
</arguments>
18-
18+
1919
<clearField selector="{{StorefrontBundleProductActionSection.quantityField}}" stepKey="clearTheQuantityField"/>
2020
<fillField selector="{{StorefrontBundleProductActionSection.quantityField}}" userInput="{{quantity}}" stepKey="fillTheProductQuantity"/>
2121
<click selector="{{StorefrontBundleProductActionSection.addToCartButton}}" stepKey="clickOnAddToButton"/>
22-
<waitForPageLoad stepKey="waitForPageLoad2"/>
22+
<waitForPageLoad stepKey="waitForPageLoad"/>
23+
<waitForElementVisible selector="{{StorefrontMessagesSection.success}}" stepKey="waitForSuccessMessage"/>
2324
</actionGroup>
2425
</actionGroups>

app/code/Magento/Customer/Test/Mftf/ActionGroup/FillCustomerSignInPopupFormActionGroup.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<arguments>
1616
<argument name="customer" type="entity"/>
1717
</arguments>
18-
18+
1919
<waitForElementVisible selector="{{StorefrontCustomerSignInPopupFormSection.email}}" stepKey="waitEmailFieldVisible"/>
2020
<fillField selector="{{StorefrontCustomerSignInPopupFormSection.email}}" userInput="{{customer.email}}" stepKey="fillCustomerEmail"/>
2121
<fillField selector="{{StorefrontCustomerSignInPopupFormSection.password}}" userInput="{{customer.password}}" stepKey="fillCustomerPassword"/>

app/code/Magento/User/Test/Mftf/ActionGroup/AdminDeleteRoleActionGroup.xml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,13 @@
1010
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
1111
<actionGroup name="AdminDeleteRoleActionGroup">
1212
<annotations>
13-
<description>Deletes a User Role.</description>
13+
<description>DEPRECATED. Deletes a User Role. ActionGroup duplicates existing 'AdminDeleteUserRoleActionGroup'</description>
1414
</annotations>
1515
<arguments>
1616
<argument name="role" defaultValue=""/>
1717
</arguments>
18-
18+
<amOnPage url="{{AdminRolesPage.url}}" stepKey="navigateToUserRoleGrid" />
19+
<waitForPageLoad stepKey="waitForRolesGridLoad" />
1920
<click stepKey="clickResetFilterButtonBefore" selector="{{AdminRoleGridSection.resetButton}}"/>
2021
<waitForPageLoad stepKey="waitForRolesGridFilterResetBefore" time="10"/>
2122
<fillField stepKey="TypeRoleFilter" selector="{{AdminRoleGridSection.roleNameFilterTextField}}" userInput="{{role.name}}"/>
@@ -33,7 +34,7 @@
3334
<click stepKey="clickToConfirm" selector="{{AdminDeleteRoleSection.confirm}}"/>
3435
<waitForPageLoad stepKey="waitForPageLoad" time="10"/>
3536
<see stepKey="seeSuccessMessage" userInput="You deleted the role."/>
36-
<waitForPageLoad stepKey="waitForRolesGridLoad" />
37+
<waitForPageLoad stepKey="waitForRolesGridLoadAfterDelete" />
3738
<waitForElementVisible stepKey="waitForResetFilterButtonAfter" selector="{{AdminRoleGridSection.resetButton}}" time="10"/>
3839
<click stepKey="clickResetFilterButtonAfter" selector="{{AdminRoleGridSection.resetButton}}"/>
3940
<waitForPageLoad stepKey="waitForRolesGridFilterResetAfter" time="10"/>

0 commit comments

Comments
 (0)