ACP2E-651: Orders Api zero row total issue for order items with discounts

Anna Bukatar · Anna Bukatar · commit c5609814cb90 · 2022-04-26T13:17:05.000-07:00
diff --git a/app/code/Magento/Sales/Model/Order/Webapi/ChangeOutputArray.php b/app/code/Magento/Sales/Model/Order/Webapi/ChangeOutputArray.php
@@ -10,6 +10,7 @@
 use Magento\Sales\Api\Data\OrderItemInterface;
 use Magento\Sales\Block\Adminhtml\Items\Column\DefaultColumn;
 use Magento\Sales\Block\Order\Item\Renderer\DefaultRenderer;
+use Magento\Tests\NamingConvention\true\float;
 
 /**
  * Class for changing row total in response.
@@ -69,10 +70,10 @@ public function execute(
      * Remove negative values from row totals
      *
      * @param float $value
-     * @return mixed
+     * @return float
      */
-    private function round(float $value)
+    private function round(float $value): float
     {
-        return max($value, 0);
+        return (float) max($value, 0);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,7 @@`
`10`	`10`	`use Magento\Sales\Api\Data\OrderItemInterface;`
`11`	`11`	`use Magento\Sales\Block\Adminhtml\Items\Column\DefaultColumn;`
`12`	`12`	`use Magento\Sales\Block\Order\Item\Renderer\DefaultRenderer;`
	`13`	`+use Magento\Tests\NamingConvention\true\float;`
`13`	`14`
`14`	`15`	`/**`
`15`	`16`	`* Class for changing row total in response.`
`@@ -69,10 +70,10 @@ public function execute(`
`69`	`70`	`* Remove negative values from row totals`
`70`	`71`	`*`
`71`	`72`	`* @param float $value`
`72`		`- * @return mixed`
	`73`	`+ * @return float`
`73`	`74`	`*/`
`74`		`- private function round(float $value)`
	`75`	`+ private function round(float $value): float`
`75`	`76`	`{`
`76`		`- return max($value, 0);`
	`77`	`+ return (float) max($value, 0);`
`77`	`78`	`}`
`78`	`79`	`}`