Merge remote-tracking branch 'origin/MC-6425' into 2.3-develop-mftf-pr20

Author: zakdma

dev/tests/api-functional/testsuite/Magento/Sales/Service/V1/OrderCancelTest.php

@@ -6,21 +6,51 @@
 
 namespace Magento\Sales\Service\V1;
 
+use Magento\Framework\ObjectManagerInterface;
+use Magento\Sales\Model\Order;
+use Magento\TestFramework\Helper\Bootstrap;
 use Magento\TestFramework\TestCase\WebapiAbstract;
 
+/**
+ * Canceling of the order
+ */
 class OrderCancelTest extends WebapiAbstract
 {
     const SERVICE_VERSION = 'V1';
-
     const SERVICE_NAME = 'salesOrderManagementV1';
 
     /**
-     * @magentoApiDataFixture Magento/Sales/_files/order.php
+     * @var ObjectManagerInterface
      */
-    public function testOrderCancel()
+    private $objectManager;
+
+    /**
+     * @inheritdoc
+     */
+    protected function setUp()
+    {
+        $this->objectManager = Bootstrap::getObjectManager();
+    }
+
+    /**
+     * Gets order by increment ID.
+     *
+     * @param string $incrementId
+     * @return Order
+     */
+    private function getOrder(string $incrementId): Order
+    {
+        return $this->objectManager->create(Order::class)->loadByIncrementId($incrementId);
+    }
+
+    /**
+     * Send API request for canceling the order
+     *
+     * @param Order $order
+     * @return array|bool|float|int|string
+     */
+    private function sendCancelRequest(Order $order)
     {
-        $objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
-        $order = $objectManager->get(\Magento\Sales\Model\Order::class)->loadByIncrementId('100000001');
         $serviceInfo = [
             'rest' => [
                 'resourcePath' => '/V1/orders/' . $order->getId() . '/cancel',
@@ -33,7 +63,26 @@ public function testOrderCancel()
             ],
         ];
         $requestData = ['id' => $order->getId()];
-        $result = $this->_webApiCall($serviceInfo, $requestData);
+        return $this->_webApiCall($serviceInfo, $requestData);
+    }
+
+    /**
+     * @magentoApiDataFixture Magento/Sales/_files/order.php
+     */
+    public function testOrderCancel()
+    {
+        $order = $this->getOrder('100000001');
+        $result = $this->sendCancelRequest($order);
         $this->assertTrue($result);
     }
+
+    /**
+     * @magentoApiDataFixture Magento/Sales/_files/order_state_hold.php
+     */
+    public function testOrderWithStateHoldedShouldNotBeCanceled()
+    {
+        $order = $this->getOrder('100000001');
+        $result = $this->sendCancelRequest($order);
+        $this->assertFalse($result);
+    }
 }

dev/tests/integration/testsuite/Magento/Sales/_files/order_state_hold.php

@@ -0,0 +1,15 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+use Magento\Sales\Model\Order;
+
+require __DIR__ . '/order.php';
+
+/** @var Order $order */
+$order->setState(Order::STATE_HOLDED);
+$order->setStatus(Order::STATE_HOLDED);
+$order->save();