ENGCOM-6035: Static Content Deploy - Get rid of in_array(array_keys($array)) #24904

Author: VladimirZaets

lib/internal/Magento/Framework/View/Asset/PreProcessor/AlternativeSource.php

@@ -6,9 +6,9 @@
 namespace Magento\Framework\View\Asset\PreProcessor;
 
 use Magento\Framework\ObjectManagerInterface;
+use Magento\Framework\View\Asset\ContentProcessorInterface;
 use Magento\Framework\View\Asset\File\FallbackContext;
 use Magento\Framework\View\Asset\LockerProcessInterface;
-use Magento\Framework\View\Asset\ContentProcessorInterface;
 use Magento\Framework\View\Asset\PreProcessor\AlternativeSource\AssetBuilder;
 
 /**
@@ -139,11 +139,13 @@ private function processContent($path, $content, $module, FallbackContext $conte
                 ->setTheme($context->getThemePath())
                 ->setLocale($context->getLocale())
                 ->setModule($module)
-                ->setPath(preg_replace(
-                    '#\.' . preg_quote(pathinfo($path, PATHINFO_EXTENSION)) . '$#',
-                    '.' . $name,
-                    $path
-                ))->build();
+                ->setPath(
+                    preg_replace(
+                        '#\.' . preg_quote(pathinfo($path, PATHINFO_EXTENSION)) . '$#',
+                        '.' . $name,
+                        $path
+                    )
+                )->build();
 
             $processor = $this->objectManager->get($alternative[self::PROCESSOR_CLASS]);
             if (!$processor  instanceof ContentProcessorInterface) {
@@ -168,4 +170,15 @@ public function getAlternativesExtensionsNames()
     {
         return array_keys($this->alternatives);
     }
+
+    /**
+     * Check if file extension supported
+     *
+     * @param string $ext
+     * @return bool
+     */
+    public function isExtensionSupported($ext)
+    {
+        return isset($this->alternatives[$ext]);
+    }
 }

lib/internal/Magento/Framework/View/Asset/PreProcessor/FileNameResolver.php

@@ -5,6 +5,11 @@
  */
 namespace Magento\Framework\View\Asset\PreProcessor;
 
+/**
+ * Class FileNameResolver
+ *
+ * @package Magento\Framework\View\Asset\PreProcessor
+ */
 class FileNameResolver
 {
     /**
@@ -38,7 +43,7 @@ public function resolve($fileName)
         $compiledFile = $fileName;
         $extension = pathinfo($fileName, PATHINFO_EXTENSION);
         foreach ($this->alternativeSources as $name => $alternative) {
-            if (in_array($extension, $alternative->getAlternativesExtensionsNames(), true)
+            if ($alternative->isExtensionSupported($extension)
                 && strpos(basename($fileName), '_') !== 0
             ) {
                 $compiledFile = substr($fileName, 0, strlen($fileName) - strlen($extension) - 1);