Merge pull request #6296 from magento-tsg/MC-38680

[Arrows] MC-38680: [2.3] Submitting invalid create account form leaves the submit button disabled

Author: zakdma

app/code/Magento/Customer/Test/Mftf/ActionGroup/AssertMessageCustomerCreateAccountPasswordComplexityActionGroup.xml

@@ -0,0 +1,20 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ /**
+  * Copyright © Magento, Inc. All rights reserved.
+  * See COPYING.txt for license details.
+  */
+-->
+
+<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+              xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
+    <actionGroup name="AssertMessageCustomerCreateAccountPasswordComplexityActionGroup">
+        <annotations>
+            <description>Assert is shown an error about their password during new user form filling.</description>
+        </annotations>
+        <arguments>
+            <argument name="message" type="string"/>
+        </arguments>
+        <see userInput="{{message}}" selector="{{StorefrontCustomerCreateFormSection.passwordErrorMessages}}" stepKey="verifyMessage"/>
+    </actionGroup>
+</actionGroups>

app/code/Magento/Customer/Test/Mftf/Data/CustomerData.xml

@@ -47,6 +47,16 @@
         <data key="group">General</data>
         <requiredEntity type="address">US_Address_TX</requiredEntity>
     </entity>
+    <entity name="Simple_Customer_With_Password_Length_Is_Below_Eight_Characters" type="customer">
+        <data key="group_id">1</data>
+        <data key="email" unique="prefix">John.Doe@example.com</data>
+        <data key="firstname">John</data>
+        <data key="lastname">Doe</data>
+        <data key="fullname">John Doe</data>
+        <data key="password">123123</data>
+        <data key="store_id">0</data>
+        <data key="website_id">0</data>
+    </entity>
     <entity name="Simple_US_Customer_Without_Default_Address" type="customer">
         <data key="group_id">1</data>
         <data key="default_billing">true</data>

app/code/Magento/Customer/Test/Mftf/Section/StorefrontCustomerCreateFormSection.xml

@@ -18,6 +18,7 @@
         <element name="passwordField" type="input" selector="#password"/>
         <element name="confirmPasswordField" type="input" selector="#password-confirmation"/>
         <element name="createAccountButton" type="button" selector="button.action.submit.primary" timeout="30"/>
+        <element name="passwordErrorMessages" type="text" selector="#password-error"/>
     </section>
     <section name="StoreFrontCustomerAdvancedAttributesSection">
         <element name="textFieldAttribute" type="input" selector="//input[@id='{{var}}']" parameterized="true" />

app/code/Magento/Customer/Test/Mftf/Test/StorefrontCreateCustomerWithInvalidDataTest.xml

@@ -0,0 +1,39 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ /**
+  * Copyright © Magento, Inc. All rights reserved.
+  * See COPYING.txt for license details.
+  */
+-->
+
+<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+        xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
+    <test name="StorefrontCreateCustomerWithInvalidDataTest">
+        <annotations>
+            <stories value="Create a Customer via the Storefront"/>
+            <features value="Customer"/>
+            <title value="Register customer on storefront after customer form validation failed."/>
+            <description value="Customer should be able to re-submit register form after correcting invalid form data on storefront."/>
+            <severity value="CRITICAL"/>
+            <testCaseId value="MC-38681"/>
+            <useCaseId value="MC-38680"/>
+            <group value="customer"/>
+        </annotations>
+
+        <actionGroup ref="StorefrontOpenCustomerAccountCreatePageActionGroup" stepKey="openCreateAccountPage"/>
+        <!--Try to submit register form with wrong password.-->
+        <actionGroup ref="StorefrontFillCustomerAccountCreationFormActionGroup" stepKey="fillCreateAccountFormWithWrongData">
+            <argument name="customer" value="Simple_Customer_With_Password_Length_Is_Below_Eight_Characters"/>
+        </actionGroup>
+        <actionGroup ref="StorefrontClickCreateAnAccountCustomerAccountCreationFormActionGroup" stepKey="tryToSubmitFormWithWrongPassword"/>
+        <actionGroup ref="AssertMessageCustomerCreateAccountPasswordComplexityActionGroup" stepKey="seeTheErrorPasswordLength">
+            <argument name="message" value="Minimum length of this field must be equal or greater than 8 symbols. Leading and trailing spaces will be ignored."/>
+        </actionGroup>
+        <!--Re-submit customer register form with correct data.-->
+        <actionGroup ref="StorefrontFillCustomerAccountCreationFormActionGroup" stepKey="fillCreateAccountFormWithCorrectData">
+            <argument name="customer" value="Simple_US_Customer"/>
+        </actionGroup>
+        <actionGroup ref="StorefrontClickCreateAnAccountCustomerAccountCreationFormActionGroup" stepKey="submitCreateAccountForm"/>
+        <actionGroup ref="AssertMessageCustomerCreateAccountActionGroup" stepKey="seeSuccessMessage"/>
+    </test>
+</tests>

app/code/Magento/Customer/view/frontend/web/js/block-submit-on-send.js

@@ -14,9 +14,15 @@ define([
 
         dataForm.submit(function () {
             $(this).find(':submit').attr('disabled', 'disabled');
+
+            if (this.isValid === false) {
+                $(this).find(':submit').prop('disabled', false);
+            }
+            this.isValid = true;
         });
         dataForm.bind('invalid-form.validate', function () {
             $(this).find(':submit').prop('disabled', false);
+            this.isValid = false;
         });
     };
 });