MAGETWO-65374: [GitHub][PR] Fix OAuth request helper to support Authorization header value parsing with non-leading OAuth key #8158

 - Merge Pull Request #8158 from careys7/magento2:fix-oauth-header-value-processing

Author: vrann

lib/internal/Magento/Framework/Oauth/Helper/Request.php

@@ -144,10 +144,10 @@ protected function _isProtocolParameter($attrName)
      */
     protected function _processHeader($authHeaderValue, &$protocolParams)
     {
-        if ($authHeaderValue && 'oauth' === strtolower(substr($authHeaderValue, 0, 5))) {
-            $authHeaderValue = substr($authHeaderValue, 6);
-            // ignore 'OAuth ' at the beginning
-
+        $oauthValuePosition = stripos(($authHeaderValue ? $authHeaderValue : ''), 'oauth ');
+        if ($authHeaderValue && $oauthValuePosition !== false) {
+            // Ignore anything before and including 'OAuth ' (trailing values validated later)
+            $authHeaderValue = substr($authHeaderValue, $oauthValuePosition + 6);
             foreach (explode(',', $authHeaderValue) as $paramStr) {
                 $nameAndValue = explode('=', trim($paramStr), 2);
 

lib/internal/Magento/Framework/Oauth/Test/Unit/Helper/RequestTest.php

@@ -7,6 +7,7 @@
  */
 namespace Magento\Framework\Oauth\Test\Unit\Helper;
 
+use Magento\Framework\App\Request\Http;
 use Magento\Framework\Phrase;
 
 class RequestTest extends \PHPUnit_Framework_TestCase
@@ -120,4 +121,70 @@ public function hostsDataProvider()
             ]
         ];
     }
+
+    /**
+     * Test that the OAuth parameters are correctly extracted from the Authorization header.
+     *
+     * @param $authHeaderValue
+     * @param $expectedParams
+     * @dataProvider dataProviderForTestPrepareRequestOAuthHeader
+     */
+    public function testPrepareRequestOAuthHeader($authHeaderValue, $expectedParams)
+    {
+        $httpRequestMock = $this->getMockBuilder(Http::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $httpRequestMock->expects($this->once())->method('getScheme')->willReturn('https');
+        $httpRequestMock->expects($this->once())->method('getHttpHost')->willReturn('example.com');
+        $httpRequestMock->expects($this->once())->method('getRequestUri')->willReturn('/');
+
+        $httpRequestMock->expects($this->any())
+            ->method('getHeader')
+            ->willReturnCallback(function ($header) use ($authHeaderValue) {
+                switch ($header) {
+                    case 'Authorization':
+                        return $authHeaderValue;
+                    case \Zend_Http_Client::CONTENT_TYPE:
+                        return \Zend_Http_Client::ENC_URLENCODED;
+                    default:
+                        return null;
+                }
+            });
+
+        $this->assertEquals($expectedParams, $this->oauthRequestHelper->prepareRequest($httpRequestMock));
+    }
+
+    /**
+     * @return array
+     */
+    public function dataProviderForTestPrepareRequestOAuthHeader()
+    {
+        return [
+            [
+                null,
+                []
+            ],
+            [
+                '',
+                []
+            ],
+            [
+                'OAuth oauth_consumer_key="x",oauth_token="x", Basic d2luZHNvcm0yOldpTmRzb1JTbWlUSDAwMTQ=',
+                ['oauth_consumer_key' => 'x', 'oauth_token' => 'x']
+            ],
+            [
+                'Basic d2luZHNvcm0yOldpTmRzb1JTbWlUSDAwMTQ=, OAuth oauth_consumer_key="x",oauth_token="x"',
+                ['oauth_consumer_key' => 'x', 'oauth_token' => 'x']
+            ],
+            [
+                'Basic d2luZHNvcm0yOldpTmRzb1JTbWlUSDAwMTQ=, oauth oauth_consumer_key="x", oauth_token="x"',
+                ['oauth_consumer_key' => 'x', 'oauth_token' => 'x']
+            ],
+            [
+                'oauth oauth_consumer_key="x", oauth_token="x", Basic d2luZHNvcm0yOldpTmRzb1JTbWlUSDAwMTQ=',
+                ['oauth_consumer_key' => 'x', 'oauth_token' => 'x']
+            ]
+        ];
+    }
 }