MAGETWO-31904: There is no validation for 'Table prefix' on Step 2: Add a Database during instalation

- Fixed.

Author: Ivan Gavryshko

dev/tests/unit/testsuite/Magento/Setup/Controller/DatabaseCheckTest.php

@@ -53,4 +53,10 @@ public function testIndexActionWithError()
         $this->assertArrayHasKey('error', $variables);
         $this->assertFalse($variables['success']);
     }
+
+    public function testIndexActionCheckPrefix()
+    {
+        $this->installer->expects($this->once())->method('checkDatabaseTablePrefix');
+        $this->controller->indexAction();
+    }
 }

setup/src/Magento/Setup/Controller/DatabaseCheck.php

@@ -47,18 +47,13 @@ public function __construct(InstallerFactory $installerFactory, WebLogger $webLo
     public function indexAction()
     {
         $params = Json::decode($this->getRequest()->getContent(), Json::TYPE_ARRAY);
-        var_dump($params);
+
         try {
-            if (isset($params['tablePrefix'])
-                && $params['tablePrefix'] !==''
-                && !preg_match('/^([[:alnum:]]+)([[:alnum:]_]+)$/', $params['tablePrefix'])
-            ) {
-                die("dfdfd");
-                throw new \InvalidArgumentException('Table prefix is in wrong format.');
-            }
             $installer = $this->installerFactory->create($this->webLogger);
             $password = isset($params['password']) ? $params['password'] : '';
             $installer->checkDatabaseConnection($params['name'], $params['host'], $params['user'], $password);
+            $tablePrefix = isset($params['tablePrefix']) ? $params['tablePrefix'] : '';
+            $installer->checkDatabaseTablePrefix($tablePrefix);
             return new JsonModel(['success' => true]);
         } catch (\Exception $e) {
             return new JsonModel(['success' => false, 'error' => $e->getMessage()]);

setup/src/Magento/Setup/Model/Installer.php

@@ -757,6 +757,23 @@ public function checkDatabaseConnection($dbName, $dbHost, $dbUser, $dbPass = '')
         return true;
     }
 
+    /**
+     * Check if database table is valid
+     *
+     * @param string $prefix
+     * @return boolean
+     * @throws \InvalidArgumentException
+     */
+    public function checkDatabaseTablePrefix($prefix)
+    {
+        if ($prefix !=='' && !preg_match('/^([[:alnum:]]+)([[:alnum:]_]+)$/', $prefix)
+        ) {
+            throw new \InvalidArgumentException('Table prefix is in wrong format.');
+        }
+
+        return true;
+    }
+
     /**
      * Return messages
      *
@@ -876,6 +893,9 @@ private function assertDbAccessible()
             $config[DbConfig::KEY_USER],
             $config[DbConfig::KEY_PASS]
         );
+        if (isset($config[DbConfig::KEY_PREFIX])) {
+            $this->checkDatabaseTablePrefix($config[DbConfig::KEY_PREFIX]);
+        }
     }
 
     /**