Merge pull request #2230 from magento-pangolin/2.3-develop-PHP72

[Pangolin] Update MTF tests to support PHPUnit 6.5 and PHP 7.2

Author: okolesnyk

dev/tests/acceptance/composer.json

@@ -22,7 +22,7 @@
         "symfony/process": ">=2.7 <3.4",
         "henrikbjorn/lurker": "^1.2",
         "magento/magento2-functional-testing-framework": "~2.1.1",
-        "php": "7.0.2|7.0.4|~7.0.6|~7.1.0",
+        "php": "7.0.2|7.0.4|~7.0.6|~7.1.0|~7.2.0",
         "vlucas/phpdotenv": "~2.4"
     },
     "autoload": {

dev/tests/acceptance/composer.lock

@@ -51,7 +51,7 @@ function ($errNo, $errStr, $errFile, $errLine) {
 
                 $errName = isset($errorNames[$errNo]) ? $errorNames[$errNo] : "";
 
-                throw new \PHPUnit_Framework_Exception(
+                throw new \PHPUnit\Framework\Exception(
                     sprintf("%s: %s in %s:%s.", $errName, $errStr, $errFile, $errLine),
                     $errNo
                 );

dev/tests/functional/bootstrap.php

@@ -3,12 +3,12 @@
         "sort-packages": true
     },
     "require": {
-        "php": "7.0.2|~7.0.6|~7.1.0",
-        "magento/mtf": "1.0.0-rc59",
+        "php": "7.0.2|~7.0.6|~7.1.0|~7.2.0",
+        "magento/mtf": "1.0.0-rc60",
         "allure-framework/allure-phpunit": "~1.2.0",
         "doctrine/annotations": "1.4.*",
-        "phpunit/phpunit": "~4.8.0|~5.5.0",
-        "phpunit/phpunit-selenium": ">=1.2"
+        "phpunit/phpunit": "~6.5.0",
+        "phpunit/phpunit-selenium": "~4.1.0"
     },
     "suggest": {
         "netwing/selenium-server-standalone": "dev-master",

dev/tests/functional/composer.json

@@ -74,7 +74,7 @@ protected function configure()
      */
     protected function execute(InputInterface $input, OutputInterface $output)
     {
-        \PHPUnit_Util_Configuration::getInstance(MTF_PHPUNIT_FILE)->handlePHPConfiguration();
+        \PHPUnit\Util\Configuration::getInstance(MTF_PHPUNIT_FILE)->handlePHPConfiguration();
         $this->output = $this->objectManager->create(
             \Magento\Mtf\Console\Output::class,
             ['output' => $output]

dev/tests/functional/lib/Magento/Mtf/Troubleshooting/AdminAnalyzer.php

@@ -73,7 +73,7 @@ protected function configure()
      */
     protected function execute(InputInterface $input, OutputInterface $output)
     {
-        \PHPUnit_Util_Configuration::getInstance(MTF_PHPUNIT_FILE)->handlePHPConfiguration();
+        \PHPUnit\Util\Configuration::getInstance(MTF_PHPUNIT_FILE)->handlePHPConfiguration();
         $output = $this->objectManager->create(
             \Magento\Mtf\Console\Output::class,
             ['output' => $output]

dev/tests/functional/lib/Magento/Mtf/Troubleshooting/HtaccessAnalyzer.php

@@ -77,7 +77,7 @@ protected function configure()
      */
     protected function execute(InputInterface $input, OutputInterface $output)
     {
-        \PHPUnit_Util_Configuration::getInstance(MTF_PHPUNIT_FILE)->handlePHPConfiguration();
+        \PHPUnit\Util\Configuration::getInstance(MTF_PHPUNIT_FILE)->handlePHPConfiguration();
         $output = $this->objectManager->create(
             \Magento\Mtf\Console\Output::class,
             ['output' => $output]

dev/tests/functional/lib/Magento/Mtf/Troubleshooting/StorefrontAnalyzer.php

@@ -209,7 +209,7 @@ protected function _processItem(& $items, & $rewrites, $filename, $location, $pa
         if ($reflectionClass->isAbstract()) {
             return;
         }
-        $annotations = \PHPUnit_Util_Test::parseTestMethodAnnotations($className);
+        $annotations = \PHPUnit\Util\Test::parseTestMethodAnnotations($className);
 
         list(, $targetClassName) = explode($location . '/', $filename);
         $targetClassName = str_replace('.php', '', $targetClassName);

dev/tests/functional/lib/Magento/Mtf/Util/Generate/Factory/AbstractFactory.php

@@ -37,7 +37,7 @@ public function processAssert(
         $this->exportData = $export->getLatest();
         foreach ($products as $product) {
             $regexps = $this->prepareRegexpsForCheck($exportedFields, $product);
-            \PHPUnit_Framework_Assert::assertTrue(
+            \PHPUnit\Framework\Assert::assertTrue(
                 $this->isProductDataExists($regexps),
                 'A product with name ' . $product->getName() . ' was not found in exported file.'
             );

dev/tests/functional/tests/app/Magento/AdvancedPricingImportExport/Test/Constraint/AssertExportAdvancedPricing.php

@@ -59,7 +59,7 @@ public function processAssert(
 
         $resultArrays = $this->getPreparePrices();
 
-        \PHPUnit_Framework_Assert::assertEquals(
+        \PHPUnit\Framework\Assert::assertEquals(
             $resultArrays['pageData'],
             $resultArrays['csvData'],
             'Tier prices from page and csv are not match.'