MAGETWO-49618: [GitHub] Product Save & Duplicate Unexpected Behavior for Multiple Store Views #3426

- fix static

Author: duhon

app/code/Magento/Catalog/Plugin/Model/Attribute/Backend/AttributeValidation.php

@@ -14,6 +14,7 @@ class AttributeValidation
 
     /**
      * @param \Magento\Store\Model\StoreManagerInterface $storeManager
+     * @param array $allowedEntityTypes
      */
     public function __construct(
         \Magento\Store\Model\StoreManagerInterface $storeManager,
@@ -34,7 +35,7 @@ public function aroundValidate(
         \Closure $proceed,
         \Magento\Framework\DataObject $entity
     ) {
-        $isAllowedType = !empty(array_filter(array_map(function($allowedEntity) use ($entity) {
+        $isAllowedType = !empty(array_filter(array_map(function ($allowedEntity) use ($entity) {
             return $entity instanceof $allowedEntity;
         }, $this->allowedEntityTypes)));
 

app/code/Magento/Catalog/Test/Unit/Controller/Adminhtml/Product/ValidateTest.php

@@ -43,6 +43,10 @@ class ValidateTest extends \Magento\Catalog\Test\Unit\Controller\Adminhtml\Produ
     /** @var \Magento\Framework\Controller\Result\JsonFactory|\PHPUnit_Framework_MockObject_MockObject */
     protected $resultJsonFactory;
 
+    /**
+     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
+     * @return void
+     */
     protected function setUp()
     {
         $this->productBuilder = $this->getMock(

app/code/Magento/Eav/Model/ResourceModel/UpdateHandler.php

@@ -99,6 +99,7 @@ protected function getAttributes($entityType)
      * @throws \Magento\Framework\Exception\ConfigurationMismatchException
      * @SuppressWarnings(PHPMD.CyclomaticComplexity)
      * @SuppressWarnings(PHPMD.NPathComplexity)
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public function execute($entityType, $entityData, $arguments = [])
     {
@@ -121,7 +122,8 @@ public function execute($entityType, $entityData, $arguments = [])
                 /**
                  * Only scalar values can be stored in generic tables
                  */
-                if (isset($entityData[$attribute->getAttributeCode()]) && !is_scalar($entityData[$attribute->getAttributeCode()])) {
+                if (isset($entityData[$attribute->getAttributeCode()])
+                    && !is_scalar($entityData[$attribute->getAttributeCode()])) {
                     continue;
                 }
                 if (isset($snapshot[$attribute->getAttributeCode()])