ENGCOM-6625: Prevent endless loop when duplicating product #25875

 - Merge Pull Request #25875 from JeroenVanLeusden/magento2:JeroenVanLeusden-patch-4
 - Merged commits:
   1. 8e2959d
   2. a027e87
   3. 64cb774

Author: magento-engcom-team

app/code/Magento/Catalog/Model/Product/Copier.php

@@ -59,14 +59,14 @@ public function __construct(
         CopyConstructorInterface $copyConstructor,
         ProductFactory $productFactory,
         ScopeOverriddenValue $scopeOverriddenValue,
-        OptionRepository $optionRepository = null,
-        MetadataPool $metadataPool = null
+        OptionRepository $optionRepository,
+        MetadataPool $metadataPool
     ) {
         $this->productFactory = $productFactory;
         $this->copyConstructor = $copyConstructor;
         $this->scopeOverriddenValue = $scopeOverriddenValue;
-        $this->optionRepository = $optionRepository ?: ObjectManager::getInstance()->get(OptionRepository::class);
-        $this->metadataPool = $metadataPool ?: ObjectManager::getInstance()->get(MetadataPool::class);
+        $this->optionRepository = $optionRepository;
+        $this->metadataPool = $metadataPool;
     }
 
     /**

app/code/Magento/Catalog/Test/Unit/Model/Product/CopierTest.php

@@ -19,22 +19,22 @@ class CopierTest extends \PHPUnit\Framework\TestCase
     /**
      * @var \PHPUnit_Framework_MockObject_MockObject
      */
-    protected $optionRepositoryMock;
+    private $optionRepositoryMock;
 
     /**
      * @var Copier
      */
-    protected $_model;
+    private $_model;
 
     /**
      * @var \PHPUnit_Framework_MockObject_MockObject
      */
-    protected $copyConstructorMock;
+    private $copyConstructorMock;
 
     /**
      * @var \PHPUnit_Framework_MockObject_MockObject
      */
-    protected $productFactoryMock;
+    private $productFactoryMock;
 
     /**
      * @var \PHPUnit_Framework_MockObject_MockObject
@@ -44,12 +44,12 @@ class CopierTest extends \PHPUnit\Framework\TestCase
     /**
      * @var \PHPUnit_Framework_MockObject_MockObject
      */
-    protected $productMock;
+    private $productMock;
 
     /**
      * @var \PHPUnit_Framework_MockObject_MockObject
      */
-    protected $metadata;
+    private $metadata;
 
     protected function setUp()
     {
@@ -77,13 +77,10 @@ protected function setUp()
         $this->_model = new Copier(
             $this->copyConstructorMock,
             $this->productFactoryMock,
-            $this->scopeOverriddenValueMock
+            $this->scopeOverriddenValueMock,
+            $this->optionRepositoryMock,
+            $metadataPool
         );
-
-        $this->setProperties($this->_model, [
-            'optionRepository' => $this->optionRepositoryMock,
-            'metadataPool' => $metadataPool
-        ]);
     }
 
     /**
@@ -340,20 +337,4 @@ public function testUrlAlreadyExistsExceptionWhileCopyStoresUrl()
         $this->expectException(\Magento\UrlRewrite\Model\Exception\UrlAlreadyExistsException::class);
         $this->_model->copy($this->productMock);
     }
-
-    /**
-     * @param $object
-     * @param array $properties
-     */
-    private function setProperties($object, $properties = [])
-    {
-        $reflectionClass = new \ReflectionClass(get_class($object));
-        foreach ($properties as $key => $value) {
-            if ($reflectionClass->hasProperty($key)) {
-                $reflectionProperty = $reflectionClass->getProperty($key);
-                $reflectionProperty->setAccessible(true);
-                $reflectionProperty->setValue($object, $value);
-            }
-        }
-    }
 }