MAGETWO-70163: Add quote generaion ability for fixtures generation tool

glogen · glogen · commit c219919b8d07 · 2017-08-31T11:16:57.000+03:00
- Fix issues in quote generator
- Covered code with unit tests
- Static tests fixes
- Code style issues are fixed
- Fix integration tests fail
- Fix unit tests fails
diff --git a/setup/src/Magento/Setup/Fixtures/Quote/QuoteConfiguration.php b/setup/src/Magento/Setup/Fixtures/Quote/QuoteConfiguration.php
@@ -115,25 +115,24 @@ public function load()
             'fixture_data_filename',
             dirname(__DIR__) . DIRECTORY_SEPARATOR . "_files" . DIRECTORY_SEPARATOR . $this->fixtureDataFilename
         );
+        $this->accumulateData();
 
-        \Magento\Framework\DataObject\Mapper::accumulateByMap(
-            [$this->fixtureModel, 'getValue'],
-            [$this, 'setNotEmptyData'],
-            $this->_globalMap
-        );
         return $this;
     }
 
     /**
-     * @param string|array $key
-     * @param mixed $value
+     * Accumulate data from fixute model to object values.
+     *
      * @return $this
      */
-    public function setNotEmptyData($key, $value)
+    private function accumulateData()
     {
-        if (null === $value) {
-            return $this;
+        foreach ($this->_globalMap as $getKey => $setKey) {
+            $value = $this->fixtureModel->getValue($getKey);
+            if (null !== $value) {
+                $this->setData($setKey, $value);
+            }
         }
-        return $this->setData($key, $value);
+        return $this;
     }
 }
diff --git a/setup/src/Magento/Setup/Fixtures/Quote/QuoteGenerator.php b/setup/src/Magento/Setup/Fixtures/Quote/QuoteGenerator.php
@@ -113,7 +113,7 @@ public function __construct(
     }
 
     /**
-     * Prepare and save quotes in database
+     * Prepare and save quotes in database.
      *
      * @throws \Exception
      * @return void
@@ -135,13 +135,12 @@ public function generateQuotes()
             $maxItemsPerOrder
         );
         $this->productStubData = $this->prepareProductsForQuote();
-
         $this->prepareQueryTemplates();
 
         $entityId = $this->getMaxEntityId('quote', \Magento\Quote\Model\ResourceModel\Quote::class, 'entity_id');
         $quoteQty = $this->config->getExistsQuoteQuantity();
         $batchNumber = 0;
-        while ($quoteQty <= $this->config->getRequiredQuoteQuantity()) {
+        while ($quoteQty < $this->config->getRequiredQuoteQuantity()) {
             $entityId++;
             $batchNumber++;
             $quoteQty++;
@@ -171,7 +170,7 @@ public function generateQuotes()
     }
 
     /**
-     * Save quote and quote items
+     * Save quote and quote items.
      *
      * @param int $entityId
      * @param \Generator $itemIdSequence
@@ -215,30 +214,18 @@ private function saveQuoteWithQuoteItems($entityId, \Generator $itemIdSequence)
             $itemIdSequence->next();
         }
 
-        $type = Configurable::TYPE_CODE;
-        for ($i = 0; $i < $productCount[$type]; $i++) {
-            // Generate parent item
-            $parentItemId = $itemIdSequence->current();
-            $this->saveParentItemConfigurableData($entityId, $i, $parentItemId, Configurable::TYPE_CODE, $quote);
-            $itemIdSequence->next();
-
-            // Generate child item
-            $itemId = $itemIdSequence->current();
-            $this->saveChildItemConfigurable($entityId, $i, $itemId, $parentItemId, Configurable::TYPE_CODE, $quote);
-            $itemIdSequence->next();
-        }
-
-        $type = QuoteConfiguration::BIG_CONFIGURABLE_TYPE;
-        for ($i = 0; $i < $productCount[$type]; $i++) {
-            // Generate parent item
-            $parentItemId = $itemIdSequence->current();
-            $this->saveParentItemConfigurableData($entityId, $i, $parentItemId, $type, $quote);
-            $itemIdSequence->next();
-
-            // Generate child item
-            $itemId = $itemIdSequence->current();
-            $this->saveChildItemConfigurable($entityId, $i, $itemId, $parentItemId, $type, $quote);
-            $itemIdSequence->next();
+        foreach ([Configurable::TYPE_CODE, QuoteConfiguration::BIG_CONFIGURABLE_TYPE] as $type) {
+            for ($i = 0; $i < $productCount[$type]; $i++) {
+                // Generate parent item
+                $parentItemId = $itemIdSequence->current();
+                $this->saveParentItemConfigurableData($entityId, $i, $parentItemId, $type, $quote);
+                $itemIdSequence->next();
+
+                // Generate child item
+                $itemId = $itemIdSequence->current();
+                $this->saveChildItemConfigurable($entityId, $i, $itemId, $parentItemId, $type, $quote);
+                $itemIdSequence->next();
+            }
         }
     }
 
@@ -351,23 +338,23 @@ private function saveChildItemConfigurable($entityId, $index, $itemId, $parentIt
     /**
      * Get store id for quote item by product index.
      *
-     * @param int $index
+     * @param int $entityId
      * @return int
      */
-    private function getStubProductStoreId($index)
+    private function getStubProductStoreId($entityId)
     {
-        return $this->productStubData[$index % count($this->productStubData)][0];
+        return $this->productStubData[$this->getProductStubIndex($entityId)][0];
     }
 
     /**
      * Get store name for quote item by product index.
      *
-     * @param int $index
+     * @param int $entityId
      * @return string
      */
-    private function getStubProductStoreName($index)
+    private function getStubProductStoreName($entityId)
     {
-        return $this->productStubData[$index % count($this->productStubData)][1];
+        return $this->productStubData[$this->getProductStubIndex($entityId)][1];
     }
 
     /**
@@ -380,7 +367,7 @@ private function getStubProductStoreName($index)
      */
     private function getStubProductId($entityId, $index, $type)
     {
-        return $this->productStubData[$entityId % count($this->productStubData)][2][$type][$index]['id'];
+        return $this->productStubData[$this->getProductStubIndex($entityId)][2][$type][$index]['id'];
     }
 
     /**
@@ -393,7 +380,7 @@ private function getStubProductId($entityId, $index, $type)
      */
     private function getStubProductSku($entityId, $index, $type)
     {
-        return $this->productStubData[$entityId % count($this->productStubData)][2][$type][$index]['sku'];
+        return $this->productStubData[$this->getProductStubIndex($entityId)][2][$type][$index]['sku'];
     }
 
     /**
@@ -406,7 +393,7 @@ private function getStubProductSku($entityId, $index, $type)
      */
     private function getStubProductName($entityId, $index, $type)
     {
-        return $this->productStubData[$entityId % count($this->productStubData)][2][$type][$index]['name'];
+        return $this->productStubData[$this->getProductStubIndex($entityId)][2][$type][$index]['name'];
     }
 
     /**
@@ -419,7 +406,7 @@ private function getStubProductName($entityId, $index, $type)
      */
     private function getStubProductBuyRequest($entityId, $index, $type)
     {
-        return $this->productStubData[$entityId % count($this->productStubData)][2][$type][$index]['buyRequest'];
+        return $this->productStubData[$this->getProductStubIndex($entityId)][2][$type][$index]['buyRequest'];
     }
 
     /**
@@ -432,7 +419,7 @@ private function getStubProductBuyRequest($entityId, $index, $type)
      */
     private function getStubProductChildBuyRequest($entityId, $index, $type)
     {
-        return $this->productStubData[$entityId % count($this->productStubData)][2][$type][$index]['childBuyRequest'];
+        return $this->productStubData[$this->getProductStubIndex($entityId)][2][$type][$index]['childBuyRequest'];
     }
 
     /**
@@ -445,7 +432,20 @@ private function getStubProductChildBuyRequest($entityId, $index, $type)
      */
     private function getStubProductChildId($entityId, $index, $type)
     {
-        return $this->productStubData[$entityId % count($this->productStubData)][2][$type][$index]['childId'];
+        return $this->productStubData[$this->getProductStubIndex($entityId)][2][$type][$index]['childId'];
+    }
+
+    /**
+     * Get index of item in product stub array.
+     *
+     * @param int $entityId
+     * @return int
+     */
+    private function getProductStubIndex($entityId)
+    {
+        $storeCount = count($this->productStubData);
+        $qty = intdiv($this->config->getRequiredQuoteQuantity(), $storeCount);
+        return intdiv($entityId, $qty) % $storeCount;
     }
 
     /**
@@ -476,6 +476,7 @@ private function getAddressDataFixture()
     private function prepareProductsForQuote()
     {
         $result = [];
+
         foreach ($this->storeManager->getStores() as $store) {
             $productsResult = [];
             $this->storeManager->setCurrentStore($store->getId());
@@ -485,23 +486,21 @@ private function prepareProductsForQuote()
                     $this->getProductIds($store, Type::TYPE_SIMPLE, $this->config->getSimpleCountTo())
                 );
             }
-            if ($this->config->getConfigurableCountTo() > 0) {
-                $productsResult[Configurable::TYPE_CODE] = $this->prepareConfigurableProducts(
-                    $this->getProductIds(
-                        $store,
-                        Configurable::TYPE_CODE,
-                        $this->config->getConfigurableCountTo()
-                    )
-                );
-            }
-            if ($this->config->getBigConfigurableCountTo() > 0) {
-                $productsResult[QuoteConfiguration::BIG_CONFIGURABLE_TYPE] = $this->prepareConfigurableProducts(
-                    $this->getProductIds(
-                        $store,
-                        QuoteConfiguration::BIG_CONFIGURABLE_TYPE,
-                        $this->config->getBigConfigurableCountTo()
-                    )
-                );
+            $configurables = [
+                Configurable::TYPE_CODE => $this->config->getConfigurableCountTo(),
+                QuoteConfiguration::BIG_CONFIGURABLE_TYPE => $this->config->getBigConfigurableCountTo(),
+            ];
+
+            foreach ($configurables as $type => $qty) {
+                if ($qty > 0) {
+                    $productsResult[$type] = $this->prepareConfigurableProducts(
+                        $this->getProductIds(
+                            $store,
+                            $type,
+                            $qty
+                        )
+                    );
+                }
             }
 
             $result[] = [
@@ -514,6 +513,7 @@ private function prepareProductsForQuote()
                 $productsResult
             ];
         }
+
         return $result;
     }
 
diff --git a/setup/src/Magento/Setup/Test/Unit/Fixtures/Quote/QuoteConfigurationTest.php b/setup/src/Magento/Setup/Test/Unit/Fixtures/Quote/QuoteConfigurationTest.php
@@ -0,0 +1,74 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+namespace Magento\Setup\Test\Unit\Fixtures\Quote;
+
+/**
+ * Test for Magento\Setup\Fixtures\Quote\QuoteConfiguration class.
+ */
+class QuoteConfigurationTest extends \PHPUnit\Framework\TestCase
+{
+    /**
+     * @var \Magento\Setup\Fixtures\FixtureModel|\PHPUnit_Framework_MockObject_MockObject
+     */
+    private $fixtureModelMock;
+
+    /**
+     * @var \Magento\Setup\Fixtures\Quote\QuoteConfiguration
+     */
+    private $fixture;
+
+    /**
+     * @inheritdoc
+     */
+    public function setUp()
+    {
+        $this->fixtureModelMock = $this->getMockBuilder(\Magento\Setup\Fixtures\FixtureModel::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $objectManager = new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this);
+
+        $this->fixture = $objectManager->getObject(
+            \Magento\Setup\Fixtures\Quote\QuoteConfiguration::class,
+            [
+                'fixtureModel' => $this->fixtureModelMock
+            ]
+        );
+    }
+
+    /**
+     * Test load method.
+     *
+     * @return void
+     */
+    public function testLoad()
+    {
+        $dir = str_replace('Test/Unit/', '', dirname(__DIR__));
+        $expectedResult = [
+            'simple_count_to' => 1,
+            'simple_count_from' => 1,
+            'configurable_count_to' => 1,
+            'configurable_count_from' => 1,
+            'big_configurable_count_to' => 1,
+            'big_configurable_count_from' => 1,
+            'fixture_data_filename' =>
+                $dir . DIRECTORY_SEPARATOR . "_files" . DIRECTORY_SEPARATOR . 'orders_fixture_data.json',
+            'order_quotes_enable' => 1,
+        ];
+        $this->fixtureModelMock->expects($this->atLeastOnce())
+            ->method('getValue')
+            ->withConsecutive(
+                ['order_simple_product_count_to'],
+                ['order_simple_product_count_from'],
+                ['order_configurable_product_count_to'],
+                ['order_configurable_product_count_from'],
+                ['order_big_configurable_product_count_to'],
+                ['order_big_configurable_product_count_from'],
+                ['order_quotes_enable',]
+            )->willReturn(1);
+        $this->assertSame($expectedResult, $this->fixture->load()->getData());
+    }
+}
diff --git a/setup/src/Magento/Setup/Test/Unit/Fixtures/Quote/QuoteGeneratorFactoryTest.php b/setup/src/Magento/Setup/Test/Unit/Fixtures/Quote/QuoteGeneratorFactoryTest.php
@@ -0,0 +1,60 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+namespace Magento\Setup\Test\Unit\Fixtures\Quote;
+
+/**
+ * Test for Magento\Setup\Fixtures\Quote\QuoteGeneratorFactory class.
+ */
+class QuoteGeneratorFactoryTest extends \PHPUnit\Framework\TestCase
+{
+    /**
+     * @var \Magento\Framework\ObjectManagerInterface|\PHPUnit_Framework_MockObject_MockObject
+     */
+    private $objectManager;
+
+    /**
+     * @var \Magento\Setup\Fixtures\Quote\QuoteGeneratorFactory
+     */
+    private $fixture;
+
+    /**
+     * @inheritdoc
+     */
+    public function setUp()
+    {
+        $this->objectManager = $this->getMockBuilder(\Magento\Framework\ObjectManagerInterface::class)
+            ->disableOriginalConstructor()
+            ->getMockForAbstractClass();
+        $objectManager = new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this);
+
+        $this->fixture = $objectManager->getObject(
+            \Magento\Setup\Fixtures\Quote\QuoteGeneratorFactory::class,
+            [
+                'objectManager' => $this->objectManager,
+                'instanceName' => \Magento\Setup\Fixtures\Quote\QuoteGenerator::class,
+            ]
+        );
+    }
+
+    /**
+     * Test create method.
+     *
+     * @return void
+     */
+    public function testCreate()
+    {
+        $result =  $this->getMockBuilder(\Magento\Setup\Fixtures\Quote\QuoteGenerator::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->objectManager->expects($this->once())
+            ->method('create')
+            ->with(\Magento\Setup\Fixtures\Quote\QuoteGenerator::class, [])
+            ->willReturn($result);
+
+        $this->assertSame($result, $this->fixture->create([]));
+    }
+}
diff --git a/setup/src/Magento/Setup/Test/Unit/Fixtures/Quote/QuoteGeneratorTest.php b/setup/src/Magento/Setup/Test/Unit/Fixtures/Quote/QuoteGeneratorTest.php
