MAGETWO-85998: [2.3] Refunded order still in Processing Order status

Author: OlgaVasyltsun

app/code/Magento/Sales/Model/Order/CreditmemoFactory.php

@@ -14,7 +14,7 @@
 class CreditmemoFactory
 {
     /**
-     * Order convert object
+     * Order convert object.
      *
      * @var \Magento\Sales\Model\Convert\Order
      */
@@ -214,7 +214,7 @@ protected function initData($creditmemo, $data)
      * @param int $parentQty
      * @return int
      */
-    private function calculateProductOptions(Item $orderItem, $parentQty)
+    private function calculateProductOptions(Item $orderItem, int $parentQty): int
     {
         $qty = $parentQty;
         $productOptions = $orderItem->getProductOptions();

dev/tests/integration/testsuite/Magento/Sales/Model/Order/CreditmemoFactoryTest.php

@@ -60,7 +60,7 @@ public function testCreateByOrder(array $creditmemoData, $expectedQty)
     /**
      * @return array
      */
-    public function createByOrderDataProvider()
+    public function createByOrderDataProvider(): array
     {
         return [
             [
@@ -89,6 +89,8 @@ public function createByOrderDataProvider()
      * Checks a case when creditmemo created from the invoice.
      *
      * @magentoDataFixture Magento/Sales/_files/invoice_with_bundle.php
+     *
+     * @return void
      */
     public function testCreateByInvoice()
     {
@@ -104,7 +106,7 @@ public function testCreateByInvoice()
      * @param array $creditmemoData
      * @return array
      */
-    private function prepareCreditMemoData(Order $order, array $creditmemoData)
+    private function prepareCreditMemoData(Order $order, array $creditmemoData): array
     {
         $result = [];
         $orderItems = $order->getAllItems();

dev/tests/integration/testsuite/Magento/Sales/_files/order_with_bundle_and_invoiced.php

@@ -28,7 +28,7 @@
         OrderItemInterface::ROW_TOTAL => 102,
         OrderItemInterface::PRODUCT_TYPE => 'bundle',
         'product_options' => [
-            'product_calculations' => 0
+            'product_calculations' => 0,
         ],
         'children' => [
             [
@@ -42,7 +42,7 @@
                 OrderItemInterface::PRODUCT_TYPE => 'simple',
                 'product_options' => [
                     'bundle_selection_attributes' => [
-                        'qty' => 2
+                        'qty' => 2,
                     ],
                 ],
             ],