Skip to content

Commit c1ed528

Browse files
#23173: Static and integration tests fix.
1 parent 50f1f4e commit c1ed528

File tree

2 files changed

+56
-43
lines changed
  • app/code/Magento/Email/Block/Adminhtml/Template/Edit
  • dev/tests/integration/testsuite/Magento/Email/Model

2 files changed

+56
-43
lines changed

app/code/Magento/Email/Block/Adminhtml/Template/Edit/Form.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,8 @@ public function __construct(
5757

5858
/**
5959
* Prepare layout.
60-
* Add files to use dialog windows
60+
*
61+
* Add files to use dialog windows.
6162
*
6263
* @return $this
6364
*/

dev/tests/integration/testsuite/Magento/Email/Model/TemplateTest.php

Lines changed: 54 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -52,21 +52,23 @@ protected function mockModel($filesystem = null)
5252

5353
$this->model = $this->getMockBuilder(\Magento\Email\Model\Template::class)
5454
->setMethods(['_getMail'])
55-
->setConstructorArgs([
56-
$this->objectManager->get(\Magento\Framework\Model\Context::class),
57-
$this->objectManager->get(\Magento\Framework\View\DesignInterface::class),
58-
$this->objectManager->get(\Magento\Framework\Registry::class),
59-
$this->objectManager->get(\Magento\Store\Model\App\Emulation::class),
60-
$this->objectManager->get(\Magento\Store\Model\StoreManager::class),
61-
$this->objectManager->create(\Magento\Framework\View\Asset\Repository::class),
62-
$filesystem,
63-
$this->objectManager->create(\Magento\Framework\App\Config\ScopeConfigInterface::class),
64-
$this->objectManager->get(\Magento\Email\Model\Template\Config::class),
65-
$this->objectManager->get(\Magento\Email\Model\TemplateFactory::class),
66-
$this->objectManager->get(\Magento\Framework\Filter\FilterManager::class),
67-
$this->objectManager->get(\Magento\Framework\UrlInterface::class),
68-
$this->objectManager->get(\Magento\Email\Model\Template\FilterFactory::class),
69-
])
55+
->setConstructorArgs(
56+
[
57+
$this->objectManager->get(\Magento\Framework\Model\Context::class),
58+
$this->objectManager->get(\Magento\Framework\View\DesignInterface::class),
59+
$this->objectManager->get(\Magento\Framework\Registry::class),
60+
$this->objectManager->get(\Magento\Store\Model\App\Emulation::class),
61+
$this->objectManager->get(\Magento\Store\Model\StoreManager::class),
62+
$this->objectManager->create(\Magento\Framework\View\Asset\Repository::class),
63+
$filesystem,
64+
$this->objectManager->create(\Magento\Framework\App\Config\ScopeConfigInterface::class),
65+
$this->objectManager->get(\Magento\Email\Model\Template\Config::class),
66+
$this->objectManager->get(\Magento\Email\Model\TemplateFactory::class),
67+
$this->objectManager->get(\Magento\Framework\Filter\FilterManager::class),
68+
$this->objectManager->get(\Magento\Framework\UrlInterface::class),
69+
$this->objectManager->get(\Magento\Email\Model\Template\FilterFactory::class),
70+
]
71+
)
7072
->getMock();
7173

7274
$this->objectManager->get(\Magento\Framework\App\State::class)->setAreaCode('frontend');
@@ -122,12 +124,14 @@ public function testGetProcessedTemplate()
122124
->load();
123125

124126
$expectedViewUrl = '/frontend/Magento/blank/en_US/Magento_Theme/favicon.ico';
125-
$this->model->setDesignConfig([
126-
'area' => 'frontend',
127-
'store' => $this->objectManager->get(\Magento\Store\Model\StoreManagerInterface::class)
128-
->getStore('fixturestore')
129-
->getId(),
130-
]);
127+
$this->model->setDesignConfig(
128+
[
129+
'area' => 'frontend',
130+
'store' => $this->objectManager->get(\Magento\Store\Model\StoreManagerInterface::class)
131+
->getStore('fixturestore')
132+
->getId(),
133+
]
134+
);
131135
$this->model->setTemplateText('{{view url="Magento_Theme::favicon.ico"}}');
132136

133137
$this->setNotDefaultThemeForFixtureStore();
@@ -373,9 +377,11 @@ public function testTemplateStylesVariable($area, $expectedOutput, $unexpectedOu
373377
// @styles comments by default, it is necessary to mock an object to return testable contents
374378
$themeDirectory = $this->getMockBuilder(\Magento\Framework\Filesystem\Directory\ReadInterface::class)
375379
->disableOriginalConstructor()
376-
->setMethods([
377-
'readFile',
378-
])
380+
->setMethods(
381+
[
382+
'readFile',
383+
]
384+
)
379385
->getMockForAbstractClass();
380386

381387
$themeDirectory->expects($this->once())
@@ -478,10 +484,12 @@ protected function setUpAdminThemeFallback()
478484
$adminStore = $this->objectManager->create(\Magento\Store\Model\Store::class)
479485
->load(Store::ADMIN_CODE);
480486

481-
$this->model->setDesignConfig([
482-
'area' => 'adminhtml',
483-
'store' => $adminStore->getId(),
484-
]);
487+
$this->model->setDesignConfig(
488+
[
489+
'area' => 'adminhtml',
490+
'store' => $adminStore->getId(),
491+
]
492+
);
485493
}
486494

487495
/**
@@ -516,12 +524,14 @@ protected function setUpThemeFallback($area)
516524
'fixturestore'
517525
);
518526

519-
$this->model->setDesignConfig([
520-
'area' => 'frontend',
521-
'store' => $this->objectManager->get(\Magento\Store\Model\StoreManagerInterface::class)
522-
->getStore('fixturestore')
523-
->getId(),
524-
]);
527+
$this->model->setDesignConfig(
528+
[
529+
'area' => 'frontend',
530+
'store' => $this->objectManager->get(\Magento\Store\Model\StoreManagerInterface::class)
531+
->getStore('fixturestore')
532+
->getId(),
533+
]
534+
);
525535
}
526536

527537
/**
@@ -578,12 +588,14 @@ public function testGetProcessedTemplateSubject()
578588
->load();
579589

580590
$this->model->setTemplateSubject('{{view url="Magento_Theme::favicon.ico"}}');
581-
$this->model->setDesignConfig([
582-
'area' => 'frontend',
583-
'store' => $this->objectManager->get(\Magento\Store\Model\StoreManagerInterface::class)
584-
->getStore('fixturestore')
585-
->getId(),
586-
]);
591+
$this->model->setDesignConfig(
592+
[
593+
'area' => 'frontend',
594+
'store' => $this->objectManager->get(\Magento\Store\Model\StoreManagerInterface::class)
595+
->getStore('fixturestore')
596+
->getId(),
597+
]
598+
);
587599

588600
$this->setNotDefaultThemeForFixtureStore();
589601
$this->assertStringMatchesFormat(
@@ -703,8 +715,8 @@ public function testGetVariablesOptionArrayInGroup()
703715
$testTemplateVariables = '{"var data.name":"Sender Name","var data.email":"Sender Email"}';
704716
$this->model->setOrigTemplateVariables($testTemplateVariables);
705717
$variablesOptionArray = $this->model->getVariablesOptionArray(true);
706-
$this->assertEquals('Template Variables', $variablesOptionArray[0]['label']->getText());
707-
$this->assertEquals($this->model->getVariablesOptionArray(), $variablesOptionArray[0]['value']);
718+
$this->assertEquals('Template Variables', $variablesOptionArray['label']->getText());
719+
$this->assertEquals($this->model->getVariablesOptionArray(), $variablesOptionArray['value']);
708720
}
709721

710722
/**

0 commit comments

Comments
 (0)