MAGETWO-93761: [2.3] Currency conversion rate services do not work in admin panel

Author: Mastiuhin Olexandr

app/code/Magento/Directory/Model/Currency/Import/FixerIo.php

@@ -5,15 +5,18 @@
  */
 namespace Magento\Directory\Model\Currency\Import;
 
+use Magento\Store\Model\ScopeInterface;
+
 /**
  * Currency rate import model (From http://fixer.io/)
  */
-class FixerIo extends \Magento\Directory\Model\Currency\Import\AbstractImport
+class FixerIo extends AbstractImport
 {
     /**
      * @var string
      */
-    const CURRENCY_CONVERTER_URL = 'http://api.fixer.io/latest?base={{CURRENCY_FROM}}&symbols={{CURRENCY_TO}}';
+    const CURRENCY_CONVERTER_URL = 'http://data.fixer.io/api/latest?access_key={{ACCESS_KEY}}'
+        . '&base={{CURRENCY_FROM}}&symbols={{CURRENCY_TO}}';
 
     /**
      * Http Client Factory
@@ -47,7 +50,7 @@ public function __construct(
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function fetchRates()
     {
@@ -65,6 +68,13 @@ public function fetchRates()
         return $data;
     }
 
+    /**
+     * @inheritdoc
+     */
+    protected function _convert($currencyFrom, $currencyTo)
+    {
+    }
+
     /**
      * Return currencies convert rates in batch mode
      *
@@ -73,11 +83,21 @@ public function fetchRates()
      * @param array $currenciesTo
      * @return array
      */
-    private function convertBatch($data, $currencyFrom, $currenciesTo)
+    private function convertBatch(array $data, string $currencyFrom, array $currenciesTo): array
     {
+        $accessKey = $this->scopeConfig->getValue('currency/fixerio/api_key', ScopeInterface::SCOPE_STORE);
+        if (empty($accessKey)) {
+            $this->_messages[] = __('No API Key was specified or an invalid API Key was specified.');
+            $data[$currencyFrom] = $this->makeEmptyResponse($currenciesTo);
+            return $data;
+        }
+
         $currenciesStr = implode(',', $currenciesTo);
-        $url = str_replace('{{CURRENCY_FROM}}', $currencyFrom, self::CURRENCY_CONVERTER_URL);
-        $url = str_replace('{{CURRENCY_TO}}', $currenciesStr, $url);
+        $url = str_replace(
+            ['{{ACCESS_KEY}}', '{{CURRENCY_FROM}}', '{{CURRENCY_TO}}'],
+            [$accessKey, $currencyFrom, $currenciesStr],
+            self::CURRENCY_CONVERTER_URL
+        );
 
         set_time_limit(0);
         try {
@@ -86,6 +106,11 @@ private function convertBatch($data, $currencyFrom, $currenciesTo)
             ini_restore('max_execution_time');
         }
 
+        if (!$this->validateResponse($response, $currencyFrom)) {
+            $data[$currencyFrom] = $this->makeEmptyResponse($currenciesTo);
+            return $data;
+        }
+
         foreach ($currenciesTo as $currencyTo) {
             if ($currencyFrom == $currencyTo) {
                 $data[$currencyFrom][$currencyTo] = $this->_numberFormat(1);
@@ -110,25 +135,24 @@ private function convertBatch($data, $currencyFrom, $currenciesTo)
      * @param int $retry
      * @return array
      */
-    private function getServiceResponse($url, $retry = 0)
+    private function getServiceResponse(string $url, int $retry = 0): array
     {
         /** @var \Magento\Framework\HTTP\ZendClient $httpClient */
         $httpClient = $this->httpClientFactory->create();
         $response = [];
 
         try {
-            $jsonResponse = $httpClient->setUri(
-                $url
-            )->setConfig(
-                [
-                    'timeout' => $this->scopeConfig->getValue(
-                        'currency/fixerio/timeout',
-                        \Magento\Store\Model\ScopeInterface::SCOPE_STORE
-                    ),
-                ]
-            )->request(
-                'GET'
-            )->getBody();
+            $jsonResponse = $httpClient->setUri($url)
+                ->setConfig(
+                    [
+                        'timeout' => $this->scopeConfig->getValue(
+                            'currency/fixerio/timeout',
+                            ScopeInterface::SCOPE_STORE
+                        ),
+                    ]
+                )
+                ->request('GET')
+                ->getBody();
 
             $response = json_decode($jsonResponse, true);
         } catch (\Exception $e) {
@@ -140,9 +164,38 @@ private function getServiceResponse($url, $retry = 0)
     }
 
     /**
-     * {@inheritdoc}
+     * Validates rates response.
+     *
+     * @param array $response
+     * @param string $baseCurrency
+     * @return bool
      */
-    protected function _convert($currencyFrom, $currencyTo)
+    private function validateResponse(array $response, string $baseCurrency): bool
+    {
+        if ($response['success']) {
+            return true;
+        }
+
+        $errorCodes = [
+            101 => __('No API Key was specified or an invalid API Key was specified.'),
+            102 => __('The account this API request is coming from is inactive.'),
+            105 => __('The "%1" is not allowed as base currency for your subscription plan.', $baseCurrency),
+            201 => __('An invalid base currency has been entered.'),
+        ];
+
+        $this->_messages[] = $errorCodes[$response['error']['code']] ?? __('Currency rates can\'t be retrieved.');
+
+        return false;
+    }
+
+    /**
+     * Creates array for provided currencies with empty rates.
+     *
+     * @param array $currenciesTo
+     * @return array
+     */
+    private function makeEmptyResponse(array $currenciesTo): array
     {
+        return array_fill_keys($currenciesTo, null);
     }
 }