File tree Expand file tree Collapse file tree 2 files changed +4
-5
lines changed
app/code/Magento/GoogleAdwords Expand file tree Collapse file tree 2 files changed +4
-5
lines changed Original file line number Diff line number Diff line change @@ -61,11 +61,11 @@ public function execute(\Magento\Framework\Event\Observer $observer)
61
61
62
62
$ conversionValue = 0 ;
63
63
$ conversionCurrency = false ;
64
- $ orderHasSendCurrency = $ this ->_helper ->hasSendCurrency ();
64
+ $ sendOrderCurrency = $ this ->_helper ->hasSendCurrency ();
65
65
foreach ($ this ->_collection as $ order ) {
66
- /** @var $order \Magento\Sales\Model\Order */
67
- $ conversionValue += $ orderHasSendCurrency ? $ order ->getGrandTotal () : $ order ->getBaseGrandTotal ();
68
- $ conversionCurrency = $ orderHasSendCurrency ? $ order ->getOrderCurrencyCode () : false ;
66
+ /** @var $order \Magento\Sales\Api\Data\OrderInterface */
67
+ $ conversionValue += $ sendOrderCurrency ? $ order ->getGrandTotal () : $ order ->getBaseGrandTotal ();
68
+ $ conversionCurrency = $ sendOrderCurrency ? $ order ->getOrderCurrencyCode () : false ;
69
69
}
70
70
$ this ->_registry ->register (
71
71
\Magento \GoogleAdwords \Helper \Data::CONVERSION_VALUE_CURRENCY_REGISTRY_NAME ,
Original file line number Diff line number Diff line change @@ -225,7 +225,6 @@ public function testGetConversionValueDynamic()
225
225
$ this ->returnValue ($ returnValue )
226
226
);
227
227
228
-
229
228
$ this ->assertEquals ($ returnValue , $ this ->_helper ->getConversionValue ());
230
229
}
231
230
You can’t perform that action at this time.
0 commit comments