ENGCOM-6660: Fix confusing phpdoc in curl client #26495

lenaorobei · web-flow · commit c1c67aa598f1 · 2020-01-23T15:43:43.000-06:00
diff --git a/lib/internal/Magento/Framework/HTTP/Client/Curl.php b/lib/internal/Magento/Framework/HTTP/Client/Curl.php
@@ -107,9 +107,9 @@ class Curl implements \Magento\Framework\HTTP\ClientInterface
     protected $_headerCount = 0;
 
     /**
-     * Set request timeout, msec
+     * Set request timeout
      *
-     * @param int $value
+     * @param int $value value in seconds
      * @return void
      */
     public function setTimeout($value)
@@ -423,6 +423,7 @@ protected function makeRequest($method, $uri, $params = [])
      */
     public function doError($string)
     {
+        //  phpcs:ignore Magento2.Exceptions.DirectThrow
         throw new \Exception($string);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -107,9 +107,9 @@ class Curl implements \Magento\Framework\HTTP\ClientInterface`
`107`	`107`	`protected $_headerCount = 0;`
`108`	`108`
`109`	`109`	`/**`
`110`		`- * Set request timeout, msec`
	`110`	`+ * Set request timeout`
`111`	`111`	`*`
`112`		`- * @param int $value`
	`112`	`+ * @param int $value value in seconds`
`113`	`113`	`* @return void`
`114`	`114`	`*/`
`115`	`115`	`public function setTimeout($value)`
`@@ -423,6 +423,7 @@ protected function makeRequest($method, $uri, $params = [])`
`423`	`423`	`*/`
`424`	`424`	`public function doError($string)`
`425`	`425`	`{`
	`426`	`+ // phpcs:ignore Magento2.Exceptions.DirectThrow`
`426`	`427`	`throw new \Exception($string);`
`427`	`428`	`}`
`428`	`429`