Skip to content

Commit c1c1485

Browse files
committed
Merge branch '2.4-develop' of https://github.com/magento-commerce/magento2ce into ACP2E-3532
2 parents 0283239 + f388340 commit c1c1485

File tree

13 files changed

+112
-58
lines changed

13 files changed

+112
-58
lines changed

app/code/Magento/ProductAlert/Model/Price.php

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
<?php
22
/**
3-
* Copyright © Magento, Inc. All rights reserved.
4-
* See COPYING.txt for license details.
5-
*/
3+
* Copyright 2011 Adobe
4+
* All Rights Reserved.
5+
**/
66
namespace Magento\ProductAlert\Model;
77

88
use Magento\ProductAlert\Model\ResourceModel\Price\Customer\Collection;
@@ -29,8 +29,6 @@
2929
* @method int getStoreId()
3030
* @method \Magento\ProductAlert\Model\Stock setStoreId(int $value)
3131
*
32-
* @author Magento Core Team <core@magentocommerce.com>
33-
*
3432
* @api
3533
* @since 100.0.2
3634
*/
@@ -95,7 +93,7 @@ public function loadByParam()
9593
}
9694

9795
/**
98-
* Method for deleting customer from website.
96+
* Method for deleting customer's price alert from website.
9997
*
10098
* @param int $customerId
10199
* @param int $websiteId

app/code/Magento/ProductAlert/Model/Stock.php

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
<?php
22
/**
3-
* Copyright © Magento, Inc. All rights reserved.
4-
* See COPYING.txt for license details.
5-
*/
3+
* Copyright 2011 Adobe
4+
* All Rights Reserved.
5+
**/
66
namespace Magento\ProductAlert\Model;
77

88
use Magento\ProductAlert\Model\ResourceModel\Stock\Customer\Collection;
@@ -27,8 +27,6 @@
2727
* @method int getStoreId()
2828
* @method \Magento\ProductAlert\Model\Stock setStoreId(int $value)
2929
*
30-
* @author Magento Core Team <core@magentocommerce.com>
31-
*
3230
* @api
3331
* @since 100.0.2
3432
*/
@@ -93,7 +91,7 @@ public function loadByParam()
9391
}
9492

9593
/**
96-
* Method for deleting customer from website.
94+
* Method for deleting customer's stock alert from website.
9795
*
9896
* @param int $customerId
9997
* @param int $websiteId

app/code/Magento/SalesGraphQl/Model/Formatter/Order.php

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,15 @@
11
<?php
22
/**
3-
* Copyright © Magento, Inc. All rights reserved.
4-
* See COPYING.txt for license details.
3+
* Copyright 2020 Adobe
4+
* All Rights Reserved.
55
*/
66
declare(strict_types=1);
77

88
namespace Magento\SalesGraphQl\Model\Formatter;
99

10+
use Magento\Framework\App\ObjectManager;
11+
use Magento\Framework\Stdlib\DateTime;
12+
use Magento\Framework\Stdlib\DateTime\TimezoneInterface;
1013
use Magento\Framework\Exception\LocalizedException;
1114
use Magento\Sales\Api\Data\OrderInterface;
1215
use Magento\SalesGraphQl\Model\Order\OrderAddress;
@@ -20,11 +23,14 @@ class Order
2023
/**
2124
* @param OrderAddress $orderAddress
2225
* @param OrderPayments $orderPayments
26+
* @param TimezoneInterface|null $timezone
2327
*/
2428
public function __construct(
2529
private readonly OrderAddress $orderAddress,
26-
private readonly OrderPayments $orderPayments
30+
private readonly OrderPayments $orderPayments,
31+
private ?TimezoneInterface $timezone = null
2732
) {
33+
$this->timezone = $timezone ?: ObjectManager::getInstance()->get(TimezoneInterface::class);
2834
}
2935

3036
/**
@@ -42,7 +48,8 @@ public function format(OrderInterface $orderModel): array
4248
'id' => base64_encode((string)$orderModel->getEntityId()),
4349
'increment_id' => $orderModel->getIncrementId(),
4450
'number' => $orderModel->getIncrementId(),
45-
'order_date' => $orderModel->getCreatedAt(),
51+
'order_date' => $this->timezone->date($orderModel->getCreatedAt())
52+
->format(DateTime::DATETIME_PHP_FORMAT),
4653
'order_number' => $orderModel->getIncrementId(),
4754
'status' => $orderModel->getStatusLabel(),
4855
'email' => $orderModel->getCustomerEmail(),

app/code/Magento/SalesGraphQl/Model/Resolver/CreditMemo/CreditMemoComments.php

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,35 @@
11
<?php
22
/**
3-
* Copyright © Magento, Inc. All rights reserved.
4-
* See COPYING.txt for license details.
3+
* Copyright 2020 Adobe
4+
* All Rights Reserved.
55
*/
66
declare(strict_types=1);
77

88
namespace Magento\SalesGraphQl\Model\Resolver\CreditMemo;
99

10+
use Magento\Framework\App\ObjectManager;
1011
use Magento\Framework\Exception\LocalizedException;
1112
use Magento\Framework\GraphQl\Config\Element\Field;
1213
use Magento\Framework\GraphQl\Query\ResolverInterface;
1314
use Magento\Framework\GraphQl\Schema\Type\ResolveInfo;
15+
use Magento\Framework\Stdlib\DateTime;
16+
use Magento\Framework\Stdlib\DateTime\TimezoneInterface;
1417
use Magento\Sales\Api\Data\CreditmemoInterface;
1518

1619
/**
1720
* Resolve credit memo comments
1821
*/
1922
class CreditMemoComments implements ResolverInterface
2023
{
24+
/**
25+
* @param TimezoneInterface|null $timezone
26+
*/
27+
public function __construct(
28+
private ?TimezoneInterface $timezone = null
29+
) {
30+
$this->timezone = $timezone ?: ObjectManager::getInstance()->get(TimezoneInterface::class);
31+
}
32+
2133
/**
2234
* @inheritDoc
2335
*/
@@ -40,7 +52,8 @@ public function resolve(
4052
if ($comment->getIsVisibleOnFront()) {
4153
$comments[] = [
4254
'message' => $comment->getComment(),
43-
'timestamp' => $comment->getCreatedAt()
55+
'timestamp' => $this->timezone->date($comment->getCreatedAt())
56+
->format(DateTime::DATETIME_PHP_FORMAT)
4457
];
4558
}
4659
}

app/code/Magento/SalesGraphQl/Model/Resolver/Invoices.php

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,19 @@
11
<?php
22
/**
3-
* Copyright © Magento, Inc. All rights reserved.
4-
* See COPYING.txt for license details.
3+
* Copyright 2020 Adobe
4+
* All Rights Reserved.
55
*/
66
declare(strict_types=1);
77

88
namespace Magento\SalesGraphQl\Model\Resolver;
99

10+
use Magento\Framework\App\ObjectManager;
1011
use Magento\Framework\Exception\LocalizedException;
1112
use Magento\Framework\GraphQl\Config\Element\Field;
1213
use Magento\Framework\GraphQl\Query\ResolverInterface;
1314
use Magento\Framework\GraphQl\Schema\Type\ResolveInfo;
15+
use Magento\Framework\Stdlib\DateTime;
16+
use Magento\Framework\Stdlib\DateTime\TimezoneInterface;
1417
use Magento\Sales\Api\Data\OrderInterface;
1518
use Magento\Sales\Api\Data\InvoiceInterface;
1619

@@ -19,6 +22,15 @@
1922
*/
2023
class Invoices implements ResolverInterface
2124
{
25+
/**
26+
* @param TimezoneInterface|null $timezone
27+
*/
28+
public function __construct(
29+
private ?TimezoneInterface $timezone = null
30+
) {
31+
$this->timezone = $timezone ?: ObjectManager::getInstance()->get(TimezoneInterface::class);
32+
}
33+
2234
/**
2335
* @inheritDoc
2436
*/
@@ -61,7 +73,8 @@ private function getInvoiceComments(InvoiceInterface $invoice): array
6173
foreach ($invoice->getComments() as $comment) {
6274
if ($comment->getIsVisibleOnFront()) {
6375
$comments[] = [
64-
'timestamp' => $comment->getCreatedAt(),
76+
'timestamp' => $this->timezone->date($comment->getCreatedAt())
77+
->format(DateTime::DATETIME_PHP_FORMAT),
6578
'message' => $comment->getComment()
6679
];
6780
}

app/code/Magento/SalesGraphQl/Model/Resolver/Shipments.php

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,19 @@
11
<?php
22
/**
3-
* Copyright © Magento, Inc. All rights reserved.
4-
* See COPYING.txt for license details.
3+
* Copyright 2020 Adobe
4+
* All Rights Reserved.
55
*/
66
declare(strict_types=1);
77

88
namespace Magento\SalesGraphQl\Model\Resolver;
99

10+
use Magento\Framework\App\ObjectManager;
1011
use Magento\Framework\Exception\LocalizedException;
1112
use Magento\Framework\GraphQl\Config\Element\Field;
1213
use Magento\Framework\GraphQl\Query\ResolverInterface;
1314
use Magento\Framework\GraphQl\Schema\Type\ResolveInfo;
15+
use Magento\Framework\Stdlib\DateTime;
16+
use Magento\Framework\Stdlib\DateTime\TimezoneInterface;
1417
use Magento\Sales\Api\Data\ShipmentInterface;
1518
use Magento\Sales\Model\Order;
1619

@@ -19,6 +22,15 @@
1922
*/
2023
class Shipments implements ResolverInterface
2124
{
25+
/**
26+
* @param TimezoneInterface|null $timezone
27+
*/
28+
public function __construct(
29+
private ?TimezoneInterface $timezone = null
30+
) {
31+
$this->timezone = $timezone ?: ObjectManager::getInstance()->get(TimezoneInterface::class);
32+
}
33+
2234
/**
2335
* @inheritDoc
2436
*/
@@ -62,7 +74,8 @@ private function getShipmentComments(ShipmentInterface $shipment): array
6274
foreach ($shipment->getComments() as $comment) {
6375
if ($comment->getIsVisibleOnFront()) {
6476
$comments[] = [
65-
'timestamp' => $comment->getCreatedAt(),
77+
'timestamp' => $this->timezone->date($comment->getCreatedAt())
78+
->format(DateTime::DATETIME_PHP_FORMAT),
6679
'message' => $comment->getComment()
6780
];
6881
}

app/code/Magento/Ui/view/base/web/js/form/element/media.js

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/**
2-
* Copyright © Magento, Inc. All rights reserved.
3-
* See COPYING.txt for license details.
2+
* Copyright 2015 Adobe
3+
* All Rights Reserved.
44
*/
55

66
/**
@@ -14,6 +14,7 @@ define([
1414

1515
return Abstract.extend({
1616
defaults: {
17+
value: '',
1718
links: {
1819
value: ''
1920
}
@@ -47,6 +48,16 @@ define([
4748
this.formId = namespace[0];
4849

4950
return this;
51+
},
52+
53+
/**
54+
* Set the file input value
55+
*
56+
* @param {FileUploader} fileUploader - UI Class
57+
* @param {Event} e
58+
*/
59+
setFileValue: function (fileUploader, e) {
60+
this.value(e.target.files.length ? e.target.files.length : '');
5061
}
5162
});
5263
});
Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
<!--
2-
/**
3-
* Copyright © Magento, Inc. All rights reserved.
4-
* See COPYING.txt for license details.
5-
*/
2+
/**
3+
* Copyright 2011 Adobe
4+
* All Rights Reserved.
5+
*/
66
-->
77
<input class="admin__control-file" type="file" data-bind="
88
hasFocus: focused,
@@ -13,5 +13,5 @@
1313
id: uid,
1414
disabled: disabled,
1515
form: formId
16-
}"
17-
/>
16+
}, event:{change: setFileValue}"
17+
>

dev/tests/api-functional/testsuite/Magento/GraphQl/Sales/RetrieveOrdersByOrderNumberTest.php

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?php
22
/**
3-
* Copyright © Magento, Inc. All rights reserved.
4-
* See COPYING.txt for license details.
3+
* Copyright 2020 Adobe
4+
* All Rights Reserved.
55
*/
66
declare(strict_types=1);
77

@@ -11,6 +11,8 @@
1111
use Magento\Framework\Api\SearchCriteriaBuilder;
1212
use Magento\Framework\Exception\AuthenticationException;
1313
use Magento\Framework\Registry;
14+
use Magento\Framework\Stdlib\DateTime;
15+
use Magento\Framework\Stdlib\DateTime\TimezoneInterface;
1416
use Magento\GraphQl\GetCustomerAuthenticationHeader;
1517
use Magento\Sales\Api\OrderRepositoryInterface;
1618
use Magento\Sales\Model\ResourceModel\Order\Collection;
@@ -33,6 +35,8 @@
3335

3436
/**
3537
* Class RetrieveOrdersTest
38+
*
39+
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
3640
*/
3741
class RetrieveOrdersByOrderNumberTest extends GraphQlAbstract
3842
{
@@ -48,6 +52,9 @@ class RetrieveOrdersByOrderNumberTest extends GraphQlAbstract
4852
/** @var ProductRepositoryInterface */
4953
private $productRepository;
5054

55+
/** @var TimezoneInterface */
56+
private $timezone;
57+
5158
/**
5259
* @var DataFixtureStorage
5360
*/
@@ -61,6 +68,7 @@ protected function setUp():void
6168
$this->orderRepository = $objectManager->get(OrderRepositoryInterface::class);
6269
$this->searchCriteriaBuilder = $objectManager->get(SearchCriteriaBuilder::class);
6370
$this->productRepository = $objectManager->get(ProductRepositoryInterface::class);
71+
$this->timezone = $objectManager->get(TimezoneInterface::class);
6472
$this->fixtures = $objectManager->get(DataFixtureStorageManager::class)->getStorage();
6573
}
6674

@@ -500,7 +508,8 @@ public function testGetCustomerDescendingSortedOrders()
500508
$orderNumberCreatedAtExpected = [];
501509
for ($i = 1; $i <= 3; $i++) {
502510
$orderNumber = $this->fixtures->get('or' . $i)->getIncrementId();
503-
$orderCreatedAt = $this->fixtures->get('or' . $i)->getCreatedAt();
511+
$orderCreatedAt = $this->timezone->date($this->fixtures->get('or' . $i)->getCreatedAt())
512+
->format(DateTime::DATETIME_PHP_FORMAT);
504513
$orderNumberCreatedAtExpected[$orderNumber] = $orderCreatedAt;
505514
}
506515

lib/internal/Magento/Framework/App/Config.php

Lines changed: 5 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
<?php
22
/**
3-
*
4-
* Copyright © Magento, Inc. All rights reserved.
5-
* See COPYING.txt for license details.
3+
* Copyright 2013 Adobe
4+
* All Rights Reserved.
65
*/
6+
77
namespace Magento\Framework\App;
88

99
use Magento\Framework\App\Config\ConfigTypeInterface;
@@ -45,12 +45,7 @@ public function __construct(
4545
}
4646

4747
/**
48-
* Retrieve config value by path and scope
49-
*
50-
* @param string $path
51-
* @param string $scope
52-
* @param null|int|string $scopeCode
53-
* @return mixed
48+
* @inheritDoc
5449
*/
5550
public function getValue(
5651
$path = null,
@@ -80,12 +75,7 @@ public function getValue(
8075
}
8176

8277
/**
83-
* Retrieve config flag
84-
*
85-
* @param string $path
86-
* @param string $scope
87-
* @param null|int|string $scopeCode
88-
* @return bool
78+
* @inheritDoc
8979
*/
9080
public function isSetFlag($path, $scope = ScopeConfigInterface::SCOPE_TYPE_DEFAULT, $scopeCode = null)
9181
{

0 commit comments

Comments
 (0)