MAGETWO-52079: [GITHUB] Order Repository GetList Method always returns the same shipping address for all orders #4019

Author: Mulderua

app/code/Magento/Sales/Model/OrderRepository.php

@@ -16,7 +16,6 @@
 use Magento\Framework\Exception\NoSuchEntityException;
 use Magento\Framework\Exception\InputException;
 use Magento\Framework\Api\SortOrder;
-use Magento\Framework\App\ObjectManager;
 
 /**
  * Repository class for @see OrderInterface
@@ -34,6 +33,16 @@ class OrderRepository implements \Magento\Sales\Api\OrderRepositoryInterface
      */
     protected $searchResultFactory = null;
 
+    /**
+     * @var OrderExtension
+     */
+    private $orderExtension;
+
+    /**
+     * @var ShippingAssignmentBuilder
+     */
+    private $shippingAssignmentBuilder;
+
     /**
      * OrderInterface[]
      *
@@ -164,7 +173,7 @@ private function setShippingAssignments(OrderInterface $order)
         $extensionAttributes = $order->getExtensionAttributes();
 
         if ($extensionAttributes === null) {
-            $extensionAttributes = $this->getOrderExtensionDependency();
+            $extensionAttributes = $this->getOrderExtensionDependency()->create();
         } elseif ($extensionAttributes->getShippingAssignments() !== null) {
             return;
         }
@@ -182,10 +191,12 @@ private function setShippingAssignments(OrderInterface $order)
      */
     private function getOrderExtensionDependency()
     {
-
-        return ObjectManager::getInstance()->create(
-            '\Magento\Sales\Api\Data\OrderExtension'
-        );
+        if (!$this->orderExtension instanceof OrderExtension) {
+            $this->orderExtension = \Magento\Framework\App\ObjectManager::getInstance()->get(
+                '\Magento\Sales\Api\Data\OrderExtensionFactory'
+            );
+        }
+        return $this->orderExtension;
     }
 
     /**
@@ -196,9 +207,12 @@ private function getOrderExtensionDependency()
      */
     private function getShippingAssignmentBuilderDependency()
     {
-        return ObjectManager::getInstance()->create(
-            '\Magento\Sales\Model\Order\ShippingAssignmentBuilder'
-        );
+        if (!$this->shippingAssignmentBuilder instanceof ShippingAssignmentBuilder) {
+            $this->shippingAssignmentBuilder = \Magento\Framework\App\ObjectManager::getInstance()->get(
+                '\Magento\Sales\Model\Order\ShippingAssignmentBuilder'
+            );
+        }
+        return $this->shippingAssignmentBuilder;
     }
 
     /**

app/code/Magento/Sales/Test/Unit/Model/OrderRepositoryTest.php

@@ -75,7 +75,7 @@ public function testGetList()
 
         $extensionAttributes = $this->getMock(
             '\Magento\Sales\Api\Data\OrderExtension',
-            ['getShippingAssignments'],
+            [],
             [],
             '',
             false