MAGETWO-58014: [GitHub] page cache also caches breadcrumbs #5502

Author: ameysar

app/code/Magento/Catalog/Test/Unit/ViewModel/Product/BreadcrumbsTest.php

@@ -95,7 +95,7 @@ public function testIsCategoryUsedInProductUrl()
      * @param string $expectedName
      * @return void
      */
-    public function testGetProductName($product, $expectedName)
+    public function testGetProductName($product, string $expectedName)
     {
         $this->catalogHelper->expects($this->atLeastOnce())
             ->method('getProduct')

app/code/Magento/Catalog/view/frontend/web/js/product/breadcrumbs.js

@@ -88,13 +88,9 @@ define([
              * @private
              */
             _getCategoryCrumb: function (menuItem) {
-                var categoryId,
-                    categoryName,
-                    categoryUrl;
-
-                categoryId = /(\d+)/i.exec(menuItem.attr('id'))[0];
-                categoryName = menuItem.text();
-                categoryUrl = menuItem.attr('href');
+                var categoryId = /(\d+)/i.exec(menuItem.attr('id'))[0],
+                    categoryName = menuItem.text(),
+                    categoryUrl = menuItem.attr('href');
 
                 return {
                     'name': 'category' + categoryId,

dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertProductViewBreadcrumbsCategory.php

@@ -35,12 +35,11 @@ public function processAssert(
         BrowserInterface $browser,
         CatalogProductSimple $product
     ) {
-        $categories = is_object($product->getDataFieldConfig('category_ids')['source']) ?
-            $product->getDataFieldConfig('category_ids')['source']->getCategories()
+        $categories = is_object($product->getDataFieldConfig('category_ids')['source'])
+            ? $product->getDataFieldConfig('category_ids')['source']->getCategories()
             : [];
 
         if (!empty($categories)) {
-
             /** @var Category $category */
             foreach ($categories as $category) {
                 $cmsIndex->open();