Skip to content

Commit c09c8d5

Browse files
escapeJsQuote instead of escapeJs
Fix issue 13827
1 parent ddf6862 commit c09c8d5

File tree

1 file changed

+6
-6
lines changed
  • app/code/Magento/GoogleAnalytics/Block

1 file changed

+6
-6
lines changed

app/code/Magento/GoogleAnalytics/Block/Ga.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -128,8 +128,8 @@ public function getOrdersTrackingCode()
128128
'price': '%s',
129129
'quantity': %s
130130
});",
131-
$this->escapeJs($item->getSku()),
132-
$this->escapeJs($item->getName()),
131+
$this->escapeJsQuote($item->getSku()),
132+
$this->escapeJsQuote($item->getName()),
133133
$item->getPrice(),
134134
$item->getQtyOrdered()
135135
);
@@ -144,7 +144,7 @@ public function getOrdersTrackingCode()
144144
'shipping': '%s'
145145
});",
146146
$order->getIncrementId(),
147-
$this->escapeJs($this->_storeManager->getStore()->getFrontendName()),
147+
$this->escapeJsQuote($this->_storeManager->getStore()->getFrontendName()),
148148
$order->getGrandTotal(),
149149
$order->getTaxAmount(),
150150
$order->getShippingAmount()
@@ -234,15 +234,15 @@ public function getOrdersTrackingData()
234234
foreach ($collection as $order) {
235235
foreach ($order->getAllVisibleItems() as $item) {
236236
$result['products'][] = [
237-
'id' => $this->escapeJs($item->getSku()),
238-
'name' => $this->escapeJs($item->getName()),
237+
'id' => $this->escapeJsQuote($item->getSku()),
238+
'name' => $this->escapeJsQuote($item->getName()),
239239
'price' => $item->getPrice(),
240240
'quantity' => $item->getQtyOrdered(),
241241
];
242242
}
243243
$result['orders'][] = [
244244
'id' => $order->getIncrementId(),
245-
'affiliation' => $this->escapeJs($this->_storeManager->getStore()->getFrontendName()),
245+
'affiliation' => $this->escapeJsQuote($this->_storeManager->getStore()->getFrontendName()),
246246
'revenue' => $order->getGrandTotal(),
247247
'tax' => $order->getTaxAmount(),
248248
'shipping' => $order->getShippingAmount(),

0 commit comments

Comments
 (0)