ENGCOM-5934: fixed schedule currency_rates_update cron job not working #24590

Author: sidolov

app/code/Magento/Directory/Model/Observer.php

@@ -12,6 +12,11 @@
 
 namespace Magento\Directory\Model;
 
+/**
+ * Class Observer
+ *
+ * @package Magento\Directory\Model
+ */
 class Observer
 {
     const CRON_STRING_PATH = 'crontab/default/jobs/currency_rates_update/schedule/cron_expr';
@@ -83,6 +88,8 @@ public function __construct(
     }
 
     /**
+     * Schedule update currency rates
+     *
      * @param mixed $schedule
      * @return void
      * @throws \Exception
@@ -122,7 +129,7 @@ public function scheduledUpdateCurrencyRates($schedule)
             $importWarnings[] = __('FATAL ERROR:') . ' ' . __('Please specify the correct Import Service.');
         }
 
-        if (sizeof($errors) > 0) {
+        if (count($errors) > 0) {
             foreach ($errors as $error) {
                 $importWarnings[] = __('WARNING:') . ' ' . $error;
             }
@@ -132,7 +139,7 @@ public function scheduledUpdateCurrencyRates($schedule)
             self::XML_PATH_ERROR_RECIPIENT,
             \Magento\Store\Model\ScopeInterface::SCOPE_STORE
         );
-        if (sizeof($importWarnings) == 0) {
+        if (count($importWarnings) == 0) {
             $this->_currencyFactory->create()->saveRates($rates);
         } elseif ($errorRecipient) {
             //if $errorRecipient is not set, there is no sense send email to nobody

app/code/Magento/Directory/etc/crontab.xml

@@ -7,6 +7,8 @@
 -->
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:module:Magento_Cron:etc/crontab.xsd">
     <group id="default">
-        <job name="currency_rates_update" instance="Magento\Directory\Model\Observer" method="scheduledUpdateCurrencyRates" />
+        <job name="currency_rates_update" instance="Magento\Directory\Model\Observer" method="scheduledUpdateCurrencyRates">
+            <config_path>crontab/default/jobs/currency_rates_update/schedule/cron_expr</config_path>
+        </job>
     </group>
 </config>