MAGETWO-38059: [TD] Create list of SOAP endpoints

- Fix tests

Author: Eugene Tulika

app/code/Magento/Webapi/Controller/Soap.php

@@ -74,8 +74,6 @@ class Soap implements \Magento\Framework\App\FrontControllerInterface
     protected $rendererFactory;
 
     /**
-     * Initialize dependencies.
-     *
      * @param Soap\Request $request
      * @param Response $response
      * @param \Magento\Webapi\Model\Soap\Wsdl\Generator $wsdlGenerator
@@ -84,7 +82,9 @@ class Soap implements \Magento\Framework\App\FrontControllerInterface
      * @param \Magento\Framework\App\State $appState
      * @param \Magento\Framework\Locale\ResolverInterface $localeResolver
      * @param PathProcessor $pathProcessor
+     * @param \Magento\Framework\Webapi\Rest\Response\RendererFactory $rendererFactory
      * @param \Magento\Framework\App\AreaList $areaList
+     * @SuppressWarnings(PHPMD.ExcessiveParameterList)
      */
     public function __construct(
         \Magento\Webapi\Controller\Soap\Request $request,
@@ -131,15 +131,14 @@ public function dispatch(\Magento\Framework\App\RequestInterface $request)
                 $this->_setResponseBody($responseBody);
             } else if ($this->_isWsdlListRequest()) {
                 $servicesList = [];
-                foreach ($this->_wsdlGenerator->getListOfServices() as $serviceName => $serviceData) {
+                foreach (array_keys($this->_wsdlGenerator->getListOfServices()) as $serviceName) {
                     $servicesList[$serviceName]['wsdl_endpoint'] = $this->_soapServer->getEndpointUri()
                         . '?' . \Magento\Webapi\Model\Soap\Server::REQUEST_PARAM_WSDL . '&services=' . $serviceName;
                 }
                 $renderer = $this->rendererFactory->get();
                 $this->_setResponseContentType($renderer->getMimeType());
                 $this->_setResponseBody($renderer->render($servicesList));
-            }
-            else {
+            } else {
                 $this->_soapServer->handle();
             }
         } catch (\Exception $e) {

app/code/Magento/Webapi/Test/Unit/Controller/SoapTest.php

@@ -44,6 +44,11 @@ class SoapTest extends \PHPUnit_Framework_TestCase
      */
     protected $_localeMock;
 
+    /**
+     * @var \PHPUnit_Framework_MockObject_MockObject|\Magento\Framework\App\State
+     */
+    protected $_appStateMock;
+
     /**
      * Set up Controller object.
      */
@@ -71,7 +76,8 @@ protected function setUp()
             ->disableOriginalConstructor()
             ->setMethods(['maskException'])
             ->getMock();
-        $this->_appStateMock =  $this->getMock('\Magento\Framework\App\State', [], [], '', false);
+
+        $this->_appStateMock =  $this->getMock('Magento\Framework\App\State', [], [], '', false);
 
         $localeResolverMock = $this->getMockBuilder(
             'Magento\Framework\Locale\Resolver'
@@ -93,6 +99,10 @@ protected function setUp()
         $areaListMock = $this->getMock('Magento\Framework\App\AreaList', [], [], '', false);
         $areaMock = $this->getMock('Magento\Framework\App\AreaInterface');
         $areaListMock->expects($this->any())->method('getArea')->will($this->returnValue($areaMock));
+
+        $rendererMock = $this->getMockBuilder('Magento\Framework\Webapi\Rest\Response\RendererFactory')
+            ->disableOriginalConstructor()
+            ->getMock();
         $this->_soapController = new \Magento\Webapi\Controller\Soap(
             $this->_requestMock,
             $this->_responseMock,
@@ -102,6 +112,7 @@ protected function setUp()
             $this->_appStateMock,
             $localeResolverMock,
             $pathProcessorMock,
+            $rendererMock,
             $areaListMock
         );
     }