MAGETWO-89532: Google Analytics - addToCart event triggers before adding to cart

Author: iivashchenko

app/code/Magento/Checkout/view/frontend/web/js/sidebar.js

@@ -9,11 +9,12 @@ define([
     'Magento_Customer/js/customer-data',
     'Magento_Ui/js/modal/alert',
     'Magento_Ui/js/modal/confirm',
+    'underscore',
     'jquery/ui',
     'mage/decorate',
     'mage/collapsible',
     'mage/cookies'
-], function ($, authenticationPopup, customerData, alert, confirm) {
+], function ($, authenticationPopup, customerData, alert, confirm, _) {
     'use strict';
 
     $.widget('mage.sidebar', {
@@ -219,6 +220,11 @@ define([
          * @param {HTMLElement} elem
          */
         _updateItemQtyAfter: function (elem) {
+            var productData = this._getProductById(Number(elem.data('cart-item')));
+
+            if (!_.isUndefined(productData)) {
+                $(document).trigger('ajax:updateCartItemQty', productData['product_sku']);
+            }
             this._hideItemButton(elem);
         },
 
@@ -241,11 +247,24 @@ define([
          * @private
          */
         _removeItemAfter: function (elem) {
-            var productData = customerData.get('cart')().items.find(function (item) {
-                return Number(elem.data('cart-item')) === Number(item['item_id']);
-            });
+            var productData = this._getProductById(Number(elem.data('cart-item')));
+
+            if (!_.isUndefined(productData)) {
+                $(document).trigger('ajax:removeFromCart', productData['product_sku']);
+            }
+        },
 
-            $(document).trigger('ajax:removeFromCart', productData['product_sku']);
+        /**
+         * Retrieves product data by Id.
+         *
+         * @param {Number} productId - product Id
+         * @returns {Object|undefined}
+         * @private
+         */
+        _getProductById: function (productId) {
+            return _.find(customerData.get('cart')().items, function (item) {
+                return productId === Number(item['item_id']);
+            });
         },
 
         /**

dev/tests/js/jasmine/tests/app/code/Magento/Checkout/frontend/js/sidebar.test.js

@@ -0,0 +1,109 @@
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+/* eslint-disable max-nested-callbacks */
+/*jscs:disable jsDoc*/
+
+define([
+    'squire',
+    'jquery',
+    'ko'
+], function (Squire, $, ko) {
+    'use strict';
+
+    describe('Magento_Checkout/js/sidebar', function () {
+        var injector = new Squire(),
+            mocks = {
+                'Magento_Customer/js/customer-data': {
+                    get: function () {
+                        return ko.observable();
+                    }
+                }
+            },
+            sidebar,
+            cartData = {
+                'items': [
+                    {
+                        'item_id': 1,
+                        'product_sku': 'bundle'
+                    },
+                    {
+                        'item_id': 5,
+                        'product_sku': 'simple'
+                    },
+                    {
+                        'item_id': 7,
+                        'product_sku': 'configurable'
+                    }
+                ]
+            },
+            cart = ko.observable(cartData);
+
+        beforeEach(function (done) {
+            injector.mock(mocks);
+            injector.require(['Magento_Checkout/js/sidebar'], function (Constr) {
+                sidebar = new Constr;
+                done();
+            });
+        });
+
+        describe('Check remove mini-cart item callback.', function () {
+            beforeEach(function () {
+                spyOn(jQuery.fn, 'trigger');
+                spyOn(mocks['Magento_Customer/js/customer-data'], 'get').and.returnValue(cart);
+            });
+
+            it('Method "_removeItemAfter" is defined', function () {
+                expect(sidebar._removeItemAfter).toBeDefined();
+            });
+
+            it('Cart item is exists', function () {
+                var elem = $('<input>').data('cart-item', 5);
+
+                sidebar._removeItemAfter(elem);
+                expect(mocks['Magento_Customer/js/customer-data'].get).toHaveBeenCalledWith('cart');
+                expect(jQuery('body').trigger).toHaveBeenCalledWith('ajax:removeFromCart', 'simple');
+            });
+
+            it('Cart item doesn\'t exists', function () {
+                var elem = $('<input>').data('cart-item', 100);
+
+                sidebar._removeItemAfter(elem);
+                expect(jQuery('body').trigger).not.toHaveBeenCalled();
+            });
+        });
+
+        describe('Check update item quantity callback.', function () {
+            beforeEach(function () {
+                spyOn(jQuery.fn, 'trigger');
+                spyOn(mocks['Magento_Customer/js/customer-data'], 'get').and.returnValue(cart);
+            });
+
+            it('Method "_updateItemQtyAfter" is defined', function () {
+                expect(sidebar._updateItemQtyAfter).toBeDefined();
+            });
+
+            it('Cart item is exists', function () {
+                var elem = $('<input>').data('cart-item', 5);
+
+                spyOn(sidebar, '_hideItemButton');
+
+                sidebar._updateItemQtyAfter(elem);
+                expect(mocks['Magento_Customer/js/customer-data'].get).toHaveBeenCalledWith('cart');
+                expect(jQuery('body').trigger).toHaveBeenCalledWith('ajax:updateCartItemQty', 'simple');
+                expect(sidebar._hideItemButton).toHaveBeenCalledWith(elem);
+            });
+
+            it('Cart item doesn\'t exists', function () {
+                var elem = $('<input>').data('cart-item', 100);
+
+                spyOn(sidebar, '_hideItemButton');
+
+                sidebar._updateItemQtyAfter(elem);
+                expect(jQuery('body').trigger).not.toHaveBeenCalled();
+                expect(sidebar._hideItemButton).toHaveBeenCalledWith(elem);
+            });
+        });
+    });
+});