Skip to content

Commit bef5f53

Browse files
Merge pull request #4375 from magento-qwerty/MAGETWO-56445
Implemented Stories: - MAGETWO-56445: Eliminate @escapeNotVerified in Google-related Modules
2 parents ee6bc37 + 08c9032 commit bef5f53

File tree

2 files changed

+13
-18
lines changed
  • app/code/Magento
    • GoogleAdwords/view/frontend/templates
    • GoogleAnalytics/view/frontend/templates

2 files changed

+13
-18
lines changed

app/code/Magento/GoogleAdwords/view/frontend/templates/code.phtml

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,31 +3,29 @@
33
* Copyright © Magento, Inc. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
6-
7-
// @codingStandardsIgnoreFile
86
?>
97
<?php
108
/** @var $block \Magento\GoogleAdwords\Block\Code */
119
?>
1210
<!-- Google Code for Sale Conversion Page -->
1311
<script>
1412
/* <![CDATA[ */
15-
var google_conversion_id = <?= /* @escapeNotVerified */ $block->getHelper()->getConversionId() ?>;
16-
var google_conversion_language = "<?= /* @escapeNotVerified */ $block->getHelper()->getConversionLanguage() ?>";
17-
var google_conversion_format = "<?= /* @escapeNotVerified */ $block->getHelper()->getConversionFormat() ?>";
18-
var google_conversion_color = "<?= /* @escapeNotVerified */ $block->getHelper()->getConversionColor() ?>";
19-
var google_conversion_label = "<?= /* @escapeNotVerified */ $block->getHelper()->getConversionLabel() ?>";
20-
var google_conversion_value = <?= /* @escapeNotVerified */ $block->getHelper()->getConversionValue() ?>;
21-
<?php if($block->getHelper()->hasSendConversionValueCurrency() && $block->getHelper()->getConversionValueCurrency()): ?>
22-
var google_conversion_currency = "<?= /* @escapeNotVerified */ $block->getHelper()->getConversionValueCurrency() ?>";
13+
var google_conversion_id = <?= $block->escapeJs($block->getHelper()->getConversionId()) ?>;
14+
var google_conversion_language = "<?= $block->escapeJs($block->getHelper()->getConversionLanguage()) ?>";
15+
var google_conversion_format = "<?= $block->escapeJs($block->getHelper()->getConversionFormat()) ?>";
16+
var google_conversion_color = "<?= $block->escapeJs($block->getHelper()->getConversionColor()) ?>";
17+
var google_conversion_label = "<?= $block->escapeJs($block->getHelper()->getConversionLabel()) ?>";
18+
var google_conversion_value = <?= $block->escapeJs($block->getHelper()->getConversionValue()) ?>;
19+
<?php if ($block->getHelper()->hasSendConversionValueCurrency() && $block->getHelper()->getConversionValueCurrency()) : ?>
20+
var google_conversion_currency = "<?= $block->escapeJs($block->getHelper()->getConversionValueCurrency()) ?>";
2321
<?php endif; ?>
2422
/* ]]> */
2523
</script>
26-
<script src="<?= /* @escapeNotVerified */ $block->getHelper()->getConversionJsSrc() ?>"></script>
24+
<script src="<?= $block->escapeHtmlAttr($block->getHelper()->getConversionJsSrc()) ?>"></script>
2725
<noscript>
2826
<div style="display:inline;">
2927
<img height="1" width="1" style="border-style:none;" alt=""
30-
src="<?= /* @escapeNotVerified */ $block->getHelper()->getConversionImgSrc() ?>"/>
28+
src="<?= $block->escapeHtmlAttr($block->getHelper()->getConversionImgSrc()) ?>"/>
3129
</div>
3230
</noscript>
3331
<!-- END Google Code for Sale Conversion Page -->

app/code/Magento/GoogleAnalytics/view/frontend/templates/ga.phtml

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,6 @@
33
* Copyright © Magento, Inc. All rights reserved.
44
* See COPYING.txt for license details.
55
*/
6-
7-
// @codingStandardsIgnoreFile
8-
96
?>
107
<?php /** @var $block \Magento\GoogleAnalytics\Block\Ga */ ?>
118
<?php $accountId = $block->getConfig(\Magento\GoogleAnalytics\Helper\Data::XML_PATH_ACCOUNT) ?>
@@ -16,9 +13,9 @@
1613
"Magento_GoogleAnalytics/js/google-analytics": {
1714
"isCookieRestrictionModeEnabled": <?= (int)$block->isCookieRestrictionModeEnabled() ?>,
1815
"currentWebsite": <?= (int)$block->getCurrentWebsiteId() ?>,
19-
"cookieName": "<?= /* @escapeNotVerified */ \Magento\Cookie\Helper\Cookie::IS_USER_ALLOWED_SAVE_COOKIE ?>",
20-
"ordersTrackingData": <?= /* @escapeNotVerified */ json_encode($block->getOrdersTrackingData()) ?>,
21-
"pageTrackingData": <?= /* @escapeNotVerified */ json_encode($block->getPageTrackingData($accountId)) ?>
16+
"cookieName": "<?= /* @noEscape */ \Magento\Cookie\Helper\Cookie::IS_USER_ALLOWED_SAVE_COOKIE ?>",
17+
"ordersTrackingData": <?= /* @noEscape */ json_encode($block->getOrdersTrackingData()) ?>,
18+
"pageTrackingData": <?= /* @noEscape */ json_encode($block->getPageTrackingData($accountId)) ?>
2219
}
2320
}
2421
}

0 commit comments

Comments
 (0)