Skip to content

Commit be523ca

Browse files
lbajsarowiczlbajsarowicz
committed
FIX: Add missing Stories and Severity to Test cases
1 parent 02bca98 commit be523ca

12 files changed

+69
-50
lines changed

‎app/code/Magento/Backend/Test/Mftf/Test/AdminDashboardWithChartsChart.xml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,16 @@
1111
<test name="AdminDashboardWithChartsTest">
1212
<annotations>
1313
<features value="Backend"/>
14-
<title value="Google chart on Magento dashboard"/>
15-
<description value="Google chart on Magento dashboard page is not broken"/>
14+
<stories value="Google Charts on Magento dashboard"/>
15+
<title value="Admin should see Google chart on Magento dashboard"/>
16+
<description value="Google chart on Magento dashboard page is displaying properly"/>
1617
<severity value="MAJOR"/>
1718
<testCaseId value="MAGETWO-98934"/>
1819
<useCaseId value="MAGETWO-98584"/>
1920
<group value="backend"/>
2021
</annotations>
2122
<before>
22-
<magentoCLI command="config:set admin/dashboard/enable_charts 1" stepKey="setEnableCharts" />
23+
<magentoCLI command="config:set admin/dashboard/enable_charts 1" stepKey="setEnableCharts"/>
2324
<createData entity="SimpleProduct2" stepKey="createProduct">
2425
<field key="price">150</field>
2526
</createData>
@@ -33,7 +34,7 @@
3334
<comment userInput="Reset admin order filter" stepKey="resetAdminOrderFilter"/>
3435
<actionGroup ref="AdminOrdersGridClearFiltersActionGroup" stepKey="clearOrderFilters"/>
3536
<waitForLoadingMaskToDisappear stepKey="waitForLoadingOrderGrid"/>
36-
<magentoCLI command="config:set admin/dashboard/enable_charts 0" stepKey="setDisableChartsAsDefault" />
37+
<magentoCLI command="config:set admin/dashboard/enable_charts 0" stepKey="setDisableChartsAsDefault"/>
3738
<deleteData createDataKey="createProduct" stepKey="deleteProduct"/>
3839
<deleteData createDataKey="createCustomer" stepKey="deleteCustomer"/>
3940
<actionGroup ref="logout" stepKey="logout"/>
@@ -47,7 +48,7 @@
4748
<!-- Login as customer -->
4849
<comment userInput="Login as customer" stepKey="loginAsCustomer"/>
4950
<actionGroup ref="LoginToStorefrontActionGroup" stepKey="customerLogin">
50-
<argument name="Customer" value="$$createCustomer$$" />
51+
<argument name="Customer" value="$$createCustomer$$"/>
5152
</actionGroup>
5253
<!-- Add Product to Shopping Cart-->
5354
<comment userInput="Add product to the shopping cart" stepKey="addProductToCart"/>

‎app/code/Magento/Backend/Test/Mftf/Test/AdminLoginAfterJSMinificationTest.xml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,15 @@
77
-->
88

99
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
10-
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
10+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
1111
<test name="AdminLoginAfterJSMinificationTest">
1212
<annotations>
1313
<features value="Backend"/>
14+
<stories value="Admin Panel JS minification"/>
1415
<title value="Admin panel should be accessible with JS minification enabled"/>
1516
<description value="Admin panel should be accessible with JS minification enabled"/>
16-
<testCaseId value="MC-14104" />
17+
<testCaseId value="MC-14104"/>
18+
<severity value="MAJOR"/>
1719
<group value="backend"/>
1820
<group value="mtf_migrated"/>
1921
</annotations>

‎app/code/Magento/Backend/Test/Mftf/Test/AdminUserLoginWithStoreCodeInUrlTest.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,11 @@
1111
<test name="AdminUserLoginWithStoreCodeInUrlTest">
1212
<annotations>
1313
<features value="Backend"/>
14+
<stories value="Admin Panel URL with Store Code"/>
1415
<title value="Admin panel should be accessible with Add Store Code to URL setting enabled"/>
1516
<description value="Admin panel should be accessible with Add Store Code to URL setting enabled"/>
16-
<testCaseId value="MC-14279" />
17+
<testCaseId value="MC-14279"/>
18+
<severity value="CRITICAL"/>
1719
<group value="backend"/>
1820
<group value="mtf_migrated"/>
1921
</annotations>

‎app/code/Magento/Catalog/Test/Mftf/Test/AddOutOfStockProductToCompareListTest.xml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,9 @@
1111
<test name="AddOutOfStockProductToCompareListTest">
1212
<annotations>
1313
<features value="Catalog"/>
14-
<title value="Add out of stock product to compare list"/>
15-
<description value="Add out of stock product to compare list"/>
14+
<stories value="Product Comparison for products Out of Stock"/>
15+
<title value="Add Product that is Out of Stock product to Product Comparison"/>
16+
<description value="Customer should be able to add Product that is Out Of Stock to the Product Comparison"/>
1617
<severity value="MAJOR"/>
1718
<testCaseId value="MAGETWO-98644"/>
1819
<useCaseId value="MAGETWO-98522"/>
@@ -58,15 +59,15 @@
5859
<waitForPageLoad stepKey="waitForProdAddToCmpList"/>
5960
<!--Assert success message-->
6061
<comment userInput="Assert success message" stepKey="assertSuccessMsg"/>
61-
<grabTextFrom selector="{{AdminProductMessagesSection.successMessage}}" stepKey="grabTextFromSuccessMessage"/>
62+
<grabTextFrom selector="{{AdminProductMessagesSection.successMessage}}" stepKey="grabTextFromSuccessMessage"/>
6263
<assertEquals expected='You added product $$product.name$$ to the comparison list.' expectedType="string" actual="($grabTextFromSuccessMessage)" stepKey="assertSuccessMessage"/>
6364
<!--See product in the comparison list-->
6465
<comment userInput="See product in the comparison list" stepKey="seeProductInComparisonList"/>
6566
<amOnPage url="{{StorefrontProductComparePage.url}}" stepKey="navigateToComparePage"/>
6667
<waitForPageLoad stepKey="waitForStorefrontProductComparePageLoad"/>
6768
<seeElement selector="{{StorefrontProductCompareMainSection.ProductLinkByName($product.name$)}}" stepKey="seeProductInCompareList"/>
6869
<!--Go to Category page and delete product from comparison list-->
69-
<comment userInput="Go to Category page and delete prduct from comparison list" stepKey="deletProdFromCmpList"/>
70+
<comment userInput="Go to Category page and delete product from comparison list" stepKey="deleteProdFromCmpList"/>
7071
<amOnPage url="{{StorefrontCategoryPage.url($$category.name$$)}}" stepKey="onCategoryPage"/>
7172
<waitForPageLoad time="30" stepKey="waitForPageLoad1"/>
7273
<click selector="{{StorefrontComparisonSidebarSection.ClearAll}}" stepKey="clickClearAll"/>
@@ -80,7 +81,7 @@
8081
<waitForPageLoad stepKey="waitProdAddingToCmpList"/>
8182
<!--Assert success message-->
8283
<comment userInput="Assert success message" stepKey="assertSuccessMsg2"/>
83-
<grabTextFrom selector="{{AdminProductMessagesSection.successMessage}}" stepKey="grabTextFromSuccessMessage2"/>
84+
<grabTextFrom selector="{{AdminProductMessagesSection.successMessage}}" stepKey="grabTextFromSuccessMessage2"/>
8485
<assertEquals expected='You added product $$product.name$$ to the comparison list.' expectedType="string" actual="($grabTextFromSuccessMessage)" stepKey="assertSuccessMessage2"/>
8586
<!--Check that product displays on add to compare widget-->
8687
<comment userInput="Check that product displays on add to compare widget" stepKey="checkProdNameOnWidget"/>

‎app/code/Magento/Checkout/Test/Mftf/Test/StorefrontValidateEmailOnCheckoutTest.xml

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,12 @@
1111
<test name="StorefrontValidateEmailOnCheckoutTest">
1212
<annotations>
1313
<features value="Checkout"/>
14-
<title value="Email validation for Guest on checkout flow"/>
15-
<description value="Email validation for Guest on checkout flow"/>
14+
<stories value="Guest Checkout e-mail validation"/>
15+
<title value="Guest e-mail address validation on Checkout process"/>
16+
<description value="Guest should not be able to place an order when invalid e-mail address provided"/>
1617
<stories value="Guest Checkout"/>
17-
<testCaseId value="MC-14695" />
18+
<testCaseId value="MC-14695"/>
19+
<severity value="CRITICAL"/>
1820
<group value="checkout"/>
1921
<group value="shoppingCart"/>
2022
<group value="mtf_migrated"/>
@@ -28,27 +30,27 @@
2830
</after>
2931

3032
<actionGroup ref="StorefrontOpenProductPageActionGroup" stepKey="openProductStorefront">
31-
<argument name="productUrl" value="$$simpleProduct.custom_attributes[url_key]$$" />
33+
<argument name="productUrl" value="$$simpleProduct.custom_attributes[url_key]$$"/>
3234
</actionGroup>
33-
<actionGroup ref="StorefrontClickAddToCartOnProductPageActionGroup" stepKey="addToCartFromStorefrontProductPage" />
35+
<actionGroup ref="StorefrontClickAddToCartOnProductPageActionGroup" stepKey="addToCartFromStorefrontProductPage"/>
3436

35-
<actionGroup ref="StorefrontOpenCheckoutPageActionGroup" stepKey="openCheckoutPage" />
36-
<actionGroup ref="AssertStorefrontEmailTooltipContentOnCheckoutActionGroup" stepKey="assertEmailTooltipContent" />
37-
<actionGroup ref="AssertStorefrontEmailNoteMessageOnCheckoutActionGroup" stepKey="assertEmailNoteMessage" />
37+
<actionGroup ref="StorefrontOpenCheckoutPageActionGroup" stepKey="openCheckoutPage"/>
38+
<actionGroup ref="AssertStorefrontEmailTooltipContentOnCheckoutActionGroup" stepKey="assertEmailTooltipContent"/>
39+
<actionGroup ref="AssertStorefrontEmailNoteMessageOnCheckoutActionGroup" stepKey="assertEmailNoteMessage"/>
3840

3941
<actionGroup ref="StorefrontFillEmailFieldOnCheckoutActionGroup" stepKey="fillIncorrectEmailFirstAttempt">
40-
<argument name="email" value="John" />
42+
<argument name="email" value="John"/>
4143
</actionGroup>
42-
<actionGroup ref="AssertStorefrontEmailValidationMessageOnCheckoutActionGroup" stepKey="verifyValidationErrorMessageFirstAttempt" />
44+
<actionGroup ref="AssertStorefrontEmailValidationMessageOnCheckoutActionGroup" stepKey="verifyValidationErrorMessageFirstAttempt"/>
4345

4446
<actionGroup ref="StorefrontFillEmailFieldOnCheckoutActionGroup" stepKey="fillIncorrectEmailSecondAttempt">
45-
<argument name="email" value="johndoe#example.com" />
47+
<argument name="email" value="johndoe#example.com"/>
4648
</actionGroup>
47-
<actionGroup ref="AssertStorefrontEmailValidationMessageOnCheckoutActionGroup" stepKey="verifyValidationErrorMessageSecondAttempt" />
49+
<actionGroup ref="AssertStorefrontEmailValidationMessageOnCheckoutActionGroup" stepKey="verifyValidationErrorMessageSecondAttempt"/>
4850

4951
<actionGroup ref="StorefrontFillEmailFieldOnCheckoutActionGroup" stepKey="fillIncorrectEmailThirdAttempt">
50-
<argument name="email" value="johndoe@example.c" />
52+
<argument name="email" value="johndoe@example.c"/>
5153
</actionGroup>
52-
<actionGroup ref="AssertStorefrontEmailValidationMessageOnCheckoutActionGroup" stepKey="verifyValidationErrorMessageThirdAttempt" />
54+
<actionGroup ref="AssertStorefrontEmailValidationMessageOnCheckoutActionGroup" stepKey="verifyValidationErrorMessageThirdAttempt"/>
5355
</test>
5456
</tests>

‎app/code/Magento/Customer/Test/Mftf/Test/AllowedCountriesRestrictionApplyOnBackendTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@
99
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
1010
<test name="AllowedCountriesRestrictionApplyOnBackendTest">
1111
<annotations>
12+
<features value="Customer"/>
1213
<stories value="Country filter"/>
1314
<title value="Country filter on Customers page when allowed countries restriction for a default website is applied"/>
1415
<description value="Country filter on Customers page when allowed countries restriction for a default website is applied"/>
15-
<features value="Customer"/>
1616
<severity value="MAJOR"/>
1717
<testCaseId value="MC-6441"/>
1818
<useCaseId value="MAGETWO-91523"/>

‎app/code/Magento/Customer/Test/Mftf/Test/DeleteCustomerGroupTest.xml

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,20 @@
1010
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
1111
<test name="DeleteCustomerGroupTest">
1212
<annotations>
13-
<title value="Delete customer group entity test"/>
14-
<description value="Delete a customer group"/>
13+
<features value="Customer"/>
1514
<stories value="Delete Customer Group"/>
16-
<testCaseId value="MC-14590" />
15+
<title value="Delete Customer Group in Admin Panel"/>
16+
<description value="Admin should be able to delete a Customer Group"/>
17+
<testCaseId value="MC-14590"/>
18+
<severity value="MAJOR"/>
1719
<group value="customers"/>
1820
<group value="mtf_migrated"/>
1921
</annotations>
2022

2123
<before>
22-
<createData entity="CustomCustomerGroup" stepKey="customerGroup" />
24+
<createData entity="CustomCustomerGroup" stepKey="customerGroup"/>
2325
<createData entity="UsCustomerAssignedToNewCustomerGroup" stepKey="customer">
24-
<requiredEntity createDataKey="customerGroup" />
26+
<requiredEntity createDataKey="customerGroup"/>
2527
</createData>
2628
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin"/>
2729
</before>
@@ -35,21 +37,21 @@
3537
<argument name="customerGroupName" value="$$customerGroup.code$$"/>
3638
</actionGroup>
3739
<actionGroup ref="AssertCustomerGroupNotInGridActionGroup" stepKey="assertCustomerGroupNotInGrid">
38-
<argument name="customerGroup" value="$$customerGroup$$" />
40+
<argument name="customerGroup" value="$$customerGroup$$"/>
3941
</actionGroup>
4042

4143
<actionGroup ref="AdminOpenCustomerEditPageActionGroup" stepKey="openCustomerEditPage">
42-
<argument name="customerId" value="$$customer.id$$" />
44+
<argument name="customerId" value="$$customer.id$$"/>
4345
</actionGroup>
4446

4547
<actionGroup ref="AssertCustomerGroupOnCustomerFormActionGroup" stepKey="assertCustomerGroupOnCustomerForm">
46-
<argument name="customerGroup" value="GeneralCustomerGroup" />
48+
<argument name="customerGroup" value="GeneralCustomerGroup"/>
4749
</actionGroup>
48-
49-
<actionGroup ref="AdminOpenNewProductFormPageActionGroup" stepKey="openNewProductForm" />
50-
50+
51+
<actionGroup ref="AdminOpenNewProductFormPageActionGroup" stepKey="openNewProductForm"/>
52+
5153
<actionGroup ref="AssertCustomerGroupNotOnProductFormActionGroup" stepKey="assertCustomerGroupNotOnProductForm">
52-
<argument name="customerGroup" value="$$customerGroup$$" />
54+
<argument name="customerGroup" value="$$customerGroup$$"/>
5355
</actionGroup>
5456
</test>
5557
</tests>

‎app/code/Magento/Customer/Test/Mftf/Test/StorefrontCreateExistingCustomerTest.xml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,15 @@
77
-->
88

99
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
10-
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
10+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
1111
<test name="StorefrontCreateExistingCustomerTest">
1212
<annotations>
1313
<features value="Customer"/>
14+
<stories value="Customer Registration"/>
1415
<title value="Attempt to register customer on storefront with existing email"/>
1516
<description value="Attempt to register customer on storefront with existing email"/>
16-
<testCaseId value="MC-10907" />
17+
<testCaseId value="MC-10907"/>
18+
<severity value="MAJOR"/>
1719
<group value="customers"/>
1820
<group value="mtf_migrated"/>
1921
</annotations>

‎app/code/Magento/Customer/Test/Mftf/Test/StorefrontLockCustomerOnLoginPageTest.xml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,15 @@
77
-->
88

99
<tests xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
10-
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
10+
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/testSchema.xsd">
1111
<test name="StorefrontLockCustomerOnLoginPageTest">
1212
<annotations>
1313
<features value="Customer"/>
14+
<stories value="Lock Customer entering incorrect login credentials"/>
1415
<title value="Lock customer on Storefront with after many attempts to log in with incorrect credentials"/>
1516
<description value="Lock customer on Storefront with after many attempts to log in with incorrect credentials"/>
16-
<testCaseId value="MC-14388" />
17+
<testCaseId value="MC-14388"/>
18+
<severity value="CRITICAL"/>
1719
<group value="customer"/>
1820
<group value="security"/>
1921
<group value="mtf_migrated"/>
@@ -26,10 +28,10 @@
2628
<after>
2729
<magentoCLI command="config:set {{StorefrontCustomerCaptchaEnableConfigData.path}} {{StorefrontCustomerCaptchaEnableConfigData.value}}" stepKey="enableCaptcha"/>
2830
<magentoCLI command="config:set {{StorefrontCustomerLockoutFailuresDefaultConfigData.path}} {{StorefrontCustomerLockoutFailuresDefaultConfigData.value}}" stepKey="revertInvalidAttemptsCountConfig"/>
29-
<deleteData stepKey="deleteCustomer" createDataKey="customer" />
31+
<deleteData stepKey="deleteCustomer" createDataKey="customer"/>
3032
</after>
3133

32-
<actionGroup ref="StorefrontOpenCustomerLoginPageActionGroup" stepKey="goToSignInPage" />
34+
<actionGroup ref="StorefrontOpenCustomerLoginPageActionGroup" stepKey="goToSignInPage"/>
3335

3436
<!-- Perform 5 attempts to log in with invalid credentials -->
3537
<actionGroup ref="StorefrontFillCustomerLoginFormWithWrongPasswordActionGroup" stepKey="fillLoginFormFirstAttempt">

‎app/code/Magento/Store/Test/Mftf/Test/StorefrontAddStoreCodeInUrlTest.xml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,11 @@
1111
<test name="StorefrontAddStoreCodeInUrlTest">
1212
<annotations>
1313
<features value="Backend"/>
14+
<stories value="Admin Panel URL with Store Code"/>
1415
<title value="Store code should be added to storefront URL if the corresponding configuration is enabled"/>
1516
<description value="Store code should be added to storefront URL if the corresponding configuration is enabled"/>
16-
<testCaseId value="MC-15944" />
17+
<testCaseId value="MC-15944"/>
18+
<severity value="CRITICAL"/>
1719
<group value="store"/>
1820
<group value="mtf_migrated"/>
1921
</annotations>

0 commit comments

Comments
 (0)