Skip to content

Commit bde58b9

Browse files
committed
Use '===' operator to check if file was written.
This prevents incorrect logic when writing empty string (0 bytes).
1 parent 2268edc commit bde58b9

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

lib/internal/Magento/Framework/Filesystem/Driver/File.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -552,7 +552,7 @@ public function touch($path, $modificationTime = null)
552552
public function filePutContents($path, $content, $mode = null)
553553
{
554554
$result = @file_put_contents($this->getScheme() . $path, $content, $mode);
555-
if (!$result) {
555+
if ($result === false) {
556556
throw new FileSystemException(
557557
new \Magento\Framework\Phrase(
558558
'The specified "%1" file couldn\'t be written. %2',

lib/internal/Magento/Framework/Filesystem/Driver/Http.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ public function fileGetContents($path, $flags = null, $context = null)
109109
public function filePutContents($path, $content, $mode = null, $context = null)
110110
{
111111
$result = @file_put_contents($this->getScheme() . $path, $content, $mode, $context);
112-
if (!$result) {
112+
if ($result === false) {
113113
throw new FileSystemException(
114114
new \Magento\Framework\Phrase(
115115
'The specified "%1" file couldn\'t be written. %2',

lib/internal/Magento/Framework/Filesystem/Io/File.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -479,7 +479,7 @@ public function write($filename, $src, $mode = null)
479479
} else {
480480
$result = @file_put_contents($filename, $src);
481481
}
482-
if ($mode !== null && $result) {
482+
if ($mode !== null && $result !== false) {
483483
@chmod($filename, $mode);
484484
}
485485
$this->_iwd();

0 commit comments

Comments
 (0)