MAGETWO-94349: The "recursion detected" error during a deployment

shiftedreality · shiftedreality · commit bde45ec30948 · 2018-08-28T11:55:30.000-05:00
diff --git a/app/code/Magento/Config/App/Config/Type/System.php b/app/code/Magento/Config/App/Config/Type/System.php
@@ -155,7 +155,11 @@ public function get($path = '')
         }
         $scopeId = array_shift($pathParts);
         if (!isset($this->data[$scopeType][$scopeId])) {
-            $this->data = array_replace_recursive($this->loadScopeData($scopeType, $scopeId), $this->data);
+            $scopeData = $this->loadScopeData($scopeType, $scopeId);
+            /* Starting from 2.2.0 $this->data can be already loaded with $this->loadScopeData  */
+            if (!isset($this->data[$scopeType][$scopeId])) {
+                $this->data = array_replace_recursive($scopeData, $this->data);
+            }
         }
         return isset($this->data[$scopeType][$scopeId])
             ? $this->getDataByPathParts($this->data[$scopeType][$scopeId], $pathParts)

Original file line number	Diff line number	Diff line change
`@@ -155,7 +155,11 @@ public function get($path = '')`
`155`	`155`	`}`
`156`	`156`	`$scopeId = array_shift($pathParts);`
`157`	`157`	`if (!isset($this->data[$scopeType][$scopeId])) {`
`158`		`- $this->data = array_replace_recursive($this->loadScopeData($scopeType, $scopeId), $this->data);`
	`158`	`+ $scopeData = $this->loadScopeData($scopeType, $scopeId);`
	`159`	`+ /* Starting from 2.2.0 $this->data can be already loaded with $this->loadScopeData */`
	`160`	`+ if (!isset($this->data[$scopeType][$scopeId])) {`
	`161`	`+ $this->data = array_replace_recursive($scopeData, $this->data);`
	`162`	`+ }`
`159`	`163`	`}`
`160`	`164`	`return isset($this->data[$scopeType][$scopeId])`
`161`	`165`	`? $this->getDataByPathParts($this->data[$scopeType][$scopeId], $pathParts)`