Skip to content

Commit bdbf4e0

Browse files
committed
No update must be a boolean, int given
fixes #39344 When adding or removing sample data you can tell the composer update command to not invoke the update command right away. Since newer versions type checking is set for this argument and it must be of type boolean instead of a integer.
1 parent 6acfd6a commit bdbf4e0

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

app/code/Magento/SampleData/Console/Command/SampleDataDeployCommand.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ protected function execute(InputInterface $input, OutputInterface $output): int
9191
$baseDir = $this->filesystem->getDirectoryRead(DirectoryList::ROOT)->getAbsolutePath();
9292
$commonArgs = ['--working-dir' => $baseDir, '--no-progress' => 1];
9393
if ($input->getOption(self::OPTION_NO_UPDATE)) {
94-
$commonArgs['--no-update'] = 1;
94+
$commonArgs['--no-update'] = true;
9595
}
9696
$packages = [];
9797
foreach ($sampleDataPackages as $name => $version) {

app/code/Magento/SampleData/Console/Command/SampleDataRemoveCommand.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
9292
$baseDir = $this->filesystem->getDirectoryRead(DirectoryList::ROOT)->getAbsolutePath();
9393
$commonArgs = ['--working-dir' => $baseDir, '--no-interaction' => 1, '--no-progress' => 1];
9494
if ($input->getOption(self::OPTION_NO_UPDATE)) {
95-
$commonArgs['--no-update'] = 1;
95+
$commonArgs['--no-update'] = true;
9696
}
9797
$packages = array_keys($sampleDataPackages);
9898
$arguments = array_merge(['command' => 'remove', 'packages' => $packages], $commonArgs);

0 commit comments

Comments
 (0)