Skip to content

Commit bd8920d

Browse files
committed
ACP2E-2494: Performance issue when loading product attributes in cart rules
- implemented CR
1 parent d828632 commit bd8920d

File tree

2 files changed

+1
-2
lines changed
  • app/code/Magento/SalesRule/Model/ResourceModel
  • dev/tests/integration/testsuite/Magento/SalesRule/Model/ResourceModel

2 files changed

+1
-2
lines changed

app/code/Magento/SalesRule/Model/ResourceModel/Rule.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ public function getActiveAttributes()
311311
->group('attribute_id');
312312
$select = $connection->select()->from(
313313
['a' => $subSelect],
314-
new \Zend_Db_Expr('DISTINCT ea.attribute_code')
314+
new \Zend_Db_Expr('ea.attribute_code')
315315
)->joinInner(
316316
['ea' => $this->getTable('eav_attribute')],
317317
'ea.attribute_id = a.attribute_id',

dev/tests/integration/testsuite/Magento/SalesRule/Model/ResourceModel/RuleTest.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ public function testAfterSave()
7272
public function testGetActiveAttributes()
7373
{
7474
$rule = $this->fixtures->get('rule1');
75-
$items = $this->resource->getActiveAttributes();
7675
$rule->setIsActive(1);
7776
$rule->save();
7877
$items = $this->resource->getActiveAttributes();

0 commit comments

Comments
 (0)