MAGETWO-87025: Generate SCD in Production mode

Author: Bohdan Korablov

lib/internal/Magento/Framework/App/StaticResource.php

@@ -8,6 +8,7 @@
 use Magento\Framework\App\Filesystem\DirectoryList;
 use Magento\Framework\ObjectManager\ConfigLoaderInterface;
 use Magento\Framework\Filesystem;
+use Magento\Framework\Config\ConfigOptionsListConstants;
 use Psr\Log\LoggerInterface;
 
 /**
@@ -117,7 +118,9 @@ public function launch()
         \Magento\Framework\Profiler::reset();
         $appMode = $this->state->getMode();
         if ($appMode == \Magento\Framework\App\State::MODE_PRODUCTION
-            && !$this->deploymentConfig->getConfigData('static_content_on_demand_in_production')
+            && !$this->deploymentConfig->getConfigData(
+                ConfigOptionsListConstants::CONFIG_PATH_SCD_ON_DEMAND_IN_PRODUCTION
+            )
         ) {
             $this->response->setHttpResponseCode(404);
         } else {

lib/internal/Magento/Framework/App/Test/Unit/StaticResourceTest.php

@@ -17,6 +17,7 @@
 use Magento\Framework\ObjectManagerInterface;
 use Magento\Framework\App\ObjectManager\ConfigLoader;
 use Magento\Framework\App\StaticResource;
+use Magento\Framework\Config\ConfigOptionsListConstants;
 use Psr\Log\LoggerInterface;
 use PHPUnit_Framework_MockObject_MockObject as MockObject;
 
@@ -152,7 +153,7 @@ public function testLaunch(
     ) {
         $this->deploymentConfigMock->expects($this->exactly($getConfigDataExpects))
             ->method('getConfigData')
-            ->with('static_content_on_demand_in_production')
+            ->with(ConfigOptionsListConstants::CONFIG_PATH_SCD_ON_DEMAND_IN_PRODUCTION)
             ->willReturn($staticContentOmDemandInProduction);
         $this->stateMock->expects($this->once())
             ->method('getMode')

lib/internal/Magento/Framework/App/Test/Unit/View/Deployment/VersionTest.php

@@ -10,6 +10,7 @@
 use Magento\Framework\App\State;
 use Magento\Framework\App\View\Deployment\Version\StorageInterface;
 use Psr\Log\LoggerInterface;
+use Magento\Framework\Config\ConfigOptionsListConstants;
 use PHPUnit_Framework_MockObject_MockObject as MockObject;
 
 /**
@@ -109,7 +110,7 @@ public function testGetValueWithProductionModeAndException()
             ->willReturn(State::MODE_PRODUCTION);
         $this->deploymentConfigMock->expects($this->once())
             ->method('getConfigData')
-            ->with('static_content_on_demand_in_production')
+            ->with(ConfigOptionsListConstants::CONFIG_PATH_SCD_ON_DEMAND_IN_PRODUCTION)
             ->willReturn(0);
         $this->loggerMock->expects($this->once())
             ->method('critical')
@@ -142,7 +143,7 @@ public function testGetValueWithProductionModeAndEnabledSCDonDemand()
             ->willReturn(State::MODE_PRODUCTION);
         $this->deploymentConfigMock->expects($this->once())
             ->method('getConfigData')
-            ->with('static_content_on_demand_in_production')
+            ->with(ConfigOptionsListConstants::CONFIG_PATH_SCD_ON_DEMAND_IN_PRODUCTION)
             ->willReturn(1);
         $this->versionStorageMock->expects($this->once())
             ->method('save');

lib/internal/Magento/Framework/App/View/Deployment/Version.php

@@ -8,6 +8,7 @@
 
 use Magento\Framework\App\DeploymentConfig;
 use Magento\Framework\App\ObjectManager;
+use Magento\Framework\Config\ConfigOptionsListConstants;
 use Psr\Log\LoggerInterface;
 
 /**
@@ -79,7 +80,9 @@ protected function readValue($appMode)
         $result = $this->versionStorage->load();
         if (!$result) {
             if ($appMode == \Magento\Framework\App\State::MODE_PRODUCTION
-                && !$this->deploymentConfig->getConfigData('static_content_on_demand_in_production')
+                && !$this->deploymentConfig->getConfigData(
+                    ConfigOptionsListConstants::CONFIG_PATH_SCD_ON_DEMAND_IN_PRODUCTION
+                )
             ) {
                 $this->getLogger()->critical('Can not load static content version.');
                 throw new \UnexpectedValueException(

lib/internal/Magento/Framework/Config/ConfigOptionsListConstants.php

@@ -36,6 +36,7 @@ class ConfigOptionsListConstants
     const CONFIG_PATH_DB_LOGGER_LOG_EVERYTHING = 'db_logger/log_everything';
     const CONFIG_PATH_DB_LOGGER_QUERY_TIME_THRESHOLD = 'db_logger/query_time_threshold';
     const CONFIG_PATH_DB_LOGGER_INCLUDE_STACKTRACE = 'db_logger/include_stacktrace';
+    const CONFIG_PATH_SCD_ON_DEMAND_IN_PRODUCTION = 'static_content_on_demand_in_production';
     /**#@-*/
 
     /**#@+