MC-21630: Controller behavior minor changes

Author: SeruyV

app/code/Magento/ImportExport/Test/Unit/Controller/Adminhtml/Export/File/DownloadTest.php

@@ -91,7 +91,7 @@ protected function setUp()
      *
      * @return void
      */
-    public function testDownload()
+    public function testExecute(): void
     {
         $fileName = 'customer.csv';
         $path = 'export/' . $fileName;
@@ -102,48 +102,34 @@ public function testDownload()
         $response = $this->createMock(ResponseInterface::class);
         $this->fileFactoryMock->expects($this->once())
             ->method('create')
-            ->with($path, $fileContent, DirectoryList::VAR_DIR)->willReturn($response);
+            ->with($path, $fileContent, DirectoryList::VAR_DIR)
+            ->willReturn($response);
 
         $this->controller->execute();
     }
 
     /**
      * Check behavior with incorrect filename.
      *
-     * @param string $fileName
-     * @dataProvider fileNameDataProvider
      * @expectedException \Magento\Framework\Exception\LocalizedException
      * @expectedExceptionMessage Please provide valid export file name
      * @return void
      */
-    public function testDownloadWithIncorrectFilename(string $fileName)
+    public function testExecuteWithEmptyFileName(): void
     {
-        $this->requestMock->expects($this->once())->method('getParam')->with('filename')->willReturn($fileName);
+        $this->requestMock->expects($this->once())->method('getParam')->with('filename')->willReturn('');
 
         $this->controller->execute();
     }
 
-    /**
-     * Data provider for testDownloadWithIncorrectFilename.
-     *
-     * @return array
-     */
-    public function fileNameDataProvider(): array
-    {
-        return [
-            'Empty parameter' => [''],
-            'Incorrect Name' => ['../customer.csv'],
-        ];
-    }
-
     /**
      * Check behavior when method throw exception.
      *
      * @expectedException \Magento\Framework\Exception\LocalizedException
-     * @expectedExceptionMessage There are no export file with such name
+     * @expectedExceptionMessage There are no export file with such name customer.csv
      * @return void
      */
-    public function testDownloadWithException()
+    public function testExecuteWithNonExistanceFile(): void
     {
         $fileName = 'customer.csv';
         $path = 'export/' . $fileName;
@@ -164,7 +150,7 @@ public function testDownloadWithException()
      * @param string $path
      * @return void
      */
-    private function processDownloadAction(string $fileName, string $path)
+    private function processDownloadAction(string $fileName, string $path): void
     {
         $this->requestMock->expects($this->once())->method('getParam')->with('filename')->willReturn($fileName);
         $this->fileSystemMock->expects($this->once())