Skip to content

Commit bce263f

Browse files
committed
MC-37117: Unexpected loading of the "New Review" page in the Admin-panel
1 parent 849b6f0 commit bce263f

File tree

2 files changed

+16
-8
lines changed

2 files changed

+16
-8
lines changed

app/code/Magento/Review/Block/Adminhtml/Add.php

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,10 @@ protected function _construct()
2727
$this->_mode = 'add';
2828
$this->buttonList->update('save', 'label', __('Save Review'));
2929
$this->buttonList->update('save', 'id', 'save_button');
30+
$this->buttonList->update('save', 'style', 'display: none;');
3031
$this->buttonList->update('reset', 'id', 'reset_button');
32+
$this->buttonList->update('reset', 'style', 'display: none;');
3133
$this->buttonList->update('reset', 'onclick', 'window.review.formReset()');
32-
$this->_formScripts[] = '
33-
require(["prototype"], function(){
34-
toggleParentVis("add_review_form");
35-
toggleVis("save_button");
36-
toggleVis("reset_button");
37-
});
38-
';
3934
// @codingStandardsIgnoreStart
4035
$this->_formInitScripts[] = '
4136
require(["jquery","Magento_Review/js/rating","prototype"], function(jQuery, rating){

app/code/Magento/Review/Block/Adminhtml/Add/Form.php

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55
*/
66
namespace Magento\Review\Block\Adminhtml\Add;
77

8+
use Magento\Framework\App\ObjectManager;
9+
use Magento\Framework\View\Helper\SecureHtmlRenderer;
10+
811
/**
912
* Adminhtml add product review form
1013
*
@@ -26,24 +29,32 @@ class Form extends \Magento\Backend\Block\Widget\Form\Generic
2629
*/
2730
protected $_systemStore;
2831

32+
/**
33+
* @var SecureHtmlRenderer
34+
*/
35+
private $secureRenderer;
36+
2937
/**
3038
* @param \Magento\Backend\Block\Template\Context $context
3139
* @param \Magento\Framework\Registry $registry
3240
* @param \Magento\Framework\Data\FormFactory $formFactory
3341
* @param \Magento\Store\Model\System\Store $systemStore
3442
* @param \Magento\Review\Helper\Data $reviewData
3543
* @param array $data
44+
* @param SecureHtmlRenderer|null $htmlRenderer
3645
*/
3746
public function __construct(
3847
\Magento\Backend\Block\Template\Context $context,
3948
\Magento\Framework\Registry $registry,
4049
\Magento\Framework\Data\FormFactory $formFactory,
4150
\Magento\Store\Model\System\Store $systemStore,
4251
\Magento\Review\Helper\Data $reviewData,
43-
array $data = []
52+
array $data = [],
53+
?SecureHtmlRenderer $htmlRenderer = null
4454
) {
4555
$this->_reviewData = $reviewData;
4656
$this->_systemStore = $systemStore;
57+
$this->secureRenderer = $htmlRenderer ?: ObjectManager::getInstance()->get(SecureHtmlRenderer::class);
4758
parent::__construct($context, $registry, $formFactory, $data);
4859
}
4960

@@ -59,6 +70,8 @@ protected function _prepareForm()
5970
$form = $this->_formFactory->create();
6071

6172
$fieldset = $form->addFieldset('add_review_form', ['legend' => __('Review Details')]);
73+
$beforeHtml = $this->secureRenderer->renderStyleAsTag('display: none;', '#edit_form');
74+
$fieldset->setBeforeElementHtml($beforeHtml);
6275

6376
$fieldset->addField('product_name', 'note', ['label' => __('Product'), 'text' => 'product_name']);
6477

0 commit comments

Comments
 (0)