Skip to content

Commit bc9980e

Browse files
author
Evgeniy Kolesov
committed
Merge remote-tracking branch 'vanilla/PR' into PR-1
2 parents 1f94292 + 4b4f268 commit bc9980e

File tree

8 files changed

+23
-13
lines changed

8 files changed

+23
-13
lines changed

app/code/Magento/Catalog/view/adminhtml/web/js/options.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,10 @@ define([
4141
if (!data.intype) {
4242
data.intype = optionDefaultInputType;
4343
}
44+
45+
if (!this.totalItems) {
46+
data.checked = 'checked';
47+
}
4448
element = this.template({
4549
data: data
4650
});

app/code/Magento/ProductVideo/view/frontend/web/js/fotorama-add-video-events.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -506,7 +506,7 @@ define([
506506
var self = this;
507507

508508
$image.find('.magnify-lens').remove();
509-
$image.on('click', function () {
509+
$image.on('click tap', function () {
510510
if ($(this).hasClass('video-unplayed') && $(this).find('iframe').length === 0) {
511511
$('.fotorama__arr--next').hide();
512512
$('.fotorama__arr--prev').hide();

app/code/Magento/Swatches/view/adminhtml/web/js/text.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,9 @@ define([
4040
data.intype = swatchOptionTextDefaultInputType;
4141
}
4242

43+
if (!this.totalItems) {
44+
data.checked = 'checked';
45+
}
4346
element = this.template({
4447
data: data
4548
});
@@ -110,7 +113,6 @@ define([
110113

111114
if (from === arrayLength) {
112115
this.updateItemsCountField();
113-
this.bindRemoveButtons();
114116
this.rendered = 1;
115117
jQuery('body').trigger('processStop');
116118

app/code/Magento/Swatches/view/adminhtml/web/js/visual.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,10 @@ define([
4242
if (!data.intype) {
4343
data.intype = swatchOptionVisualDefaultInputType;
4444
}
45+
46+
if (!this.totalItems) {
47+
data.checked = 'checked';
48+
}
4549
element = this.template({
4650
data: data
4751
});

app/design/frontend/Magento/blank/etc/view.xml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@
221221
<var name="width"></var> <!-- Width of magnifier block -->
222222
<var name="height"></var> <!-- Height of magnifier block -->
223223
<var name="eventType">hover</var> <!-- Action that atcivates zoom (hover/click) -->
224-
<var name="enabled">true</var> <!-- Turn on/off magnifier (true/false) -->
224+
<var name="enabled">false</var> <!-- Turn on/off magnifier (true/false) -->
225225
</var>
226226

227227
<var name="breakpoints">
@@ -233,9 +233,6 @@
233233
<var name="options">
234234
<var name="navigation">dots</var>
235235
</var>
236-
<var name="magnifierOpts">
237-
<var name="enabled">false</var>
238-
</var>
239236
</var>
240237
</var>
241238
</var>

app/design/frontend/Magento/luma/etc/view.xml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@
225225
<var name="width"></var> <!-- Width of magnifier block -->
226226
<var name="height"></var> <!-- Height of magnifier block -->
227227
<var name="eventType">hover</var> <!-- Action that atcivates zoom (hover/click) -->
228-
<var name="enabled">true</var> <!-- Turn on/off magnifier (true/false) -->
228+
<var name="enabled">false</var> <!-- Turn on/off magnifier (true/false) -->
229229
</var>
230230

231231
<var name="breakpoints">
@@ -237,9 +237,6 @@
237237
<var name="options">
238238
<var name="nav">dots</var>
239239
</var>
240-
<var name="magnifierOpts">
241-
<var name="enabled">false</var>
242-
</var>
243240
</var>
244241
</var>
245242
</var>

lib/web/mage/validation.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1242,7 +1242,7 @@
12421242
'required-swatch-entry': [
12431243
function (value, element) {
12441244
var empty = $(element).closest('table')
1245-
.find('input.required-option')
1245+
.find('input.required-option:visible')
12461246
.filter(function(i, el){
12471247
return $.mage.isEmpty(el.value);
12481248
})

lib/web/magnifier/magnifier.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -488,15 +488,21 @@
488488
} else {
489489
var top = options.top + 'px';
490490
}
491-
largeWrapper[0].style.top = top.replace("%px", "%");
491+
492+
if (largeWrapper.length) {
493+
largeWrapper[0].style.top = top.replace("%px", "%");
494+
}
492495
}
493496
if (options.left) {
494497
if (typeof options.left == 'function') {
495498
var left = options.left() + 'px';
496499
} else {
497500
var left = options.left + 'px';
498501
}
499-
largeWrapper[0].style.left = left.replace("%px", "%");
502+
503+
if (largeWrapper.length) {
504+
largeWrapper[0].style.left = left.replace("%px", "%");
505+
}
500506
}
501507

502508
data[idx] = {

0 commit comments

Comments
 (0)