Skip to content

Commit bc179c1

Browse files
author
Evgeniy Kolesov
committed
MAGETWO-44528: Poor UX of "Create Packages" popup while creating shipping label
1 parent 010775e commit bc179c1

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

app/code/Magento/Shipping/view/adminhtml/templates/order/packaging/grid.phtml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,11 @@
1616
<th class="data-grid-checkbox-cell">
1717
<label class="data-grid-checkbox-cell-inner">
1818
<input type="checkbox"
19-
id="select-items-<?php echo $randomId; ?>"
19+
id="select-items-<?php /* @noEscape */ echo $randomId; ?>"
2020
onchange="packaging.checkAllItems(this);"
2121
class="checkbox admin__control-checkbox"
2222
title="<?php /* @escapeNotVerified */ echo __('Select All') ?>">
23-
<label for="select-items-<?php echo $randomId; ?>"></label>
23+
<label for="select-items-<?php /* @noEscape */ echo $randomId; ?>"></label>
2424
</label>
2525
</th>
2626
<th class="data-grid-th"><?php /* @escapeNotVerified */ echo __('Product Name') ?></th>
@@ -46,14 +46,14 @@
4646
<?php endif; ?>
4747
<tr class="data-grid-controls-row data-row <?php echo ($i++ % 2 != 0) ? '_odd-row' : ''; ?>">
4848
<td class="data-grid-checkbox-cell">
49-
<?php /* @escapeNotVerified */ $id = $item->getId() ? $item->getId() : $item->getOrderItemId(); ?>
49+
<?php $id = $item->getId() ? $item->getId() : $item->getOrderItemId(); ?>
5050
<label class="data-grid-checkbox-cell-inner">
5151
<input type="checkbox"
5252
name=""
53-
id="select-item-<?php echo $randomId . '-' . $id; ?>"
53+
id="select-item-<?php /* @noEscape */ echo $randomId . '-' . $id; ?>"
5454
value="<?php /* @escapeNotVerified */ echo $id; ?>"
5555
class="checkbox admin__control-checkbox">
56-
<label for="select-item-<?php echo $randomId . '-' . $id; ?>"></label>
56+
<label for="select-item-<?php /* @noEscape */ echo $randomId . '-' . $id; ?>"></label>
5757
</label>
5858
</td>
5959
<td>

app/code/Magento/Shipping/view/adminhtml/templates/order/packaging/popup.phtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ $girthEnabled = $block->isDisplayGirthValue() && $block->isGirthAllowed() ? 1 :
5252
});
5353
jQuery('#packaging_window').modal({
5454
type: 'slide',
55-
title: '<?php /* @escapeNotVerified */ echo __('Create Packages') ?>',
55+
title: '<?php /* @escapeNotVerified */ echo __('Create Packages') ?>',
5656
buttons: [{
5757
text: '<?php /* @escapeNotVerified */ echo __('Cancel') ?>',
5858
'class': 'action-secondary',

0 commit comments

Comments
 (0)