Skip to content

Commit bb1ba14

Browse files
committed
Fix new iTxt segment creation for PNG image XMP segment
1 parent 6d15bb1 commit bb1ba14

File tree

1 file changed

+3
-13
lines changed
  • app/code/Magento/MediaGalleryMetadata/Model/Png/Segment

1 file changed

+3
-13
lines changed

app/code/Magento/MediaGalleryMetadata/Model/Png/Segment/WriteXmp.php

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -80,9 +80,11 @@ public function execute(FileInterface $file, MetadataInterface $metadata): FileI
8080
}
8181

8282
if (empty($pngXmpSegments)) {
83+
$segments[] = $this->createPngXmpSegment($metadata);
84+
8385
return $this->fileFactory->create([
8486
'path' => $file->getPath(),
85-
'segments' => $this->insertPngXmpSegment($segments, $this->createPngXmpSegment($metadata))
87+
'segments' => $segments
8688
]);
8789
}
8890

@@ -96,18 +98,6 @@ public function execute(FileInterface $file, MetadataInterface $metadata): FileI
9698
]);
9799
}
98100

99-
/**
100-
* Insert XMP segment to image png segments (at position 1)
101-
*
102-
* @param SegmentInterface[] $segments
103-
* @param SegmentInterface $xmpSegment
104-
* @return SegmentInterface[]
105-
*/
106-
private function insertPngXmpSegment(array $segments, SegmentInterface $xmpSegment): array
107-
{
108-
return array_merge(array_slice($segments, 0, 2), [$xmpSegment], array_slice($segments, 2));
109-
}
110-
111101
/**
112102
* Write new png segment metadata
113103
*

0 commit comments

Comments
 (0)