MTA-2483: Extend Update Category

- Changed type of setting store view.

Author: orykh

dev/tests/functional/tests/app/Magento/Catalog/Test/Block/Adminhtml/Category/Edit/CategoryForm.php

@@ -7,30 +7,32 @@
 namespace Magento\Catalog\Test\Block\Adminhtml\Category\Edit;
 
 use Magento\Backend\Test\Block\Widget\FormTabs;
+use Magento\Mtf\Client\Element\SimpleElement;
+use Magento\Mtf\Client\Locator;
 use Magento\Mtf\Factory\Factory;
+use Magento\Mtf\Fixture\FixtureInterface;
 
 /**
- * Class CategoryForm
- * Category container block
+ * Category container block.
  */
 class CategoryForm extends FormTabs
 {
     /**
-     * Save button
+     * Default sore switcher block locator.
      *
      * @var string
      */
-    protected $saveButton = '[data-ui-id=category-edit-form-save-button]';
+    protected $storeSwitcherBlock = '.store-switcher';
 
     /**
-     * Category Products grid
+     * Dropdown block locator.
      *
      * @var string
      */
-    protected $productsGridBlock = '#catalog_category_products';
+    protected $dropdownBlock = '.dropdown';
 
     /**
-     * Get Category edit form
+     * Get Category edit form.
      *
      * @return \Magento\Catalog\Test\Block\Adminhtml\Category\Tab\ProductGrid
      */
@@ -40,4 +42,25 @@ public function getCategoryProductsGrid()
             $this->_rootElement->find($this->productsGridBlock)
         );
     }
+
+    /**
+     * Fill form with tabs.
+     *
+     * @param FixtureInterface $fixture
+     * @param SimpleElement|null $element
+     * @return FormTabs
+     */
+    public function fill(FixtureInterface $fixture, SimpleElement $element = null)
+    {
+        $tabs = $this->getFieldsByTabs($fixture);
+        if ($fixture->hasData('store_id')) {
+            $store = $fixture->getStoreId();
+            $storeSwitcherBlock = $this->browser->find($this->storeSwitcherBlock);
+            $storeSwitcherBlock->find($this->dropdownBlock, Locator::SELECTOR_CSS, 'liselectstore')->setValue($store);
+            $this->browser->acceptAlert();
+
+        }
+
+        return $this->fillTabs($tabs, $element);
+    }
 }

dev/tests/functional/tests/app/Magento/Catalog/Test/Constraint/AssertCategoryWithCustomStoreOnFrontend.php

@@ -10,7 +10,6 @@
 use Magento\Catalog\Test\Page\Category\CatalogCategoryView;
 use Magento\Mtf\Client\BrowserInterface;
 use Magento\Mtf\Constraint\AbstractConstraint;
-use Magento\Store\Test\Fixture\Store;
 use Magento\Cms\Test\Page\CmsIndex;
 
 /**
@@ -28,26 +27,34 @@ class AssertCategoryWithCustomStoreOnFrontend extends AbstractConstraint
      * @param BrowserInterface $browser
      * @param CatalogCategoryView $categoryView
      * @param Category $category
-     * @param Store $store
+     * @param Category $initialCategory
      * @param CmsIndex $cmsIndex
      * @return void
      */
     public function processAssert(
         BrowserInterface $browser,
         CatalogCategoryView $categoryView,
         Category $category,
-        Store $store,
+        Category $initialCategory,
         CmsIndex $cmsIndex
     ) {
         $cmsIndex->open();
         $cmsIndex->getLinksBlock()->waitWelcomeMessage();
-        $cmsIndex->getStoreSwitcherBlock()->selectStoreView($store->getName());
+        $browser->open($_ENV['app_frontend_url'] . $initialCategory->getUrlKey() . '.html');
+        \PHPUnit_Framework_Assert::assertEquals(
+            $initialCategory->getName(),
+            $categoryView->getTitleBlock()->getTitle(),
+            'Wrong page is displayed on default store.'
+        );
+
+        $store = $category->getDataFieldConfig('store_id')['source']->store->getName();
+        $cmsIndex->getStoreSwitcherBlock()->selectStoreView($store);
         $cmsIndex->getLinksBlock()->waitWelcomeMessage();
-        $browser->open($_ENV['app_frontend_url'] . $category->getUrlKey() . '.html');
+        $browser->open($_ENV['app_frontend_url'] . $initialCategory->getUrlKey() . '.html');
         \PHPUnit_Framework_Assert::assertEquals(
             $category->getName(),
             $categoryView->getTitleBlock()->getTitle(),
-            'Wrong page is displayed.'
+            'Wrong page is displayed on ' . $store
         );
     }
 

dev/tests/functional/tests/app/Magento/Catalog/Test/Fixture/Category.xml

@@ -41,5 +41,6 @@
         <field name="landing_page" group="display_setting" source="Magento\Catalog\Test\Fixture\Category\LandingPage" />
         <field name="display_mode" group="display_setting" />
         <field name="category_products" group="category_products" source="Magento\Catalog\Test\Fixture\Category\CategoryProducts" />
+        <field name="store_id" group="null" source="Magento\Catalog\Test\Fixture\Category\StoreId" />
     </fixture>
 </config>

dev/tests/functional/tests/app/Magento/Catalog/Test/Fixture/Category/StoreId.php

@@ -0,0 +1,58 @@
+<?php
+/**
+ * Copyright © 2015 Magento. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+namespace Magento\Catalog\Test\Fixture\Category;
+
+use Magento\Mtf\Fixture\DataSource;
+use Magento\Mtf\Fixture\FixtureFactory;
+use Magento\Store\Test\Fixture\Store;
+use Magento\Store\Test\Fixture\StoreGroup;
+
+/**
+ * Category store id scope.
+ */
+class StoreId extends DataSource
+{
+    /**
+     * Store fixture.
+     *
+     * @var Store
+     */
+    public $store;
+
+    /**
+     * @constructor
+     * @param FixtureFactory $fixtureFactory
+     * @param array $params
+     * @param array $data [optional]
+     */
+    public function __construct(FixtureFactory $fixtureFactory, array $params, array $data = [])
+    {
+        $this->params = $params;
+
+        if (isset($data['dataset'])) {
+            $store = $fixtureFactory->createByCode('store', $data);
+            /** @var Store $store */
+            if (!$store->getStoreId()) {
+                $store->persist();
+            }
+            $this->store = $store;
+            $this->data = $store->getGroupId() . '/' . $store->getName();
+        } else {
+            $this->data = $data;
+        }
+    }
+
+    /**
+     * Return Store fixture.
+     *
+     * @return Store
+     */
+    public function getStore()
+    {
+        return $this->store;
+    }
+}

dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/Category/UpdateCategoryEntityTest.php

@@ -10,7 +10,6 @@
 use Magento\Catalog\Test\Page\Adminhtml\CatalogCategoryEdit;
 use Magento\Catalog\Test\Page\Adminhtml\CatalogCategoryIndex;
 use Magento\Mtf\TestCase\Injectable;
-use Magento\Store\Test\Fixture\Store;
 
 /**
  * Test Creation for UpdateCategoryEntity
@@ -75,12 +74,10 @@ public function __inject(
      *
      * @param Category $category
      * @param Category $initialCategory
-     * @param Store $store
      * @return void
      */
-    public function test(Category $category, Category $initialCategory, Store $store)
+    public function test(Category $category, Category $initialCategory)
     {
-        $store->persist();
         $this->catalogCategoryIndex->open();
         $this->catalogCategoryIndex->getTreeCategories()->selectCategory($initialCategory);
         $this->catalogCategoryEdit->getEditForm()->fill($category);

dev/tests/functional/tests/app/Magento/Catalog/Test/TestCase/Category/UpdateCategoryEntityTest.xml

@@ -47,11 +47,8 @@
             <constraint name="Magento\Catalog\Test\Constraint\AssertCategoryForm" />
         </variation>
         <variation name="UpdateCategoryEntityTestVariation4">
-            <data name="category/data/parent_id/dataset" xsi:type="string">default_category</data>
-            <data name="category/data/name" xsi:type="string">Name%isolation%</data>
-            <data name="category/data/url_key" xsi:type="string">UrlKey%isolation%</data>
-            <data name="category/data/is_active" xsi:type="string">Yes</data>
-            <data name="store/dataset" xsi:type="string">custom</data>
+            <data name="category/data/store_id/dataset" xsi:type="string">custom</data>
+            <data name="category/data/name" xsi:type="string">Category %isolation%</data>
             <constraint name="Magento\Catalog\Test\Constraint\AssertCategorySaveMessage" />
             <constraint name="Magento\Catalog\Test\Constraint\AssertCategoryWithCustomStoreOnFrontend" />
         </variation>